From: "Laszlo Ersek" <lersek@redhat.com>
To: "Sheng, W" <w.sheng@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
"Kumar, Rahul1" <rahul1.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit
Date: Fri, 5 Feb 2021 16:13:50 +0100 [thread overview]
Message-ID: <48aa5d2c-372d-31e5-0a69-8ae0a2234372@redhat.com> (raw)
In-Reply-To: <CY4PR11MB19285D863AF72FCCBB14339AE1B29@CY4PR11MB1928.namprd11.prod.outlook.com>
On 02/05/21 10:35, Sheng, W wrote:
> Hi Jiewen, Eric, Ray, Rahul, Ersek,
> I have updated the patch v2. And all comments are fixed.
> Since open CI is using NASM 2.14.02, it has not supported CET instructions yet.
> I would like to use DB xx xx xx xx to replace the assembly instruction before NASM 2.15.01 is used by open CI.
> Could you continue the code review ?
> Thank you.
> BR
> Sheng Wei
I'll let others review this patch.
I'm OK to add macros to the nasm.inc files under MdePkg, as wrappers for
the DB-encoded CET instructions, as long as you also file a reminder BZ
to replace the DBs with the actual instructions, once a CET-supporting
NASM becomes available in CI.
Thanks
Laszlo
prev parent reply other threads:[~2021-02-05 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 7:59 [PATCH 0/2] Fix #DF issue when enable CET shadow stack feature Sheng Wei
2021-01-29 7:59 ` [PATCH 1/2] MdePkg/Include: Add CET instructions to Nasm.inc Sheng Wei
2021-01-29 7:59 ` [PATCH 2/2] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit Sheng Wei
2021-01-31 1:38 ` Yao, Jiewen
[not found] ` <165F2D66EAF4D84C.16314@groups.io>
2021-01-31 1:46 ` [edk2-devel] " Yao, Jiewen
2021-02-03 2:43 ` Sheng Wei
2021-02-05 9:35 ` Sheng Wei
2021-02-05 15:13 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48aa5d2c-372d-31e5-0a69-8ae0a2234372@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox