From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web12.9315.1612538036721940713
 for <devel@edk2.groups.io>;
 Fri, 05 Feb 2021 07:13:56 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OUiiNanu;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1612538035;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=OvMxp/rDur+opp7Hyvb9gC9KvN4EHr2QnvgGPaB6gZs=;
	b=OUiiNanumEylrsGPPC36By3am4a5saH24UguP4nVCram/twXosOWsIidAtm0gyGmASyYcF
	My6QqH/62ibnFmhF2u+oDr7AQp9CdaTWvGlR4uNxWiZIZU4Xe1WVUuRJBg7gKqHB82O3me
	loo2cxRjF5KZRDP8tlv+bsU2/y6JfYE=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-419-aPj7kh_HMlyVDhdpF_5xuA-1; Fri, 05 Feb 2021 10:13:54 -0500
X-MC-Unique: aPj7kh_HMlyVDhdpF_5xuA-1
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E99D4107ACE8;
	Fri,  5 Feb 2021 15:13:52 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-245.ams2.redhat.com [10.36.113.245])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 9D26D5D9FC;
	Fri,  5 Feb 2021 15:13:51 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit
To: "Sheng, W" <w.sheng@intel.com>, "Yao, Jiewen" <jiewen.yao@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
 "Kumar, Rahul1" <rahul1.kumar@intel.com>
References: <20210129075946.31684-1-w.sheng@intel.com>
 <20210129075946.31684-3-w.sheng@intel.com> <165F2D66EAF4D84C.16314@groups.io>
 <BY5PR11MB416640FC61E07A47C799EF8D8CB79@BY5PR11MB4166.namprd11.prod.outlook.com>
 <CY4PR11MB19281CC60C56C2B1E9BD6B41E1B49@CY4PR11MB1928.namprd11.prod.outlook.com>
 <CY4PR11MB19285D863AF72FCCBB14339AE1B29@CY4PR11MB1928.namprd11.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <48aa5d2c-372d-31e5-0a69-8ae0a2234372@redhat.com>
Date: Fri, 5 Feb 2021 16:13:50 +0100
MIME-Version: 1.0
In-Reply-To: <CY4PR11MB19285D863AF72FCCBB14339AE1B29@CY4PR11MB1928.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 02/05/21 10:35, Sheng, W wrote:
> Hi Jiewen, Eric, Ray, Rahul, Ersek,
> I have updated the patch v2. And all comments are fixed.
> Since open CI is using NASM 2.14.02, it has not supported CET instructions yet. 
> I would like to use DB xx xx xx xx to replace the assembly instruction before NASM 2.15.01 is used by open CI.
> Could you continue the code review ?
> Thank you.
> BR
> Sheng Wei

I'll let others review this patch.

I'm OK to add macros to the nasm.inc files under MdePkg, as wrappers for
the DB-encoded CET instructions, as long as you also file a reminder BZ
to replace the DBs with the actual instructions, once a CET-supporting
NASM becomes available in CI.

Thanks
Laszlo