From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.4276.1622104477680813620 for ; Thu, 27 May 2021 01:34:37 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fWemRJXs; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E2kLm/K2GRXIj1MzYgqXDQVuzMkjymCj/oWXD7IQKQI=; b=fWemRJXssNRgMrGnX4wtaVxxPBX/ClPg2zXuLfgLor+nGBD/I723/4xm3mjruO+92QuB1m 1bb5hqowCwkpyP8RTUXaqT4NRFJqn/KRb5N/sq98ZFJRxR066foLi7YekEmB8tfK9+YpI6 XDaFEBTM0JHHu7q2OIxbXbCHN8SyJgU= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-182-1DuPGFJFN-WflkdJHgc0nA-1; Thu, 27 May 2021 04:34:35 -0400 X-MC-Unique: 1DuPGFJFN-WflkdJHgc0nA-1 Received: by mail-wm1-f71.google.com with SMTP id x20-20020a1c7c140000b029018f49a7efb7so1232571wmc.1 for ; Thu, 27 May 2021 01:34:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=E2kLm/K2GRXIj1MzYgqXDQVuzMkjymCj/oWXD7IQKQI=; b=sey0R8qh1g9DVbsbVmOrdPgKrIuiphlaimaWxw0aW5erUslKtJQk3BgRx0II27FjTf Oltqso+0UJUUHAyqbg0QeNkDK3L0UKQqV0kdJxemYDgspV+YvSDdC9TuzeKGzjvhC1g0 dTZ59V2PJSfZa9EMFskzZxjYUAVi0rKt22Bpwu1NOdsXT/gYlWh0He191MjALKfX5yVN Zt+qPFGhCxgCaNNk8dj5zbguAP90lXtW2oE427NxwzzLllR5rAOpJG+7j2qanpjyEQ+U aGndEEjhhZnuH1Q4JeUY9W1L8bCelPMJC8ItV7Vdkn4w2yzSUtb2fF6xnnjn1GmKZXbs XBTA== X-Gm-Message-State: AOAM530oBObAgOD9ObY5siu4RFBrArEkm6N194kINRh7WvttufeNx/R+ QR1gQgdnCYXh2z+LZRLSyLGKt2/8rdSZn+L9mOLrGRt4hZ4zaLtRoTcZS0AeWSckwFf8kkgTdiM jJZgV96IKPpXvDQ== X-Received: by 2002:adf:f5c5:: with SMTP id k5mr2022181wrp.81.1622104474106; Thu, 27 May 2021 01:34:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXJvDMLaLFuAjtTGnGM9wCQ+jlqLzjHlB9tziv4jX7nswp3XIXvr0TFybqVaEZ25uQ/lNcQA== X-Received: by 2002:adf:f5c5:: with SMTP id k5mr2022175wrp.81.1622104473979; Thu, 27 May 2021 01:34:33 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id j14sm9622888wmj.19.2021.05.27.01.34.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:34:33 -0700 (PDT) Subject: Re: [PATCH 36/43] OvmfPkg/SmbiosPlatformDxe: clean up #includes and INF To: Laszlo Ersek , devel@edk2.groups.io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-37-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <48afe119-c373-fcb5-93cc-625a9424c218@redhat.com> Date: Thu, 27 May 2021 10:34:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-37-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > - Sort all sections in the INF file. > > - Remove unused packages (MdeModulePkg) and lib classes (BaseMemoryLib) > from the INF file. > > - Restrict some lib classes (BaseLib, HobLib) and GUIDs (gEfiXenInfoGuid) > to IA32 and X64, in the INF file; only the IA32/X64 Xen implementation > requires these. > > - Don't make "SmbiosPlatformDxe.h" #include everything just as a > convenience. Spell out directly needed #includes in every file (annotate > each with an example identifier consumed), drop unused #includes. > > - Keep #includes sorted. > > - Remove the leading underscore from the #include guard macro name in > "SmbiosPlatformDxe.h". > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.inf | 20 ++++++++++---------- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.h | 15 +++------------ > OvmfPkg/SmbiosPlatformDxe/Qemu.c | 8 +++++--- > OvmfPkg/SmbiosPlatformDxe/SmbiosPlatformDxe.c | 6 ++++++ > OvmfPkg/SmbiosPlatformDxe/X86Xen.c | 6 ++++-- > 5 files changed, 28 insertions(+), 27 deletions(-) Reviewed-by: Philippe Mathieu-Daude