From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id ABE58D811C5 for ; Thu, 2 May 2024 10:34:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=vpB4Ztw6OAwjz4AA6t9u1wgUMRUGuAimzLkS5pUdk5s=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714646068; v=1; b=aEl5OG5agMxOwhXxpUJgZL6NjgwFxV78kSq2HXe9NHKKY1mKREjDFWvjPDPZlKbsS5mYdMAv KOajqZlZee4iiQWnhpPS4X/Re6FJ6Qf8SwOv6BZ5+uNY8VWSrzdRGEeEhqf7fwKIVUlyr95D9+W ALIwAaw4dJo/a1KpcNR7Ts2ctXbb5Zu1zVOr68GpfL3C9ZTOhU4OyqhpAZPLZJiWLQ5ENYRkkkv tog8ISEA7s4n421NwMKa9X1jZ4iphGqWPOYDxcIT7vSpgPebxe2ZHmAbkcg6flhNe+LjWSKGBF/ BzuxksKDu/eTtgRRxFf88UffZsdr1/AT/lX1ubJSksqsg== X-Received: by 127.0.0.2 with SMTP id T8gkYY7687511xB50DOMqmvI; Thu, 02 May 2024 03:34:28 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.10338.1714646067413393518 for ; Thu, 02 May 2024 03:34:27 -0700 X-Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4428LKnR017965; Thu, 2 May 2024 10:34:21 GMT X-Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xurt71tur-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 May 2024 10:34:21 +0000 (GMT) X-Received: from m0279873.ppops.net (m0279873.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 442AYL2j029003; Thu, 2 May 2024 10:34:21 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3xurt71tun-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 May 2024 10:34:21 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 442AYKRr023351 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 2 May 2024 10:34:20 GMT X-Received: from [10.111.142.244] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Thu, 2 May 2024 03:34:18 -0700 Message-ID: <48c29377-f274-4e78-865d-3bda9607727b@quicinc.com> Date: Thu, 2 May 2024 11:34:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Proposal to switch TianoCore Code Review from email to GitHub Pull Requests on 5-24-2024 To: , , , "rfc@edk2.groups.io" CC: Leif Lindholm , "Andrew Fish (afish@apple.com)" References: <1a957a2a-f055-4af8-bdca-e6117a0dd5ae@linaro.org> From: "Leif Lindholm" In-Reply-To: <1a957a2a-f055-4af8-bdca-e6117a0dd5ae@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: 9XcncVIOsM4eLoyVM0EsCDriBrrKWC-x X-Proofpoint-ORIG-GUID: uiVLdCdxyYLEFmYWKx6mzpA1AqZ6cMfs X-MIME-Autoconverted: from 8bit to quoted-printable by mx0a-0031df01.pphosted.com id 4428LKnR017965 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 03:34:27 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kEvvApYZULlDvCtPEt1LEhuEx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=aEl5OG5a; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none) On 2024-05-02 07:33, Marcin Juszkiewicz wrote: > W dniu 1.05.2024 o=C2=A019:43, Michael D Kinney via groups.io pisze: >> I would like to propose that TianoCore move all code review from email >> based code reviews to GitHub Pull Requests based code reviews. >> >> The proposed date to switch would be immediately after the next stable >> tag which is currently scheduled for May 24, 2024. >=20 > O yes! Fully for it! >=20 > Does it mean edk2 only or edk2/edk2-platforms/edk2-non-osi and other=20 > tianocore/ repositories? I don't see why we couldn't switch all of them. Other than we need to=20 get all the Maintainers.txt updated with code forge usernames first. We may want to do one at a time though. / Leif >> * The Pull Request submitter is required to invite the required >> =C2=A0=C2=A0 maintainers and reviewers to the pull request. This is the = same >> =C2=A0=C2=A0 set of maintainers and reviewers that are required to be li= sted in >> =C2=A0=C2=A0 Cc: tags in today's process. >=20 > That can be done by github action started automatically after opening=20 > PR. May require changes to GetMaintainer.py script. Would be good to=20 > have in case someone forget to add one of maintainers. >=20 > Also would be nice to have a bot running PatchCheck and uncrustify on PR. >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118505): https://edk2.groups.io/g/devel/message/118505 Mute This Topic: https://groups.io/mt/105847510/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-