From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mx.groups.io with SMTP id smtpd.web09.1872.1623695792887018459 for ; Mon, 14 Jun 2021 11:36:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Wy0d+Dtw; spf=pass (domain: gmail.com, ip: 209.85.210.174, mailfrom: kuqin12@gmail.com) Received: by mail-pf1-f174.google.com with SMTP id u18so11201806pfk.11 for ; Mon, 14 Jun 2021 11:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eG6+kzTeTCFxKJkMQKMpuEQhOSu1VVP89XH1jQuV3Z8=; b=Wy0d+DtwVKxmIzS5SH49TXTB73b+CtkTa/xzji1kmJ5ZlW5ReJF0iE28Wj50uHzuUI sTHuyRXycQ90dOP5Qd7LafmxA//Y3txRggQy6AN2VE9FTPBFDnd0nR22JmZAvRY6xDyB goLmTZ6lcgEEeEQLzd9mQxZ2/BxPOoJ+rNHSVTgFZ9YvpfD3AVdSxWnx/w7E6ZsG8w1m 5QevlP91Uqd3eUX8N+83kmJ+DjONpXtt46x44UWB5fR9yOzdbqPnM+nc1EKCHp1klX7s DrYhS0T/FpIrZClR4dY+U3L1067o0b8sxqAcJVNzaK6DZczFx01vOimGvliqDiGx+Run nYwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eG6+kzTeTCFxKJkMQKMpuEQhOSu1VVP89XH1jQuV3Z8=; b=BnOOjDlsY8ArbWNZdDjXfiHp9H5kPMXMeMq5xy8FkDqVwfisp37+o+EAFw0WfHxoC6 Ygg5oRXf99ERa2b4a3mkJ/+UBXmg2LIvrte28dhKfF6HtRcqB9qo+SlVQynQ3UgwtOoy BkVNwVez2dLDktFy4rtFRPMiJicNFND9tXf3qeDQdSk07pmW5bgohZgMrGujEvIWEL1P j/yJihy9Df+Dht/dV0xzcbQWAetZ+Xtt1v7ggmP6eyF7+frQNE/kFBYASXFgnoMZEXJX Hzjh66depTqaUekkRugWWDJJrx2NMZgHt83ACgMbp5I6vQH9v2vHJGrOXAr0ULTz1WiK HDBg== X-Gm-Message-State: AOAM531jdyowgg2muszUrgroafsLXFjVZMpXrFSchuIB3ZREUOvqfHHq wIadMwcn20yNEKstD6VTCy9d8Ba48oIWhw== X-Google-Smtp-Source: ABdhPJw4Mu4vzbCMIpCy+/jc96k7pr21aYGs7B38TaY+txMI6dn7bXyzTGgs6e2TI4J4UdmNEwwD9g== X-Received: by 2002:a63:1c0a:: with SMTP id c10mr18294588pgc.306.1623695792516; Mon, 14 Jun 2021 11:36:32 -0700 (PDT) Return-Path: Received: from [192.168.50.18] ([50.35.88.161]) by smtp.gmail.com with ESMTPSA id c18sm4350167pgf.66.2021.06.14.11.36.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jun 2021 11:36:32 -0700 (PDT) Subject: Re: [PATCH v1 1/4] StandaloneMmPkg: Core: Spelling error in comment To: Ard Biesheuvel Cc: edk2-devel-groups-io , Ard Biesheuvel , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh , Sean Brogan References: <20210612034422.536-1-kuqin12@gmail.com> <20210612034422.536-2-kuqin12@gmail.com> From: "Kun Qin" Message-ID: <48c737db-e7b5-a22a-1da8-0b3b86c5feaa@gmail.com> Date: Mon, 14 Jun 2021 11:36:30 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard, Sorry for the confusion and thanks for providing the r-b tag. This should be fixed in v2 patches: https://edk2.groups.io/g/devel/message/76479 Regards, Kun On 06/12/2021 01:22, Ard Biesheuvel wrote: > On Sat, 12 Jun 2021 at 05:44, Kun Qin wrote: >> >> From: Sean Brogan >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 >> >> This change fixed a misspelling that was not caught by spell check. >> >> Cc: Ard Biesheuvel >> Cc: Sami Mujawar >> Cc: Jiewen Yao >> Cc: Supreeth Venkatesh >> Cc: Sean Brogan >> >> Signed-off-by: Sean Brogan > > Hello Kun Qin, > > When you send patches to the list that were authored by someone else, > you should add your own signoff, and add it last. (The signoff means > that you attest that the patch is contributed under terms that are > compatible with the open source licenses we support. The signoff has > nothing to do with recognizing authorship, so even if someone else did > most of the work, if that person is not involved in contributing these > changes, their name does not need to appear in the Git log.) > > Sean is the author, which will be reflected in the git log anyway, so > his signoff does not have any significance here, as he is not the one > sending the patch to the public mailing list. > > Usually, I would fix up minor issues like these when merging the > changes, but adding a signoff on someone else's behalf is the one > thing I can never do. > > So please fix this up, and then you can add > > Reviewed-by: Ard Biesheuvel > > to the entire series. > > Thanks, > > > >> --- >> StandaloneMmPkg/Core/Dispatcher.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c >> index dbd5332fa9d3..7e4bf5e94025 100644 >> --- a/StandaloneMmPkg/Core/Dispatcher.c >> +++ b/StandaloneMmPkg/Core/Dispatcher.c >> @@ -4,7 +4,7 @@ >> Step #1 - When a FV protocol is added to the system every driver in the FV >> is added to the mDiscoveredList. The Before, and After Depex are >> pre-processed as drivers are added to the mDiscoveredList. If an Apriori >> - file exists in the FV those drivers are addeded to the >> + file exists in the FV those drivers are added to the >> mScheduledQueue. The mFwVolList is used to make sure a >> FV is only processed once. >> >> -- >> 2.31.1.windows.1 >>