From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DC71921E0816C for ; Fri, 30 Mar 2018 12:44:03 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4831076FBA; Fri, 30 Mar 2018 19:44:02 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-177.rdu2.redhat.com [10.10.120.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8845E10B2B51; Fri, 30 Mar 2018 19:43:59 +0000 (UTC) From: Laszlo Ersek To: edk2-devel-01 Cc: Ruiyu Ni , Eric Dong , Ard Biesheuvel , Jordan Justen , Gary Ching-Pang Lin , Anthony Perard , Star Zeng References: <20180328202651.1478-1-lersek@redhat.com> Message-ID: <48c987d8-fe96-d1b3-25c5-d5ca4e5217c7@redhat.com> Date: Fri, 30 Mar 2018 21:43:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180328202651.1478-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 30 Mar 2018 19:44:02 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 30 Mar 2018 19:44:02 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH 0/4] MdeModulePkg, OvmfPkg: support large CA cert list for HTTPS boot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 19:44:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/28/18 22:26, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: https_cacert_rhbz_1536624 According to Star's feedback, I modified patch #1 as follows: > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > index 5a9051648004..6caf603b3d30 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c > @@ -3842,10 +3842,6 @@ InitNonVolatileVariableStore ( > > mVariableModuleGlobal->MaxVariableSize = PcdGet32 (PcdMaxVariableSize); > mVariableModuleGlobal->MaxAuthVariableSize = ((PcdGet32 (PcdMaxAuthVariableSize) != 0) ? PcdGet32 (PcdMaxAuthVariableSize) : mVariableModuleGlobal->MaxVariableSize); > - mVariableModuleGlobal->MaxVolatileVariableSize = ((PcdGet32 (PcdMaxVolatileVariableSize) != 0) ? > - PcdGet32 (PcdMaxVolatileVariableSize) : > - mVariableModuleGlobal->MaxVariableSize > - ); > > // > // Parse non-volatile variable data and get last variable offset. > @@ -4261,6 +4257,10 @@ VariableCommonInitialize ( > } > } > > + mVariableModuleGlobal->MaxVolatileVariableSize = ((PcdGet32 (PcdMaxVolatileVariableSize) != 0) ? > + PcdGet32 (PcdMaxVolatileVariableSize) : > + mVariableModuleGlobal->MaxVariableSize > + ); > // > // Allocate memory for volatile variable store, note that there is a scratch space to store scratch data. > // and I added the feedback tags like this: > Reviewed-by: Gary Lin > Tested-by: Gary Lin > [lersek@redhat.com: set MaxVolatileVariableSize where Star suggested] > Reviewed-by: Star Zeng To the rest of the patches, I applied the feedback tags as usual. Before pushing the set, I retested it with an OVMF HTTPS boot, and I regression-retested it with an ArmVirtQemu disk boot. Pushed as commit range 3d7ebd643431..9c7d0d499296. Thanks everyone! Laszlo