From: Ryszard Knop <ryszard.knop@linux.intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Kacperski, Kamil" <kamil.kacperski@intel.com>,
"Jin, Eric" <eric.jin@intel.com>,
"Orlowski, Pawel" <pawel.orlowski@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Hsiung, Harry L" <harry.l.hsiung@intel.com>
Subject: Re: [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC
Date: Thu, 28 Mar 2019 11:46:50 +0100 [thread overview]
Message-ID: <48d303c0db5d5007203a1557d7e5728d19550201.camel@linux.intel.com> (raw)
In-Reply-To: <CAKv+Gu98BvCQHWDZWPzfZYuPVkvUG0WbkRk0tAkPss6Q6BD+Cg@mail.gmail.com>
On Wed, 2019-03-27 at 16:32 +0100, Ard Biesheuvel wrote:
> On Tue, 29 Jan 2019 at 14:55, Ryszard Knop <
> ryszard.knop@linux.intel.com> wrote:
> > +Team
> >
>
> As it turns out, this driver is still broken for non-1:1 mapped DMA.
>
> In particular, I am hitting a crash on
>
> E1000MemCopy (
> (UINT8 *) (UINTN) CpbReceive->BufferAddr,
> (UINT8 *) (UINTN) ReceiveDescriptor->buffer_addr,
> TempLen
> );
>
> (around line 676 in e1000.c), which uses the DMA address
> 'ReceiveDescriptor->buffer_addr' in a memory copy operation performed
> by the CPU. This causes a crash on systems where the DMA address is
> not also a valid CPU address.
Huh, this is new... I don't have access to any system behaving this
way, so I can't test this, but E1000.c -> E1000TxRxConfigure links
RxDesc->buffer_addr to the physical addresses, that descriptor is used
by the hardware to DMA data where needed, and we try to copy from that
same physical address later, while we should copy from unmapped
addresses instead.
This probably should be solved by having a separate array/something
with CurRxInd -> unmapped addresses, but I'll have to talk with my team
to solve this in a sensible way.
In the meantime, maybe you know if there's a way to simulate this
situation under QEMU or something?
> > On Tue, 2019-01-29 at 14:13 +0100, Ryszard Knop wrote:
> > > Hi Ard,
> > >
> > > I've finally got some time to review and merge all of this. A bit
> > > problematic thing is that we internally have a separate tree that
> > > we
> > > need to merge those commits into, then generate the open source
> > > tree
> > > and related commits from that. This will result in somewhat
> > > broken
> > > history, so sorry about that in advance - we're still figuring
> > > out
> > > the
> > > proper way to handle multiple source trees on our end without
> > > messing
> > > it up. I'll push these changes to edk2-staging once we've got it
> > > all
> > > ready.
> > >
> > > On Tue, 2018-11-06 at 18:58 +0100, ard.biesheuvela wrote:
> > > > This series fixes the GigUndiDxe in the edk2-staging/Intel_UNDI
> > > > branch
> > > > at github.com/tianocore so it can be built with GCC on Linux
> > > > for
> > > > ARM
> > > > and AARCH64 (as well as X64)
> > > >
> > > > Ard Biesheuvel (19):
> > > > IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported
> > > > architectures
> > > > IntelUndiPkg: remove EOF markers
> > > > IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000
> > > > in
> > > > filenames
> > > > IntelUndiPkg/GigUndiDxe: consistently use forward slashes as
> > > > path
> > > > separators
> > > > IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after
> > > > type
> > > > definition
> > > > IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for
> > > > pointers
> > > > IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT
> > > > build
> > > > options
> > > > IntelUndiPkg/GigUndiDxe: add missing VOID** cast
> > > > IntelUndiPkg/GigUndiDxe: add missing UINT8* cast
> > > > IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals
> > > > IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token
> > > > pasting
> > > > IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct
> > > > pointer
> > > > type
> > > > IntelUndiPkg/GigUndiDxe: don't take address of cast
> > > > expression
> > > > IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER
> > > > macros
> > > > for
> > > > GCC
> > > > IntelUndiPkg/GigUndiDxe: remove forward declaration of non-
> > > > existent
> > > > function
> > > > IntelUndiPkg/GigUndiDxe: fix incorrect indentation
> > > > IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF
> > > > file
> > > > IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers
> > > > IntelUndiPkg/GigUndiDxe: remove or reorganize unused
> > > > variables
> > > >
> > > > IntelUndiPkg/GigUndiDxe/AdapterInformation.c | 6 ++-
> > > > IntelUndiPkg/GigUndiDxe/AdapterInformation.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/Brand.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/ComponentName.c | 5 ++-
> > > > IntelUndiPkg/GigUndiDxe/ComponentName.h | 2 +-
> > > > IntelUndiPkg/GigUndiDxe/Decode.c | 5 +--
> > > > IntelUndiPkg/GigUndiDxe/Decode.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/DeviceSupport.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/DeviceSupport.h | 9 ++---
> > > > IntelUndiPkg/GigUndiDxe/Dma.c | 11 +++---
> > > > IntelUndiPkg/GigUndiDxe/Dma.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/DriverConfiguration.c | 6 ++-
> > > > IntelUndiPkg/GigUndiDxe/DriverConfiguration.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.c | 12 +++---
> > > > IntelUndiPkg/GigUndiDxe/DriverDiagnostics.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/DriverHealth.c | 5 ++-
> > > > IntelUndiPkg/GigUndiDxe/EepromConfig.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/EepromConfig.h | 3 +-
> > > > IntelUndiPkg/GigUndiDxe/GigUndiDxe.inf | 39 +++++++++
> > > > ------
> > > > ----
> > > > IntelUndiPkg/GigUndiDxe/Hii.c | 11 +++---
> > > > IntelUndiPkg/GigUndiDxe/Hii.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/HiiInternalLib.c | 3 --
> > > > IntelUndiPkg/GigUndiDxe/HiiInternalLib.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/Init.c | 11 +++---
> > > > IntelUndiPkg/GigUndiDxe/Init.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/Inventory.vfr | 1 -
> > > > IntelUndiPkg/GigUndiDxe/NVDataStruc.h | 7 ++--
> > > > IntelUndiPkg/GigUndiDxe/StartStop.c | 5 ++-
> > > > IntelUndiPkg/GigUndiDxe/StartStop.h | 7 ++--
> > > > IntelUndiPkg/GigUndiDxe/Version.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} | 37 ++++++++---
> > > > ----
> > > > --
> > > > -
> > > > IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} | 5 +--
> > > > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_80003es2lan.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_82571.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_82571.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_82575.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_82575.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_api.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_api.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_defines.h | 10 ++++-
> > > > IntelUndiPkg/GigUndiDxe/e1000_hw.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_i210.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_i210.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.c | 18 ++++-----
> > > > IntelUndiPkg/GigUndiDxe/e1000_ich8lan.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_mac.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_mac.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_manage.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_manage.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_nvm.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_nvm.h | 1 -
> > > > .../{E1000_osdep.c => e1000_osdep.c} | 3 +-
> > > > .../{E1000_osdep.h => e1000_osdep.h} | 8 +---
> > > > IntelUndiPkg/GigUndiDxe/e1000_phy.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_phy.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/e1000_regs.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wol.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wol.h | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wol_1G.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wolfamily.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wolimpl.c | 1 -
> > > > IntelUndiPkg/GigUndiDxe/wol/wolimpl.h | 3 +-
> > > > IntelUndiPkg/GigUndiDxe/wol/wolinfo.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/AdapterInformation.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/AdapterInformation.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Brand.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/ComponentName.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/ComponentName.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Decode.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Decode.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DeviceSupport.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DeviceSupport.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Dma.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Dma.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DriverDiagnostics.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DriverHealth.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/DriverHealthCommon.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/EepromConfig.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/EepromConfig.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Hii.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Hii.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/HiiInternalLib.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/I40e.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/I40e.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/I40eUndiDxe.inf | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/I40e_osdep.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Init.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Init.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Inventory.vfr | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/NVDataStruc.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/StartStop.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/StartStop.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/Version.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_adminq.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_adminq.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_adminq_cmd.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_alloc.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_common.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_devids.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_diag.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_diag.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_hmc.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_hmc.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_lan_hmc.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_nvm.c | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_prototype.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_register.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_status.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_type.h | 1 -
> > > > IntelUndiPkg/I40eUndiDxe/i40e_virtchnl.h | 1 -
> > > > IntelUndiPkg/IntelOpenSourceUndiPkg.dsc | 13 ++++++-
> > > > IntelUndiPkg/XGigUndiDxe/AdapterInformation.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/AdapterInformation.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Brand.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ComponentName.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ComponentName.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Decode.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Decode.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DeviceSupport.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DeviceSupport.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Dma.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Dma.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DriverDiagnostics.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DriverHealth.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/DriverHealthCommon.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/EepromConfig.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/EepromConfig.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Hii.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Hii.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/HiiInternalLib.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Init.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Init.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Inventory.vfr | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/NVDataStruc.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/StartStop.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/StartStop.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Version.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/XGigUndiDxe.inf | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Xgbe.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/Xgbe.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_82598.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_82599.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_api.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_api.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_common.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_common.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_dcb_82599.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_osdep.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_phy.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_type.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_x540.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/ixgbe_x550.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wol.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wol.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wol_10G.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wolfamily.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.c | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wolimpl.h | 1 -
> > > > IntelUndiPkg/XGigUndiDxe/wol/wolinfo.c | 1 -
> > > > 171 files changed, 120 insertions(+), 270 deletions(-)
> > > > rename IntelUndiPkg/GigUndiDxe/{E1000.c => e1000.c} (99%)
> > > > rename IntelUndiPkg/GigUndiDxe/{E1000.h => e1000.h} (99%)
> > > > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.c =>
> > > > e1000_osdep.c}
> > > > (99%)
> > > > rename IntelUndiPkg/GigUndiDxe/{E1000_osdep.h =>
> > > > e1000_osdep.h}
> > > > (99%)
> > > >
> > >
> > > _______________________________________________
> > > edk2-devel mailing list
> > > edk2-devel@lists.01.org
> > > https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2019-03-28 10:46 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 17:58 [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 01/19] IntelOpenSourceUndiPkg.dsc: add AARCH64 and ARM to supported architectures Ard Biesheuvel
2019-01-29 13:54 ` Ryszard Knop
2019-01-29 14:04 ` Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 02/19] IntelUndiPkg: remove EOF markers Ard Biesheuvel
2018-11-06 19:34 ` Philippe Mathieu-Daudé
2019-01-29 13:58 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 03/19] IntelUndiPkg/GigUndiDxe: consistently use lowercase for e1000 in filenames Ard Biesheuvel
2018-11-06 19:35 ` Philippe Mathieu-Daudé
2019-01-29 14:21 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 04/19] IntelUndiPkg/GigUndiDxe: consistently use forward slashes as path separators Ard Biesheuvel
2018-11-06 19:37 ` Philippe Mathieu-Daudé
2019-01-29 14:26 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 05/19] IntelUndiPkg/GigUndiDxe: move BRAND_STRUCT declaration after type definition Ard Biesheuvel
2019-01-29 16:02 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 06/19] IntelUndiPkg/GigUndiDxe: use intermediate UINTN casts for pointers Ard Biesheuvel
2019-01-30 10:59 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 07/19] IntelUndiPkg/GigUndiDxe: create GCC alternatives for MSFT build options Ard Biesheuvel
2019-01-30 11:48 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 08/19] IntelUndiPkg/GigUndiDxe: add missing VOID** cast Ard Biesheuvel
2018-11-07 9:16 ` Philippe Mathieu-Daudé
2018-11-07 14:05 ` Philippe Mathieu-Daudé
2019-01-30 12:05 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 09/19] IntelUndiPkg/GigUndiDxe: add missing UINT8* cast Ard Biesheuvel
2018-11-06 20:31 ` Philippe Mathieu-Daudé
2018-11-06 20:35 ` Ard Biesheuvel
2018-11-07 9:08 ` Philippe Mathieu-Daudé
2019-01-30 12:37 ` Ryszard Knop
2019-01-30 12:30 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 10/19] IntelUndiPkg/GigUndiDxe: add missing braces to GUID literals Ard Biesheuvel
2018-11-06 20:34 ` Philippe Mathieu-Daudé
2019-01-30 12:59 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 11/19] IntelUndiPkg/GigUndiDxe: fix incorrect use of CPP token pasting Ard Biesheuvel
2019-01-30 13:35 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 12/19] IntelUndiPkg/GigUndiDxe: cast E1000MemCopy () args to correct pointer type Ard Biesheuvel
2018-11-06 20:35 ` Philippe Mathieu-Daudé
2019-01-30 13:37 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 13/19] IntelUndiPkg/GigUndiDxe: don't take address of cast expression Ard Biesheuvel
2018-11-06 20:36 ` Philippe Mathieu-Daudé
2019-01-30 13:41 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 14/19] IntelUndiPkg/GigUndiDxe: redefine UNREFERENCED_nPARAMETER macros for GCC Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 15/19] IntelUndiPkg/GigUndiDxe: remove forward declaration of non-existent function Ard Biesheuvel
2018-11-06 20:40 ` Philippe Mathieu-Daudé
2019-01-30 15:26 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 16/19] IntelUndiPkg/GigUndiDxe: fix incorrect indentation Ard Biesheuvel
2018-11-06 20:41 ` Philippe Mathieu-Daudé
2018-11-06 17:58 ` [PATCH edk2-staging 17/19] IntelUndiPkg/GigUndiDxe: move MSFT warning overrides to INF file Ard Biesheuvel
2019-01-30 14:09 ` Ryszard Knop
2018-11-06 17:58 ` [PATCH edk2-staging 18/19] IntelUndiPkg/GigUndiDxe: add missing EFIAPI modifiers Ard Biesheuvel
2019-01-30 15:15 ` Ryszard Knop
2019-01-30 15:20 ` Ard Biesheuvel
2019-01-30 15:31 ` Ryszard Knop
2019-01-30 15:33 ` Ard Biesheuvel
2018-11-06 17:58 ` [PATCH edk2-staging 19/19] IntelUndiPkg/GigUndiDxe: remove or reorganize unused variables Ard Biesheuvel
2018-11-07 9:08 ` Philippe Mathieu-Daudé
2019-01-30 14:32 ` Ryszard Knop
2018-11-06 22:10 ` [PATCH edk2-staging 00/19] IntelUndiPkg/GigUndiDxe: build fixes for AARCH64/ARM/GCC Kinney, Michael D
2018-11-06 23:03 ` Ard Biesheuvel
2018-11-09 17:54 ` Knop, Ryszard
2018-11-09 18:00 ` Ard Biesheuvel
2018-11-07 14:56 ` Leif Lindholm
2019-01-29 13:13 ` Ryszard Knop
2019-01-29 13:55 ` Ryszard Knop
2019-03-27 15:32 ` Ard Biesheuvel
2019-03-28 10:46 ` Ryszard Knop [this message]
2019-03-28 11:38 ` Ard Biesheuvel
2020-01-07 12:49 ` [edk2-devel] " Maciej Rabeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48d303c0db5d5007203a1557d7e5728d19550201.camel@linux.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox