Re: [edk2-devel] [PATCH v2 17/30] OvmfPkg/LoongArchVirt: Add PciCpuIo2Dxe module

["Chao Li" <lichao@loongson.cn>]

[-- Attachment #1: Type: text/plain, Size: 2032 bytes --]

Hi Sunil,

Ok, I will give it try, I'm leaning towards moving this driver to 
UefiCpuPkg and merging it with CpuIo2Dxe with two "inf" files which will 
be named CpuIo2Dxe.inf and MmioCpu2Dxe.inf, do you think this way is better?


Thanks,
Chao
在 2023/11/9 07:11, Sunil V L 写道:
> On Tue, Nov 07, 2023 at 06:03:43PM +0800, Chao Li wrote:
>> Hi Gerd,
>>
>> Yes, you are right, this driver could probably be located somewhere else
>> where other ARCH can easily use it, but I can not find the right place,
>> maybe MdeModulePkg or MdePkg? I also feel that something is not quite right
>> about these two places...
>>
> Hi Chao,
>
> It was in my TODO list and somehow never got time, is to migrate some of
> these drivers and libraries to common place and use them instead of
> copy.
>
> For ex: Move ArmPciCpuIo2Dxe to UefiCpuPkg/CpuIo2Dxe. Either merge with
> CpuIo2Dxe or add something like MmioCpuIo2Dxe. I think you can take this
> approach.
>
> The recommendation I got from Mike earlier was:
> MdePkg for libraries, UefiCpuPkg for drivers and OvmfPkg for purely
> Qemu specific. Adding new things in MdeModulePkg was not recommended.
>
> Thanks,
> Sunil
>
>> Thanks,
>> Chao
>> 在 2023/11/7 17:42, Gerd Hoffmann 写道:
>>> On Mon, Nov 06, 2023 at 11:29:20AM +0800, Chao Li wrote:
>>>> Add PciCpuIo2Dxe for LoongArch, this module is similar to
>>>> ArmPciCpuIo2Dxe drvier.
>>> What are the differences to ArmPciCpuIo2Dxe?
>>> On a quick glance I can't see anything arch-specific here.
>>>
>>> Maybe we should find a better place for ArmPciCpuIo2Dxe so loongarch
>>> can use it without copying the code?
>>>
>>> take care,
>>>     Gerd
>>>
>>>
>>>
>>>
>>>
>>
>> 
>>
>>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111008): https://edk2.groups.io/g/devel/message/111008
Mute This Topic: https://groups.io/mt/102413880/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 3560 bytes --]