From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A0EB681D39 for ; Sat, 12 Nov 2016 14:17:32 -0800 (PST) Received: by mail-wm0-x230.google.com with SMTP id a197so37480022wmd.0 for ; Sat, 12 Nov 2016 14:17:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=RQeVdBHL0p0jlLs+HQi6UVgK86tvFC8/pzZf3Xq64gg=; b=X+3Q1uDD0Qltbtu1fbqLDM2xToG+M8chO37wSBiaL5PlLR8kXxmXUR3D86IM4CkPdh hAwOA4NOR5bqUGO721Ohsp4ij3//oV0OQGw5lOoyvWl+xR4OqUHKFw8uh7j1uvsdmdWP uHKf+D3kgKHoLacnvUlqrmgvR6dMMEWJ6NSrQ3lzIzHYqU/ZAwb9P6Hh7wIOk42y0F5L 4yKJoVL1L4ZAwVzex+41MEAlozpJJuEuhWmYC1VavbVjilwUvvQWBWz8It3gzu6VMBZx MiUzW2hj6NGSEEXXlqoBOWw1g+1qW4YS2MY5tupLoeRZThCZee+PEXtjUGnrg3oDvsqd LdIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=RQeVdBHL0p0jlLs+HQi6UVgK86tvFC8/pzZf3Xq64gg=; b=GP0veLnKtc68ce4sd9zPIZiEe1wKG0LLkY1bEOzhO+im4XKXVGEufKTu0Qu2tXUhfW J3cFvg8d9I8lqFbD58ZJCbPs3ICdOqY1eJj9g5MSkp9GNm0g+98o1miyJfQS5JW/wTOS MFGKKdq5bKAyMyHIU+WWV6QgWgcZgBYopGg+/+++J+upp9ND3/01/aVteNo0+4uIZp45 98p/1RR5BiXed5wLIDx3bcfuS2SpIoP2tecFQpVP1ZOuk4/bzgfWdiNoz6MAixUaAX2t ej2sADUvIE5UEoQZRi+oYEa5tKMflhAqwRci5QDUhh6I1PZn6SyTQBaOZ5esANO01gZl wfsA== X-Gm-Message-State: ABUngvf5EdKhJKlp07sINxBC2XiOiVNw8BF81D6y7uGiLI+oLQTS+N5+1bLh1vxcRe8VUQ== X-Received: by 10.194.54.99 with SMTP id i3mr14262035wjp.86.1478989055159; Sat, 12 Nov 2016 14:17:35 -0800 (PST) Received: from [10.0.0.101] ([84.203.54.175]) by smtp.googlemail.com with ESMTPSA id g17sm19191701wjs.38.2016.11.12.14.17.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Nov 2016 14:17:33 -0800 (PST) To: "Yao, Jiewen" , "edk2-devel@lists.01.org" References: <22709fc2-7dec-f9eb-43f7-d06405349b7e@akeo.ie> <74D8A39837DF1E4DA445A8C0B3885C50386CF903@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386CF9E0@shsmsx102.ccr.corp.intel.com> <283cb151-bde0-6866-2646-244a6dace583@akeo.ie> <74D8A39837DF1E4DA445A8C0B3885C50386CFA48@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386CFA9F@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386CFB5B@shsmsx102.ccr.corp.intel.com> Cc: "Kinney, Michael D" From: Pete Batard Message-ID: <48e539f6-6173-a77a-1570-5d0ec4b237e1@akeo.ie> Date: Sat, 12 Nov 2016 22:17:32 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386CFB5B@shsmsx102.ccr.corp.intel.com> Subject: Re: [PATCH 0/2] MdeModulePkg/EbcDxe: add EBC Debugger X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Nov 2016 22:17:33 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Hi Jiewen, On 2016.11.12 21:44, Yao, Jiewen wrote: > I realize that the side-effect of library solution is that: we need > update DSC file to add Library instance. Yes. I started looking at the library option, and I'm kind of wondering if we really want to put code in a library when it's unlikely that any of the hooks will be used anywhere but once, and in the very specific locations we have now. I still don't mind going that route if that's what we decide, but creating a non-generic library, that is only going to be used to build a single application seems a bit like an overkill. > Now I am thinking the third options: > 3.1.3) 2 INF without MACRO. > 3.1.3.A) Remove EFI_EBC_DEBUGGER_CODE > 3.1.3.B) EBC driver always calls EbcDebuggerHookXXX. > 3.1.3.C) Create a EbcDebuggerHookNull.c and add it to EbcDxe.inf. > So that no change is needed for a platform, and no PCD is introduced. This sound like a more elegant solution. I like this option better than the others so far, so that's what I'll go with for v2. > 3.1.3.F) I still suggest we remove EbcInit.h and EbcExecute.h from > Edb.h. The common definition should be in a better place. Agreed. I'll try to move the common parts to MdePkg\Include\Protocol\Ebc.h in the new proposal, if that's still okay with you. Regards, /Pete