public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: leif@nuviainc.com, Alexei.Fedorov@arm.com,
	Pierre.Gondois@arm.com, Matteo.Carlini@arm.com,
	Ben.Adderson@arm.com, thomas.abraham@arm.com,
	Hemendra.Dassanayake@arm.com, Samer.El-Haj-Mahmoud@arm.com,
	nd@arm.com
Subject: Re: [PATCH edk2-platforms v1 0/7] Updates to support Dynamic AML
Date: Thu, 13 Aug 2020 14:31:31 +0200	[thread overview]
Message-ID: <48e799ce-751a-85c9-9f33-90f47f86a7a7@arm.com> (raw)
In-Reply-To: <20200813090823.69908-1-sami.mujawar@arm.com>

On 8/13/20 11:08 AM, Sami Mujawar wrote:
> Dynamic Tables Framework has been updated to add support for Dynamic AML
> at https://edk2.groups.io/g/devel/topic/patch_v1_00_30_add_dynamic/76149133
> 
> The SPCR and DBG2 generators have been updated to use the Serial Port
> Fixup Library to dynamically generate the corresponding Serial ports
> as Definition Block tables. This makes the static description of the
> SPCR and DBG2 Serial Port definition blocks redundant.
> 
> To dynamically describe the platform serial ports a SSDT Serial Port
> generator has also been introduced.
> 
> In light of the above, the patches in this series:
>   - Remove the redundant static Serial port definition blocks.
>   - Use the SSDT Serial Port generator to describe the FVP
>     platform Serial ports.
>   - Fix an issue with incorrect interrupt assignment on FVP
>     platform.
>   - Remove unnecessary libraries linked with the Configuration
>     Manager.
>   - Increase the Juno FD size to accommodate AmlLib.
> 
> Note: This patch series is dependent on the patch series at
> https://edk2.groups.io/g/devel/message/63246, which must be
> merged before this series can be integrated.
> 
> The changes for this patch series can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/675_dynamic_aml_v1
> 
> Pierre Gondois (1):
>    ArmPlatformPkg: Juno: Increase FD size
> 
> Sami Mujawar (6):
>    Platform/ARM/Juno: Remove SSDT UART table
>    Platform/ARM: FVP: Fix serial port interrupt
>    Platform/ARM: FVP: Add UART base address length
>    Platform/ARM: FVP: Enable SSDT Serial generation
>    Platform/ARM: Juno: Configuration Mgr lib linkage
>    Platform/ARM: FVP: Configuration Mgr lib linkage
> 

For the series

Acked-by: Ard Biesheuvel <ard.biesheuvel@arm.com>

but please drop the Gerrit change IDs from the commit messages before 
pushing.


>   Platform/ARM/JunoPkg/ArmJuno.fdf                                                                  |  8 ++--
>   Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtUart.asl          | 42 -------------------
>   Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c          |  7 ----
>   Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h          |  3 +-
>   Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf     |  4 +-
>   Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc                                              |  4 +-
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl          | 25 ++---------
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c      | 44 ++++++++++++++++++--
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h      |  5 ++-
>   Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf |  2 -
>   10 files changed, 56 insertions(+), 88 deletions(-)
>   delete mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtUart.asl
> 


  parent reply	other threads:[~2020-08-13 12:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13  9:08 [PATCH edk2-platforms v1 0/7] Updates to support Dynamic AML Sami Mujawar
2020-08-13  9:08 ` [PATCH edk2-platforms v1 1/7] Platform/ARM/Juno: Remove SSDT UART table Sami Mujawar
2020-08-13  9:08 ` [PATCH edk2-platforms v1 2/7] ArmPlatformPkg: Juno: Increase FD size Sami Mujawar
2020-08-13  9:08 ` [PATCH edk2-platforms v1 3/7] Platform/ARM: FVP: Fix serial port interrupt Sami Mujawar
2020-08-13  9:08 ` [PATCH edk2-platforms v1 4/7] Platform/ARM: FVP: Add UART base address length Sami Mujawar
2020-08-13  9:08 ` [PATCH edk2-platforms v1 5/7] Platform/ARM: FVP: Enable SSDT Serial generation Sami Mujawar
2020-08-13  9:08 ` [PATCH edk2-platforms v1 6/7] Platform/ARM: Juno: Configuration Mgr lib linkage Sami Mujawar
2020-08-13  9:08 ` [PATCH edk2-platforms v1 7/7] Platform/ARM: FVP: " Sami Mujawar
2020-08-13 12:31 ` Ard Biesheuvel [this message]
2020-08-13 12:39   ` [PATCH edk2-platforms v1 0/7] Updates to support Dynamic AML Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48e799ce-751a-85c9-9f33-90f47f86a7a7@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox