From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.8790.1597321896627869504 for ; Thu, 13 Aug 2020 05:31:36 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E270F1063; Thu, 13 Aug 2020 05:31:35 -0700 (PDT) Received: from [192.168.178.54] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6D2EF3F6CF; Thu, 13 Aug 2020 05:31:33 -0700 (PDT) Subject: Re: [PATCH edk2-platforms v1 0/7] Updates to support Dynamic AML To: Sami Mujawar , devel@edk2.groups.io Cc: leif@nuviainc.com, Alexei.Fedorov@arm.com, Pierre.Gondois@arm.com, Matteo.Carlini@arm.com, Ben.Adderson@arm.com, thomas.abraham@arm.com, Hemendra.Dassanayake@arm.com, Samer.El-Haj-Mahmoud@arm.com, nd@arm.com References: <20200813090823.69908-1-sami.mujawar@arm.com> From: "Ard Biesheuvel" Message-ID: <48e799ce-751a-85c9-9f33-90f47f86a7a7@arm.com> Date: Thu, 13 Aug 2020 14:31:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200813090823.69908-1-sami.mujawar@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/13/20 11:08 AM, Sami Mujawar wrote: > Dynamic Tables Framework has been updated to add support for Dynamic AML > at https://edk2.groups.io/g/devel/topic/patch_v1_00_30_add_dynamic/76149133 > > The SPCR and DBG2 generators have been updated to use the Serial Port > Fixup Library to dynamically generate the corresponding Serial ports > as Definition Block tables. This makes the static description of the > SPCR and DBG2 Serial Port definition blocks redundant. > > To dynamically describe the platform serial ports a SSDT Serial Port > generator has also been introduced. > > In light of the above, the patches in this series: > - Remove the redundant static Serial port definition blocks. > - Use the SSDT Serial Port generator to describe the FVP > platform Serial ports. > - Fix an issue with incorrect interrupt assignment on FVP > platform. > - Remove unnecessary libraries linked with the Configuration > Manager. > - Increase the Juno FD size to accommodate AmlLib. > > Note: This patch series is dependent on the patch series at > https://edk2.groups.io/g/devel/message/63246, which must be > merged before this series can be integrated. > > The changes for this patch series can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/675_dynamic_aml_v1 > > Pierre Gondois (1): > ArmPlatformPkg: Juno: Increase FD size > > Sami Mujawar (6): > Platform/ARM/Juno: Remove SSDT UART table > Platform/ARM: FVP: Fix serial port interrupt > Platform/ARM: FVP: Add UART base address length > Platform/ARM: FVP: Enable SSDT Serial generation > Platform/ARM: Juno: Configuration Mgr lib linkage > Platform/ARM: FVP: Configuration Mgr lib linkage > For the series Acked-by: Ard Biesheuvel but please drop the Gerrit change IDs from the commit messages before pushing. > Platform/ARM/JunoPkg/ArmJuno.fdf | 8 ++-- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtUart.asl | 42 ------------------- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 7 ---- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 3 +- > Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 4 +- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 4 +- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/Dsdt.asl | 25 ++--------- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c | 44 ++++++++++++++++++-- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.h | 5 ++- > Platform/ARM/VExpressPkg/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManagerDxe.inf | 2 - > 10 files changed, 56 insertions(+), 88 deletions(-) > delete mode 100644 Platform/ARM/JunoPkg/ConfigurationManager/ConfigurationManagerDxe/AslTables/SsdtUart.asl >