public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Eric Dong <eric.dong@intel.com>, devel@edk2.groups.io
Cc: Ray Ni <ray.ni@intel.com>
Subject: Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.
Date: Thu, 9 Jan 2020 15:27:28 +0100	[thread overview]
Message-ID: <4909dc1e-5a8f-1b89-1df4-1e92e669f21c@redhat.com> (raw)
In-Reply-To: <20200109052641.767-1-eric.dong@intel.com>

On 01/09/20 06:26, Eric Dong wrote:
> This issue caused by below change:
>   SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6
>   * UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer
>   REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index 35a6996ba3..c285a70ebb 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -1142,6 +1142,8 @@ FindFirstFreeToken (
>  
>    If no free token, allocate new tokens then return the free one.
>  
> +  @param RunningApsCount    The Running Aps count for this token.
> +
>    @retval    return the first free PROCEDURE_TOKEN.
>  
>  **/
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>


  reply	other threads:[~2020-01-09 14:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-09  5:26 [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter Dong, Eric
2020-01-09 14:27 ` Laszlo Ersek [this message]
2020-01-10  1:10 ` [edk2-devel] " Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4909dc1e-5a8f-1b89-1df4-1e92e669f21c@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox