From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.9277.1578580054728153116 for ; Thu, 09 Jan 2020 06:27:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RYRaSWmG; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578580053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4zx0PgkMO0SVkxb4kYB2T2sWs7GH9dLj/OY4lT0IVVY=; b=RYRaSWmG7CLBPK8iAqUbQVEb1PMoHk85ZJtC0FHnB/8mnwiH+S1rvgKoA8q0CSdPWERlGM 48qinM1tDYyY6dAIt2k7PSjFKQNcnUzTnplpnKP39VeIpcb0wJspAHrqOBbQv/leKOL1Ds XK0IXDpJzR64pLpR2102W9gswnvtNeo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-pto2ABLGPlivD8mpXAqBSQ-1; Thu, 09 Jan 2020 09:27:32 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C6C17100550E; Thu, 9 Jan 2020 14:27:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.145]) by smtp.corp.redhat.com (Postfix) with ESMTP id C08E05D9C9; Thu, 9 Jan 2020 14:27:29 +0000 (UTC) Subject: Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter. To: Eric Dong , devel@edk2.groups.io Cc: Ray Ni References: <20200109052641.767-1-eric.dong@intel.com> From: "Laszlo Ersek" Message-ID: <4909dc1e-5a8f-1b89-1df4-1e92e669f21c@redhat.com> Date: Thu, 9 Jan 2020 15:27:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200109052641.767-1-eric.dong@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: pto2ABLGPlivD8mpXAqBSQ-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 01/09/20 06:26, Eric Dong wrote: > This issue caused by below change: > SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6 > * UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388 > > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Eric Dong > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index 35a6996ba3..c285a70ebb 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -1142,6 +1142,8 @@ FindFirstFreeToken ( > > If no free token, allocate new tokens then return the free one. > > + @param RunningApsCount The Running Aps count for this token. > + > @retval return the first free PROCEDURE_TOKEN. > > **/ > Acked-by: Laszlo Ersek