* [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.
@ 2020-01-09 5:26 Dong, Eric
2020-01-09 14:27 ` Laszlo Ersek
2020-01-10 1:10 ` [edk2-devel] " Ni, Ray
0 siblings, 2 replies; 3+ messages in thread
From: Dong, Eric @ 2020-01-09 5:26 UTC (permalink / raw)
To: devel; +Cc: Ray Ni, Laszlo Ersek
This issue caused by below change:
SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6
* UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Eric Dong <eric.dong@intel.com>
---
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
index 35a6996ba3..c285a70ebb 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
@@ -1142,6 +1142,8 @@ FindFirstFreeToken (
If no free token, allocate new tokens then return the free one.
+ @param RunningApsCount The Running Aps count for this token.
+
@retval return the first free PROCEDURE_TOKEN.
**/
--
2.23.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.
2020-01-09 5:26 [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter Dong, Eric
@ 2020-01-09 14:27 ` Laszlo Ersek
2020-01-10 1:10 ` [edk2-devel] " Ni, Ray
1 sibling, 0 replies; 3+ messages in thread
From: Laszlo Ersek @ 2020-01-09 14:27 UTC (permalink / raw)
To: Eric Dong, devel; +Cc: Ray Ni
On 01/09/20 06:26, Eric Dong wrote:
> This issue caused by below change:
> SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6
> * UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index 35a6996ba3..c285a70ebb 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -1142,6 +1142,8 @@ FindFirstFreeToken (
>
> If no free token, allocate new tokens then return the free one.
>
> + @param RunningApsCount The Running Aps count for this token.
> +
> @retval return the first free PROCEDURE_TOKEN.
>
> **/
>
Acked-by: Laszlo Ersek <lersek@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.
2020-01-09 5:26 [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter Dong, Eric
2020-01-09 14:27 ` Laszlo Ersek
@ 2020-01-10 1:10 ` Ni, Ray
1 sibling, 0 replies; 3+ messages in thread
From: Ni, Ray @ 2020-01-10 1:10 UTC (permalink / raw)
To: devel@edk2.groups.io, Dong, Eric; +Cc: Laszlo Ersek
Reviewed-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dong, Eric
> Sent: Thursday, January 9, 2020 1:27 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>
> Subject: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.
>
> This issue caused by below change:
> SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6
> * UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Eric Dong <eric.dong@intel.com>
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index 35a6996ba3..c285a70ebb 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -1142,6 +1142,8 @@ FindFirstFreeToken (
>
>
> If no free token, allocate new tokens then return the free one.
>
>
>
> + @param RunningApsCount The Running Aps count for this token.
>
> +
>
> @retval return the first free PROCEDURE_TOKEN.
>
>
>
> **/
>
> --
> 2.23.0.windows.1
>
>
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
>
> View/Reply Online (#53046): https://edk2.groups.io/g/devel/message/53046
> Mute This Topic: https://groups.io/mt/69569495/1712937
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
> -=-=-=-=-=-=
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-10 1:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-09 5:26 [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter Dong, Eric
2020-01-09 14:27 ` Laszlo Ersek
2020-01-10 1:10 ` [edk2-devel] " Ni, Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox