Re: [PATCH v1 0/6] DynamicTablesPkg: Framework updates and fixes

[Laszlo Ersek <lersek@redhat.com>]

On 02/21/19 19:14, Sami Mujawar wrote:
> This patch series updates the Dynamic Tables Framework to
> incorporate the following changes:
>   * Fix DEPEX to load modules in correct order.
>   * Add options for OEMs to provide OEM Table ID and revision.
>   * Update DBG2_DEBUG_PORT_DDI macro to remove unused parameter.
>   * Remove GIC Distributor ID field.
>   * Minor updates to comments and typo fixes.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> 
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/473_dynamic_tables_framework_v1
> 
> The corresponding edk2-platform code changes can be seen at:
> https://github.com/samimujawar/edk2-platforms/tree/473_dynamic_tables_framework_v1
> 
> Sami Mujawar (6):
>   DynamicTablesPkg: Fix depex and protocol section
>   DynamicTablesPkg: Rename enum used for ID Mapping
>   DynamicTablesPkg: Add OEM Info
>   DynamicTablesPkg: DGB2: Update DBG2_DEBUG_PORT_DDI
>   DynamicTablesPkg: Remove GIC Distributor Id field
>   DynamicTablesPkg: Minor updates and fix typos
> 
>  DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf |  7 +-
>  DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 11 +--
>  DynamicTablesPkg/Include/ArmNameSpaceObjects.h                             | 73 +++++++++++++++-----
>  DynamicTablesPkg/Include/Library/TableHelperLib.h                          |  4 +-
>  DynamicTablesPkg/Include/StandardNameSpaceObjects.h                        | 18 +++++
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c           |  7 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c           |  2 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c           |  2 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c           |  8 +--
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c           |  6 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c           |  2 +-
>  DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c           |  2 +-
>  DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c               | 26 +++++--
>  13 files changed, 119 insertions(+), 49 deletions(-)
> 

This patch series (0692ef87594f..07f4e26eb6fe) should be reverted, in my
opinion. In particular, patch #3 ("DynamicTablesPkg: Add OEM Info")
looks very much like a feature addition. We entered the soft feature
freeze on 2019-Feb-22.

https://lists.01.org/pipermail/edk2-devel/2019-February/037169.html

The patch was posted on 2019-Feb-21 alright, but Alexei's review
appeared on 2019-Feb-25 only (today).

The definition at
<https://github.com/lersek/edk2/wiki/SoftFeatureFreeze> says that the
necessary reviews too must not cross over into the soft feature freeze.

Please revert this set, and reapply it after the next stable tag is applied.

Thanks
Laszlo