From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1096C211CF370 for ; Mon, 25 Feb 2019 11:27:38 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B1CE5C04FFF7; Mon, 25 Feb 2019 19:27:37 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-217.rdu2.redhat.com [10.10.120.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id D28A0100190E; Mon, 25 Feb 2019 19:27:33 +0000 (UTC) To: Sami Mujawar , edk2-devel@lists.01.org Cc: alexei.fedorov@arm.com, nd@arm.com, Stephanie.Hughes-Fitt@arm.com References: <20190221181414.83136-1-sami.mujawar@arm.com> From: Laszlo Ersek Message-ID: <491a2965-a252-77a3-30d5-543cfc1577ee@redhat.com> Date: Mon, 25 Feb 2019 20:27:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190221181414.83136-1-sami.mujawar@arm.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 25 Feb 2019 19:27:37 +0000 (UTC) Subject: Re: [PATCH v1 0/6] DynamicTablesPkg: Framework updates and fixes X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 19:27:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/21/19 19:14, Sami Mujawar wrote: > This patch series updates the Dynamic Tables Framework to > incorporate the following changes: > * Fix DEPEX to load modules in correct order. > * Add options for OEMs to provide OEM Table ID and revision. > * Update DBG2_DEBUG_PORT_DDI macro to remove unused parameter. > * Remove GIC Distributor ID field. > * Minor updates to comments and typo fixes. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > > The changes can be seen at: > https://github.com/samimujawar/edk2/tree/473_dynamic_tables_framework_v1 > > The corresponding edk2-platform code changes can be seen at: > https://github.com/samimujawar/edk2-platforms/tree/473_dynamic_tables_framework_v1 > > Sami Mujawar (6): > DynamicTablesPkg: Fix depex and protocol section > DynamicTablesPkg: Rename enum used for ID Mapping > DynamicTablesPkg: Add OEM Info > DynamicTablesPkg: DGB2: Update DBG2_DEBUG_PORT_DDI > DynamicTablesPkg: Remove GIC Distributor Id field > DynamicTablesPkg: Minor updates and fix typos > > DynamicTablesPkg/Drivers/DynamicTableFactoryDxe/DynamicTableFactoryDxe.inf | 7 +- > DynamicTablesPkg/Drivers/DynamicTableManagerDxe/DynamicTableManagerDxe.inf | 11 +-- > DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 73 +++++++++++++++----- > DynamicTablesPkg/Include/Library/TableHelperLib.h | 4 +- > DynamicTablesPkg/Include/StandardNameSpaceObjects.h | 18 +++++ > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 7 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 2 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c | 2 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiIortLibArm/IortGenerator.c | 8 +-- > DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 6 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiMcfgLibArm/McfgGenerator.c | 2 +- > DynamicTablesPkg/Library/Acpi/Arm/AcpiSpcrLibArm/SpcrGenerator.c | 2 +- > DynamicTablesPkg/Library/Common/TableHelperLib/TableHelper.c | 26 +++++-- > 13 files changed, 119 insertions(+), 49 deletions(-) > This patch series (0692ef87594f..07f4e26eb6fe) should be reverted, in my opinion. In particular, patch #3 ("DynamicTablesPkg: Add OEM Info") looks very much like a feature addition. We entered the soft feature freeze on 2019-Feb-22. https://lists.01.org/pipermail/edk2-devel/2019-February/037169.html The patch was posted on 2019-Feb-21 alright, but Alexei's review appeared on 2019-Feb-25 only (today). The definition at says that the necessary reviews too must not cross over into the soft feature freeze. Please revert this set, and reapply it after the next stable tag is applied. Thanks Laszlo