From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 34143AC174A for ; Wed, 13 Mar 2024 17:40:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ujJioba2x+uWPfLlnohDEjAw1Wh7R3GvB6IXAGjbjCY=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710351626; v=1; b=PDl0XVtPIyQZRcBDWEXQw2FrLCT76RFW3Ph03B21ihkwF3AlFC22yTft1OUgrK7oBqMBBBgO U2AClUhQv61pKVW1ANllT83h8vnp4Izepusz0FhGH+5mmIpChyI5gPHAUqpf33C6rdbToIKdQT2 V0Fpg1fPS2kb3W62MqtXKNt2JA+puwl8U//nrGK8UhFmqqziXOQuaJohfeCwuj3+Nf5amwelMvJ XQ5Kb/4w4OzYF/n3kiuWNT3EBEewOzQSTeR1DwoIprW+veLyptG4wHmzwHumguf2uFWPqUp1jq3 UzTyZ8oBkP32MER2CBi7DxU7O+gg4BR1eu0tgUyZSzNHQ== X-Received: by 127.0.0.2 with SMTP id AYGrYY7687511xUJtwaaWAWo; Wed, 13 Mar 2024 10:40:26 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.2237.1710351626286854756 for ; Wed, 13 Mar 2024 10:40:26 -0700 X-Received: from [10.137.194.171] (unknown [131.107.159.43]) by linux.microsoft.com (Postfix) with ESMTPSA id AB69720B74C0; Wed, 13 Mar 2024 10:40:25 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AB69720B74C0 Message-ID: <494b06c9-51e8-42d1-8676-279a29b550fb@linux.microsoft.com> Date: Wed, 13 Mar 2024 10:40:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel][PATCH v3 0/3] Fix Runtime Granularity Issues From: "Oliver Smith-Denny" To: devel@edk2.groups.io, Ray Ni , Michael Kinney Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Liming Gao Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com References: <17BB2E17D650A0B1.17779@groups.io> In-Reply-To: <17BB2E17D650A0B1.17779@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 13 Mar 2024 10:40:26 -0700 List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fTG1VfljLvtmsO7WPjg4zJEGx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=PDl0XVtP; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Ray and Mike, Can you help get this patchset reviewed and merged? It contains a fix for a UEFI spec violation and it has been sitting on the mailing list for a month. Unfortunately Liming has not reviewed after weekly friendly pings and he is the only main level MdeModulePkg maintainer. Liming, perhaps you could use a co-maintainer from the community to help balance the load? I totally understand that being a maintainer is a large burden, but I also have several patchsets up that need reviews and merging for over a month. Thanks, Oliver On 3/9/2024 11:06 AM, Oliver Smith-Denny wrote: > This patch series is the third version of > MdeModulePkg: DxeCore: Don't Guard Large Runtime Granularity Allocations= =E2=80=8B. > The subject line has been updated because this went from a one commit > patch with no cover letter to a multi-commit patch. >=20 > The commit messages cover the vast amount of detail here, but this > patchset fixes three issues: > - a UEFI spec violation for which memory types require runtime page > allocation granularity alignment > - An incompatibility of the heap guard system to guard these regions > that require runtime page allocation granularities greater than > the EFI_PAGE_SIZE. > - A CodeQL error that fails CI when updating the Page.c code >=20 > v3: > - edit comments for readability >=20 > v2: > - Add commit to fix UEFI spec violation > - Add commit to fix newly flagged CodeQL error > - Update guard commit message, comments, and static assert to use > the correct types >=20 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Liming Gao >=20 > Oliver Smith-Denny (3): > MdeModulePkg: DxeCore: Fix CodeQL Error in FreePages > MdeModulePkg: DxeCore: Correct Runtime Granularity Memory Type > MdeModulePkg: DxeCore: Do Not Apply Guards to Unsupported Types >=20 > MdeModulePkg/MdeModulePkg.dec | 10 +++++++++ > MdeModulePkg/Core/Dxe/Mem/HeapGuard.h | 14 +++++++++++++ > MdeModulePkg/Core/Dxe/Mem/Page.c | 22 +++++++++++++++++--- > MdeModulePkg/Core/Dxe/Mem/Pool.c | 15 +++++++++++-- > MdeModulePkg/Core/Dxe/Misc/MemoryProtection.c | 4 ++-- > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 2 +- > 6 files changed, 59 insertions(+), 8 deletions(-) >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116719): https://edk2.groups.io/g/devel/message/116719 Mute This Topic: https://groups.io/mt/104832605/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-