Re: [PATCH 3/8] UefiCpuPkg: Use CcExitLib instead of VmgExitLib

["Lendacky, Thomas" <thomas.lendacky@amd.com>]

On 11/2/22 08:17, Tom Lendacky wrote:
> On 11/2/22 00:10, Min Xu wrote:
>> From: Min M Xu <min.m.xu@intel.com>
>>
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4123
>>
>> VmgExitLib once was designed to provide interfaces to support #VC handler
>> and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) is
>> introduced, this library is updated to support #VE as well. Now the name
>> of VmgExitLib cannot reflect what the lib does. So VmgExitLib is replaced
>> by CcExitLib.
>>
>> Cc: Eric Dong <eric.dong@intel.com>
>> Cc: Ray Ni <ray.ni@intel.com>
>> Cc: Brijesh Singh <brijesh.singh@amd.com>
>> Cc: Erdem Aktas <erdemaktas@google.com>
>> Cc: Gerd Hoffmann <kraxel@redhat.com>
>> Cc: James Bottomley <jejb@linux.ibm.com>
>> Cc: Jiewen Yao <jiewen.yao@intel.com>
>> Cc: Tom Lendacky <thomas.lendacky@amd.com>
>> Signed-off-by: Min Xu <min.m.xu@intel.com>
>> ---
>>   .../DxeCpuExceptionHandlerLib.inf                      |  2 +-
>>   .../PeiCpuExceptionHandlerLib.inf                      |  2 +-
>>   .../CpuExceptionHandlerLib/PeiDxeSmmCpuException.c     |  6 +++---
>>   .../CpuExceptionHandlerLib/SecPeiCpuException.c        |  6 +++---
>>   .../SecPeiCpuExceptionHandlerLib.inf                   |  2 +-
>>   .../SmmCpuExceptionHandlerLib.inf                      |  2 +-
>>   .../Xcode5SecPeiCpuExceptionHandlerLib.inf             |  2 +-
>>   UefiCpuPkg/Library/MpInitLib/AmdSev.c                  | 10 +++++-----
>>   UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf          |  2 +-
>>   UefiCpuPkg/Library/MpInitLib/DxeMpLib.c                |  8 ++++----
>>   UefiCpuPkg/Library/MpInitLib/MpLib.c                   |  2 +-
>>   UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf          |  2 +-
>>   UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c              | 10 +++++-----
>>   UefiCpuPkg/UefiCpuPkg.dsc                              |  2 ++
>>   14 files changed, 30 insertions(+), 28 deletions(-)
>>
> 
>> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc
>> index 0e1a99ddc09f..57c74ba844d2 100644
>> --- a/UefiCpuPkg/UefiCpuPkg.dsc
>> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
>> @@ -60,6 +60,7 @@
>>     
>> PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf
>>     
>> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>>     VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf
> 
> Should you be deleting the VmgExitLibNull reference now? Or is this to 
> handle issues with the edk2-platforms tree? If so, when will this be 
> removed and VmgExitLibNull deleted?

Ah, never mind... for some reason patch #7 didn't make it to my Inbox so I 
missed that.

Thanks,
Tom

> 
> Thanks,
> Tom
> 
>> +  CcExitLib|UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf
>>     MicrocodeLib|UefiCpuPkg/Library/MicrocodeLib/MicrocodeLib.inf
>>     
>> SmmCpuRendezvousLib|UefiCpuPkg/Library/SmmCpuRendezvousLib/SmmCpuRendezvousLib.inf
>>     CpuPageTableLib|UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableLib.inf
>> @@ -164,6 +165,7 @@
>>     UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLibStm.inf
>>     UefiCpuPkg/Library/SmmCpuFeaturesLib/StandaloneMmCpuFeaturesLib.inf
>>     UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf
>> +  UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf
>>     UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.inf
>>     UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.inf
>>     UefiCpuPkg/SecCore/SecCore.inf