From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.56]) by mx.groups.io with SMTP id smtpd.web11.6071.1667395225352614565 for ; Wed, 02 Nov 2022 06:20:25 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=NZC91NMH; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.56, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kRCJNBhcLZR3gMub9RN0l+mccCgdAcW5Y5Sfr9UrzMpfVSnYJIxtkZpWdEDn/brHmrz3jFP0jAAG8YgEeD3V+GBpVO3yA+w10vzW/ZbqPolLckmzdjIiUNI6d0UN3TZrAA096/41XyL9KYRUrT+IJVkynk7tsHucRK7rCApH+a8XBECkIOnlCwFe22Dxc3oFOE0EjaO6plX/fb7iqjWxmlfYkkWM5lIxhJ8LuR6NjQsRAKAw8L3dVSxRVzMKc6uTehltpwmZAlsH/MK3qctOE+Yvvi5jJzOfI7Y2BS07eETitQNqTRvD45qsucRarO5MQxa7woTaGSS2noXmyZSWtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CyeKCyBDmBZnwuIy+wiqjpEDRcuQdDTdDlECIUz3+A4=; b=NnISj2FmxliLuUIKB8CFFnHGpofssYWQHXgHAIkwLUXIuptWXDlKGm559q1kY17OJbv7s63lucTFDLcHVOfE9nE1XqlImyAg9F5tyA6ngkYY/vLrjoknJDSrSRWhF7t5ltEaRCckSqDDg0FuytcNBzyF9bneL+QjQQjFma1b/rZubp4vRbACUks7YeBxQTXSUAiV9LZ2rWkl2NCJdxdYrivhrsielGTSRS/PLUhFiGUuKJBEmgrbAZWYa9xPK/fmeh7xDGkF/DyHnaQdk7lLypCKXqa74Q7Fh9ANPsjZ6Q5Kre8Dtt1CxFoGYOKcLkksodTo879atAsRDd4Yz92NmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CyeKCyBDmBZnwuIy+wiqjpEDRcuQdDTdDlECIUz3+A4=; b=NZC91NMHqzR23itagk+/YMdKWUtVVFS7yUEWcsaM9Ca/sFwLXSmkzUxdepqPJdfFw/mzUr6nGKbRO8p06GrBLzSVTu4zfQvarBjjNboVpCnxNXfauT9AL70FVrCyNZ1r6ohVK6It89En3A69j3kSXfL9/0bf6i0rHtJN+wGnf1g= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by DS7PR12MB5718.namprd12.prod.outlook.com (2603:10b6:8:71::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 2 Nov 2022 13:20:23 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::4da8:e3eb:20eb:f00]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::4da8:e3eb:20eb:f00%2]) with mapi id 15.20.5769.021; Wed, 2 Nov 2022 13:20:23 +0000 Message-ID: <494ba959-7c27-ca56-a4a4-8117669a3575@amd.com> Date: Wed, 2 Nov 2022 08:20:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 3/8] UefiCpuPkg: Use CcExitLib instead of VmgExitLib From: "Lendacky, Thomas" To: Min Xu , devel@edk2.groups.io CC: Eric Dong , Ray Ni , Brijesh Singh , Erdem Aktas , Gerd Hoffmann , James Bottomley , Jiewen Yao References: <20221102051050.852-1-min.m.xu@intel.com> <20221102051050.852-4-min.m.xu@intel.com> <89c29922-7741-0191-bb9f-a9a1ba934531@amd.com> In-Reply-To: <89c29922-7741-0191-bb9f-a9a1ba934531@amd.com> X-ClientProxiedBy: CH0PR03CA0314.namprd03.prod.outlook.com (2603:10b6:610:118::29) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|DS7PR12MB5718:EE_ X-MS-Office365-Filtering-Correlation-Id: 90a9df49-0ce1-441b-31e2-08dabcd4ffc1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 84plZb68drDxVd/H6Vyw8GBLzClDJ7jccaYmMHaexwAJ93XvMmQp+fEsTCMYbzSWejQQyb3VEgia1F7ckUXs6pwX6N2Re85rnFFyPeOHJ7NBlqvuy9yf2Mfk/KmiXSQFup7TTNLEWoIh+Co9zvEqfgm1QFxSGVJh11B+3/6xMWEaNfqyCU2SBUbQGxj54Akv/wViwQA60aIDhRQGdk2ypdusbqUt/HrPvhtIWmH8B6tewxSK/EExswm7pYU7+bl+hG8IQph3VAzeGWwgIB9sHqtLWJvQFGOaYVCLeLZnxXQGIuAU86cevLAN3wB3I8Y7n9OzyEykIM9PEpmmeozFsye/EzDMCQngKeMixNZH+dzSLiusGIJIUxq8oGWp4BeRO7kcpvPK1PFSOaNJmbjlL02k0ZMItPI2ALfylYYlEYWPTsgu9RT8cRfYdw8E0/zudZmXZXuMk5kLuA9zdRWW9lfGh2Zi4P8yLtO7YwHi8+sCFNkZJkjiNlBXE6vyKoKUqARW32DFYc4vSgY/3DeSQytXxzE2X9WZ4XAHxM0p5jZdHYXPxTGh6rNoO2G5UM5/QupYMjynxTt2oshHyrVCjZWCXyFWVYr3P2bKyAyiKREKiOuV3pERG1mRqPVRcW1+uzViFFtVA4aPPRakj6BXQOk7qGesDgKOpdqw3lbCtw+BBLOMZsR0LaKQPhp23XX9Lpi+p0YDGA0Y/xY7gwAoArTRGEbEk2CXyghx44Pu2y7SmvX3z117mOvpKDbtdISf+nIDEDNkq0SDQC6UNExGae4cxMB/AtPYTfu4BNHTQFrbp5kqvrwXgaw3EUKxlWJ3zOWT8PUAE2BlC9ICWzmmaw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(6029001)(4636009)(346002)(39860400002)(366004)(396003)(136003)(376002)(451199015)(31686004)(36756003)(19627235002)(41300700001)(6486002)(966005)(8936002)(83380400001)(8676002)(4326008)(66476007)(478600001)(66556008)(66946007)(2906002)(5660300002)(54906003)(316002)(6512007)(186003)(26005)(2616005)(38100700002)(31696002)(86362001)(6506007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xdyYC/oYmIM2PHiVO5J9yUeQwJqC6UYlO2R11LVQLJRiL4eE1Y0ombFc8ZmC?= =?us-ascii?Q?EwlBYzOuajO7BmE8geJH+2WynM1SUAJWbPtqJR5PpP/NlwbzJD9EUQY9h4tn?= =?us-ascii?Q?/PA737vKxv7hppDEzfayKQFRW9M2sRiGfMZRYBmuz25FpNGN2zmFBs+KMjrd?= =?us-ascii?Q?BtsrdwuAqYGThCfqMlU6pSJI+tXStYRy7c2+Bd7cRcZ2An88HIewyljhOLK0?= =?us-ascii?Q?BpWzelaPIDs1AxXCfJ9pUOSkTxPsPKnXmw8A1zLMZUL5uJNF6LILVnT0AJNv?= =?us-ascii?Q?ltqnqaWws6Ueo/YjbFDm/Ifwhz3TZCxb3qKiDRwUfwPIud7PrPfBM07Z81WW?= =?us-ascii?Q?sabtkQlq5x4CisKkB6S63L48b7cZ+eUPA7A+tGjjMqQek7/ecZBo36Gen9iV?= =?us-ascii?Q?3YRd73fwWFVw6SDlWjJX57H5Bp5MWlnU1OFxSyWb6f4wLx+d329NFb38cDWh?= =?us-ascii?Q?2eGTVXY66GW7+MQ1ygI/VAQEj+8D6MjhuFD50QpGZ9Mw21Xlq+x+Nf2t86iV?= =?us-ascii?Q?munRuI3LEX/E5ENCaSD8czQcbkSdSgYizOGpXqEfH58A3gpaWSxkJjhwys46?= =?us-ascii?Q?U13c2YW4UM73A6jgOnwZPGMZaf8evWkzNRCxkyDlmiYRScHQV62E5F/qxvSz?= =?us-ascii?Q?DQN5b6qn+NKIwZmtWk3LrQRdYuTHTIhzLC4gfAjXNow5dktxxHmQfDONuaLa?= =?us-ascii?Q?pBosGjzhUKVd0m0ISInFHcEtoQ1KvhBLmslhQxZh9Jjl4yie9EtuFuNBKGIw?= =?us-ascii?Q?qNvfWH6AIkLETCAqv6iduLeQPRDnFPlgdlOx87gTHi1W9g0vtUfoXJjBuyqJ?= =?us-ascii?Q?kbyppOije45xeYQWHjH1k0bnXidOlFfIfPhASojAXDt+y83u11V0WdlBA/TQ?= =?us-ascii?Q?Aja1RRSCtfXDzaDp7nhKPHZwSWdboqy5+T1sL47zuDdilX/eDpgmXhe8mpJL?= =?us-ascii?Q?O6fxnNwHEGt04ZIMfDLoRcJIwrKyK9mu8u64MdH5D2g4vrYAvP/+3n58Qa5f?= =?us-ascii?Q?gcDoxfpYEZFlHSlDRwW4YSh9zXDIG0mMUtq+8BdDE4X+baBXttPzj6n/CoIL?= =?us-ascii?Q?XqvfpmI/3SRHJg2o2VoFcMTguAkrvPyehtxMomY5hC6gS2C2tMmojQcOMIrj?= =?us-ascii?Q?KjP5kIMAr2V8DEiGzpszB3vUQJ05DVnLLMKX6L7XSVAyXf2uFcXOFB4FmAsJ?= =?us-ascii?Q?F3+FXto8Ao5TsbAakRQ2ALWiO7bTx2/qaBdtieWX4UXqndI3IW+sfaG58K+V?= =?us-ascii?Q?nHTZhwAk1/8PWer4zeHdZ+kfKnVgGSRcokDKwuMi21zD0xPveHz0B5IZwmW4?= =?us-ascii?Q?nx9TRcIdYIWvKWO4fgU2HjcdhfOY9KCa/kCCD6tNEQ18hjTZLsAiIrPDh0kN?= =?us-ascii?Q?zSYmoA7crk9KMbrUr5UQrjWMz1/de49GmbS/1uJpQmKa2riZkQxxiaKBNYsB?= =?us-ascii?Q?LZEYVIRm2kAACP6WinLq1832vWJCKVALm9Nizbv8oxQF7jcDQ06y+622EZxg?= =?us-ascii?Q?8fKAobAGe5vXUF58BKtWbElKMChGeyoDUkGxJQt9bZFs2AkGu/on/QS/t+xm?= =?us-ascii?Q?TJdxTJgMOZEsSvxvLBWiUBmdyjSMu8sJ61n+z3kW?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90a9df49-0ce1-441b-31e2-08dabcd4ffc1 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2022 13:20:23.7379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 89Fb4j2LP8W8kYUSTwr8ShVAWhjfAUwneZ7u+kEY/d4XDyfvBrzZbz6i+4asd2UfwB2M+MgnQ3e6/0HIOhZQAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5718 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 11/2/22 08:17, Tom Lendacky wrote: > On 11/2/22 00:10, Min Xu wrote: >> From: Min M Xu >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4123 >> >> VmgExitLib once was designed to provide interfaces to support #VC handle= r >> and issue VMGEXIT instruction. After TDVF (enable TDX feature in OVMF) i= s >> introduced, this library is updated to support #VE as well. Now the name >> of VmgExitLib cannot reflect what the lib does. So VmgExitLib is replace= d >> by CcExitLib. >> >> Cc: Eric Dong >> Cc: Ray Ni >> Cc: Brijesh Singh >> Cc: Erdem Aktas >> Cc: Gerd Hoffmann >> Cc: James Bottomley >> Cc: Jiewen Yao >> Cc: Tom Lendacky >> Signed-off-by: Min Xu >> --- >> =C2=A0 .../DxeCpuExceptionHandlerLib.inf=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- >> =C2=A0 .../PeiCpuExceptionHandlerLib.inf=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- >> =C2=A0 .../CpuExceptionHandlerLib/PeiDxeSmmCpuException.c=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0 6 +++--- >> =C2=A0 .../CpuExceptionHandlerLib/SecPeiCpuException.c=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 6 +++--- >> =C2=A0 .../SecPeiCpuExceptionHandlerLib.inf=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0 2 +- >> =C2=A0 .../SmmCpuExceptionHandlerLib.inf=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- >> =C2=A0 .../Xcode5SecPeiCpuExceptionHandlerLib.inf=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- >> =C2=A0 UefiCpuPkg/Library/MpInitLib/AmdSev.c=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= | 10 +++++----- >> =C2=A0 UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- >> =C2=A0 UefiCpuPkg/Library/MpInitLib/DxeMpLib.c=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 = 8 ++++---- >> =C2=A0 UefiCpuPkg/Library/MpInitLib/MpLib.c=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 |=C2=A0 2 +- >> =C2=A0 UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 +- >> =C2=A0 UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 10 +++++----- >> =C2=A0 UefiCpuPkg/UefiCpuPkg.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 2 ++ >> =C2=A0 14 files changed, 30 insertions(+), 28 deletions(-) >> >=20 >> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc >> index 0e1a99ddc09f..57c74ba844d2 100644 >> --- a/UefiCpuPkg/UefiCpuPkg.dsc >> +++ b/UefiCpuPkg/UefiCpuPkg.dsc >> @@ -60,6 +60,7 @@ >> =20 >> PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeC= offExtraActionLibNull.inf >> =20 >> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurem= entLibNull.inf >> =C2=A0=C2=A0=C2=A0 VmgExitLib|UefiCpuPkg/Library/VmgExitLibNull/VmgExitL= ibNull.inf >=20 > Should you be deleting the VmgExitLibNull reference now? Or is this to=20 > handle issues with the edk2-platforms tree? If so, when will this be=20 > removed and VmgExitLibNull deleted? Ah, never mind... for some reason patch #7 didn't make it to my Inbox so I= =20 missed that. Thanks, Tom >=20 > Thanks, > Tom >=20 >> +=C2=A0 CcExitLib|UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf >> =C2=A0=C2=A0=C2=A0 MicrocodeLib|UefiCpuPkg/Library/MicrocodeLib/Microcod= eLib.inf >> =20 >> SmmCpuRendezvousLib|UefiCpuPkg/Library/SmmCpuRendezvousLib/SmmCpuRendezv= ousLib.inf >> =C2=A0=C2=A0=C2=A0 CpuPageTableLib|UefiCpuPkg/Library/CpuPageTableLib/Cp= uPageTableLib.inf >> @@ -164,6 +165,7 @@ >> =C2=A0=C2=A0=C2=A0 UefiCpuPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLi= bStm.inf >> =C2=A0=C2=A0=C2=A0 UefiCpuPkg/Library/SmmCpuFeaturesLib/StandaloneMmCpuF= eaturesLib.inf >> =C2=A0=C2=A0=C2=A0 UefiCpuPkg/Library/VmgExitLibNull/VmgExitLibNull.inf >> +=C2=A0 UefiCpuPkg/Library/CcExitLibNull/CcExitLibNull.inf >> =C2=A0=C2=A0=C2=A0 UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.i= nf >> =C2=A0=C2=A0=C2=A0 UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.i= nf >> =C2=A0=C2=A0=C2=A0 UefiCpuPkg/SecCore/SecCore.inf