From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 03864740034 for ; Fri, 9 Feb 2024 09:24:17 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=KNZUgqUT1krbSvrn0wEfT01gvU/cMxp6OOaqbGD58qc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707470656; v=1; b=Z7zvoWblwCDReVI4gUByzUsyf8L9pCrRNbK5JOocT/AXZ7vmX67yegJYQ2U7EkE0L85Lkt3D RpzLWbs7uezq7M9ePIGFWVRMFXLY314DYdsM3FfQ/gRoiaR+rl3Evotm9LiNdi621RaeziHGpLW jLrz2s81hAOpFLoj7g0cDoBg= X-Received: by 127.0.0.2 with SMTP id WagEYY7687511xa4Evs4LETS; Fri, 09 Feb 2024 01:24:16 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.7764.1707470655860567283 for ; Fri, 09 Feb 2024 01:24:16 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-qG7myGj0MU2RTGn6BYpPWg-1; Fri, 09 Feb 2024 04:24:13 -0500 X-MC-Unique: qG7myGj0MU2RTGn6BYpPWg-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3DEF5845E40; Fri, 9 Feb 2024 09:24:13 +0000 (UTC) X-Received: from [10.39.193.114] (unknown [10.39.193.114]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A9864AC7C; Fri, 9 Feb 2024 09:24:12 +0000 (UTC) Message-ID: <49518316-09b3-69ae-8acd-ef4ff4471873@redhat.com> Date: Fri, 9 Feb 2024 10:24:11 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [edk2-platforms PATCH 4/6] SimicsOpenBoardPkg: fix SEC ProcessLibraryConstructorList() prototype To: "Desimone, Nathaniel L" , edk2-devel-groups-io Cc: "Chaganty, Rangasai V" References: <36593e23-d3e8-b71a-808d-ef94260b5fd0@redhat.com> <20240207010919.105860-1-lersek@redhat.com> <20240207010919.105860-5-lersek@redhat.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: noEFJl74bY0sylJnzF66xwcsx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Z7zvoWbl; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2/9/24 01:07, Desimone, Nathaniel L wrote: >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Tuesday, February 6, 2024 5:09 PM >> To: edk2-devel-groups-io >> Cc: Desimone, Nathaniel L ; Chaganty, >> Rangasai V >> Subject: [edk2-platforms PATCH 4/6] SimicsOpenBoardPkg: fix SEC >> ProcessLibraryConstructorList() prototype >> >> The current declaration of, and call to, SEC >> ProcessLibraryConstructorList() in SimicsOpenBoardPkg matches the PEIM >> entry point parameter list. Fix the call, and rely on AutoGen for the de= claration. >> >> Untested (no idea what hoops to jump through to get this built). >=20 > Laszlo - This can be built using the following instructions (tested on Ro= cky Linux 9.3): >=20 > First Time Setup > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > sudo dnf install python3-pip git > sudo dnf install make g++ acpica-tools libuuid-devel > sudo dnf config-manager --enable crb > sudo dnf install nasm > wget https://github.com/tianocore/edk2-edkrepo/releases/download/edkrepo-= v3.1.3/edkrepo-3.1.3.0.tar.gz > tar -zxvf edkrepo-3.1.3.0.tar.gz --one-top-level > cd edkrepo-3.1.3.0 > ./install.py > cd ~/src > --> Or wherever it is you like to store code > edkrepo clone intc Intel-MinPlatform >=20 > Building > =3D=3D=3D=3D=3D=3D=3D=3D > cd intc/edk2-platforms/Platform/Intel/ > ./build_bios.py -p BoardX58Ich10 -t GCC5 >=20 > --> You can see a list of all available Intel platforms by running build_= bios.py without arguments. Thanks! Laszlo >=20 >> >> Cc: Nate DeSimone >> Cc: Sai Chaganty >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D990 >> Signed-off-by: Laszlo Ersek >> --- >> Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c >> b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c >> index 39e879e9223e..09d43c6bf63b 100644 >> --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c >> +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c >> @@ -9,7 +9,6 @@ >> >> #include >> >> -#include >> #include >> #include >> #include >> @@ -738,7 +737,7 @@ SecCoreStartupWithStack ( >> Table[Index] =3D 0; >> } >> >> - ProcessLibraryConstructorList (NULL, NULL); >> + ProcessLibraryConstructorList (); >> >> DEBUG ((EFI_D_INFO, >> "SecCoreStartupWithStack(0x%x, 0x%x)\n", >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115290): https://edk2.groups.io/g/devel/message/115290 Mute This Topic: https://groups.io/mt/104210908/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-