From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mx.groups.io with SMTP id smtpd.web12.5091.1603138678756789927
 for <devel@edk2.groups.io>;
 Mon, 19 Oct 2020 13:17:58 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=JeIUZykS;
 spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1603138678;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=IAryc/eHK19m/J1W8gBfX/IvQC3LRmpyMAtEOp9/qfY=;
	b=JeIUZykS1aGAA5N2yTlJyrWUhddXRDW0GXDV0rCdHScLaNmPEosTtrUYuYDIQwIqRRK8rM
	8VNVicpBD8zBXYSW44lksfIhLb+ZpdgrbnY47t1x/pU82xuNFFya9ON/MKZyNpuJMl9Dyi
	FuCy4m1aS0CwuKTZN3oBkpubPRak6Uc=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-86-HET18WLeNRmMeAp8YxytgQ-1; Mon, 19 Oct 2020 16:17:53 -0400
X-MC-Unique: HET18WLeNRmMeAp8YxytgQ-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ECA95107465A;
	Mon, 19 Oct 2020 20:17:51 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-137.ams2.redhat.com [10.36.113.137])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 31FA110013C1;
	Mon, 19 Oct 2020 20:17:49 +0000 (UTC)
Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW1BBVENIIHYyIDAxLzExXSBNZGVQa2csIE92bWZQa2c6IENsZWFuIHVwIEdIQ0IgZmllbGQgb2Zmc2V0cyBhbmQgc2F2ZSBhcmVh?=
To: Tom Lendacky <thomas.lendacky@amd.com>,
 gaoliming <gaoliming@byosoft.com.cn>, devel@edk2.groups.io
Cc: 'Brijesh Singh' <brijesh.singh@amd.com>,
 'Michael D Kinney' <michael.d.kinney@intel.com>,
 'Zhiguang Liu' <zhiguang.liu@intel.com>,
 'Jordan Justen' <jordan.l.justen@intel.com>,
 'Ard Biesheuvel' <ard.biesheuvel@arm.com>
References: <cover.1602864557.git.thomas.lendacky@amd.com>
 <523f270e4e6f7a62cdbebc541b442bd766e7ab3a.1602864557.git.thomas.lendacky@amd.com>
 <000d01d6a5b9$03d14ef0$0b73ecd0$@byosoft.com.cn>
 <93c3b271-ccdb-6242-ce23-957eb73a66c0@amd.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <4955ba32-2bef-52d2-28be-6d3d179bd131@redhat.com>
Date: Mon, 19 Oct 2020 22:17:49 +0200
MIME-Version: 1.0
In-Reply-To: <93c3b271-ccdb-6242-ce23-957eb73a66c0@amd.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Tom,

On 10/19/20 14:50, Tom Lendacky wrote:
> On 10/18/20 8:41 PM, gaoliming wrote:

>>> +typedef enum {
>>> +  GhcbCpl          = OFFSET_OF (GHCB, SaveArea.Cpl) / sizeof (UINT64),
>>
>> OFFSET_OF (GHCB, SaveArea.Cpl) is 204. But, it can't fully divide 8
>> (sizeof(UINT64)). Is it correct?


I didn't notice this before, and from your response to Liming, I think
you may have missed Liming pointing it out as well.

Thanks
Laszlo