From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by mx.groups.io with SMTP id smtpd.web08.6172.1624962956309203060 for ; Tue, 29 Jun 2021 03:35:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@citrix.com header.s=securemail header.b=IkfyRi7+; spf=pass (domain: citrix.com, ip: 216.71.145.142, mailfrom: andrew.cooper3@citrix.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1624962956; h=to:cc:references:from:subject:message-id:date: in-reply-to:content-transfer-encoding:mime-version; bh=BswDUWUYz3AQCm0WpEc1t3iwZLOX9fCGw2Vz9B/S76g=; b=IkfyRi7+KG3TGKgt9QDNHU4qw28ZoOb2+U9c4MFYtTCxxNHM7gvAP2T2 aYeVF+2eJ2MTwXHaqrrMtXoDviiIIydYHC2svE7nxY92Qg8VQx5rEWIBF 1SaR+8wYh5/Bon4G6ukE3BXxYTLbA4z4kMweP6YICpy+icYXbArTJ8Izj I=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com IronPort-SDR: xj4NkcsdY+iDB8ZWWt7cZjyQyzvdp6zEr2+QtzJJ2N/k5N32fSCTlEfOvqqQIKufMskfzqJ703 wXwsRyJOlZFj3vEf1S6of+6IY/nEb7PqSPvB8qLPmdSiqAeVvxZ4b/2Go0QhA7uiTVvuGvdn3F b9amVshwAt3jZnAm93c6/AcNpu54vnjf4078rZ7jM9vAPb7/tGA6hpCNBMSz0i1dpFSi9DU6mg ajN29fXKJdLD5jd1HtuO1NrQCTipm1k4Yw2iI6sBDf/zxVxlo/roeGIvo9QmKX92KwqCtCNUtQ u6Q= X-SBRS: 5.1 X-MesageID: 47546105 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:+sspKKunh+ls57aTYDL0okGd7skCkoMji2hC6mlwRA09TyXGra 6TdaUguiMc1gx8ZJhBo7C90KnpewK5yXcH2/huAV7EZniYhILIFvAf0WKG+Vzd8kLFh5VgPM tbAs5D4ZjLfCVHZKXBkXuF+rQbsaG6GcmT7I+0pRodLnAJGtVdBkVCe2Gm+yVNNXp77PECZe OhD6R81l+dkDgsH76G7i5vZZmymzSHruOpXTc2QzocrCWehzKh77D3VzCewxclSjtKhZMv63 LMnQDV7riq96jT8G6d60bjq7Bt3PfxwNpKA8KBzuATNzXXkw6tIKBsQaeLsjwZqPymrHwqjN 7PiRE9ONkb0QKRQkiF5T/WnyXw2jcn7HHvjXWCh2H4nMD/TDUmT+JcmINwaHLimg8dleA59J gO83OStpJRAx+Ftj/6/cL0WxZjkVfxiWY+kNQUk2dUXeIlGf1sRLQkjQRo+ao7bWTHANhNKp g2MCic3ocUTbqiVQGcgoE1q+bcBkjad3y9Mz0/Us/86UkaoJk29TpC+CSz9k1wvK7VcKM0kd gsBJ4Y3o2mfvVmGp6VO91xCPdfKla9DS4kY1jibmgOKsk8SjnwQsnMkcQIDaeRCcY18Kc= X-IronPort-AV: E=Sophos;i="5.83,308,1616472000"; d="scan'208";a="47546105" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dOz7kRzWuxkg+AK+ZaqVctndl9g850w+UJnTSkTtqrXuDvpA76sBuTIIzdLo+hxMfi52P3QgQAVHAGFwpBmBKMPyeMFO/TRjnIvnKc7agWQBYe9BAfRx8CS5p95QoCNv9uFWCg5I6T2O6sMTlvl5KoIaaPJsfyaqgcQ82FT12xlhqhh89CXoG68C03LnmABT1ejgB/shvuGc3u3ijIJx8pkuQJ914frplodVg5OzL3lUggcsEQKt7lZv1BWCBrcDBO68RZBPt6DiVo84Jymmx0scSFJRQIXmLkRK6daY4mONDlml0GtraJxKJbeuYJ5hL7TW9NoYPJH8nUGbqMmF9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PSmCdGGcbijG2IC56QU+yLr2WLpYsGez9Lr6a5OkJv0=; b=Yv0frweMBZlPoaw/jSr25zPd6ax79SamaqPnia5ppVJXl98GrLc+i82toDcwc7thVSknFGRvaZfdvWpAyBmfq5yYcGiPJhIqmzVauB5Wo2cdWYikl8EeqbTxUW4W1E3HKog2WXy9Qvxz3c4w4FjnX/sDcOhdUFxsn5oW5i3ChyR6qjb/uoEm02WXhL5Yk9fFh/qt2R/CPQ/oitG9E0NsppTJVKYMZw5q80U1oUiNEiYPOL2k+MTdmoMGn5/ZvOuyFyOziDb1Q+u1cdOKW9CdgbLG0SfRlyQTAVRIJ3i8SwAlLVY5KVOWjyhHHbD+cEPnov1Gsw8ypkbyRar5xcks0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PSmCdGGcbijG2IC56QU+yLr2WLpYsGez9Lr6a5OkJv0=; b=tz3i4GZdQgVQSJ3U+oMyrG6w3YC91wC2Ocm8YYV+btXDHxKBp1mJDF+zGG7TAsFotvWQMIvex6C6HWrWZCM6b5YLUE440tS4/UY1tLXm6D/zEmL/DDSEmC/LP2+PvIqCarvPME6y5ZFfhcpFdJwKAfk81TMxo4JM+gQ68ifmKV4= To: Jan Beulich , Laszlo Ersek CC: Ard Biesheuvel , , References: <20210628132337.46345-1-anthony.perard@citrix.com> <4d4af77a-8d70-d473-179f-14b3cbc0e6fd@redhat.com> From: Andrew Cooper Subject: Re: [edk2-devel] [PATCH] OvmfPkg/XenPlatformPei: Relocate shared_info page mapping Message-ID: <4960ad34-2097-0f08-553c-477e90e19fe2@citrix.com> Date: Tue, 29 Jun 2021 11:35:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: X-ClientProxiedBy: LO2P265CA0014.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::26) To BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) Return-Path: andrew.cooper3@citrix.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8bd0106-37ad-4ed1-46d9-08d93ae9a008 X-MS-TrafficTypeDiagnostic: BYAPR03MB3991: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BaAh3lg/syovjy6MS/PN4cAzbNZ2RaYP4ly8bEq4qKtr3qo0j/8f8GfqkFlN2dqzfGNR31XQtgdoo4yFLjcCgGsvbFeGOJ2uXEGwmJ02lRU9dkB+cormoqqOrnhjth4o/tV+1+uCB2cbp701WeBhf/SXD3MGDT8UhgyGeoUEPB+edrKfXfn6TMeN8C6ox821LGWXIdUJ7GuMiE+9/acGeSLAdt42OCWRJrDbdmR03wW8b5+9gBjJP1Mde+gtkzZR1vAVNJyOlInXJPUequo6iDWrFEIxR5r9gYm3o3MQFJXvNdkrzOXuW+joqOscVND2SIj0cFnjGSUv0kS5bOCVymFZk7sEDCeGuBPQj7x3oqzJLiaQWrkyHHPJTwsdgEiIkQpqO1zFf+UGfI0aXr741fGWXb+/nHMVaIk+amAolTS6RdJ9efdLdRRZQQwGvZirjksePEJnwrbX8v8I66mmtI3qlRokgto8szLbQYQiypraPMQBP2otfA2J9zF1wrd6WniezeUmVRLkO0OU03/CwF0Kw7j30xar1r/cSjQVN8W5t1YVDSeb9PjK9mRZ0MpO4nAEiHHFcvzNpD1S1ZFrlE9H5U5+OYCgArE30wil24VflGqZq2jjR4YKfrbLXxXOojAjYUmKan5+7o/ePLWs2n/EykToyrj28kIUlOkwxJtiwIquyt+Y7yuwd1OZBX2Lz8IAAjnrJIyzQlSSWpX0sIBAuGkppmG1CFW1vIO/ZR3EcT+i+CYmvGj+hiJTPHcZABQ8GAH0waIqXc54IOlDjVs8Cwif8eiivm/OdPqnbNqqs7Z8F5axwBsHwI9VpTgpgflJR2aeWXNvyzLjOaSe64wkzwBiveyFG+M+RWvUwgU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(396003)(39850400004)(366004)(376002)(4326008)(8936002)(31696002)(6666004)(956004)(186003)(16526019)(110136005)(16576012)(316002)(2616005)(86362001)(8676002)(31686004)(966005)(53546011)(26005)(83380400001)(478600001)(5660300002)(66476007)(66946007)(38100700002)(107886003)(6486002)(66556008)(36756003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmhVaElRMVUyeEVCUDdCUm9qemY0UHExSlB6dXdZbGMweVUxVkhLQmpmcTBP?= =?utf-8?B?QnFxRXJaaXFjWGdZM3pVMG5ENGExZVRzYWJEeXVGQ0ZsSFRORGNobHZLeE1h?= =?utf-8?B?OWkrbXpBN2w4MTVmSU85MEV2enBwUzdMMXRnOE1tNXZvZUFMQWNMempPb3dz?= =?utf-8?B?b1lDRzFnTGJSU1MwWXdsSTFGT2d3YnBCK05STnVEUDdRaXJrMDY0K3doME5B?= =?utf-8?B?SHNQalRuUjhUM3pabFVRNjc5cHpZczdtUU1nSjFjeGlMa1FSMGJxMEk2Q0kv?= =?utf-8?B?TFRwQnpZWUd6VFhTOXRFVmNQU3VXRXlhQnFGMXdrZWlHYUs0Zmd2dm9rVlB5?= =?utf-8?B?dDJ0MlhtQ3hHekFIaUs2SFdFSTIyV05qa0hWYlN2bFpCNExza0x2dlk0OTMw?= =?utf-8?B?aURZMktreWI0end6aENrWGtIdVUyV2Qyclo3QVFBTklJZVBOYmNqMkVyNjVB?= =?utf-8?B?dlZMQVFwN1l1cUxacGcvMDEwNFFyc2ZQT1poNHJ4cXVCSmZRblZ4MTR1QnZT?= =?utf-8?B?RStDM0JGNEwxdWVYZkNKYkphSnYxb01jSk1Qc29qZS82emJxKytNNFhNaWtw?= =?utf-8?B?YlZtaXhKZFdqWnFISy82KzRUOThwb05kT3BpS1pUK1BuS1FabEN0ajVVcVFQ?= =?utf-8?B?VlNuR2ZrNzh1bzdjd0F1cGJTblpjc3AyVTVRSFhmN2hRSEJVRlYzUUNBYlNV?= =?utf-8?B?cVd0UVhBQURFeHZTbGV4SWZ4OU1pR3FMcUNpSFhVRk4vR252TUVTSkdsYzRM?= =?utf-8?B?VGVsOXVQcGh4M1pIOTMrQXovY0tVTE5nVnVTajhzajNIQkJ1T21YYndMb1BD?= =?utf-8?B?Y29EL0IrR1JybllIcjZiUE5HLzNxVllseGpqSjBuYndjcWxNMDZvL2NtNGFn?= =?utf-8?B?Y1RmcS9qTUFka0dDd1RQMWU4bW9IMDl3cjZjTXRNMEVTQXpVSkRXTFNyNW5P?= =?utf-8?B?YzRkUkFSYVlFTk0vbm5pSGVrVDJ4QWNxNWphQkxrNFFHdEdTYW8zakdNL2FG?= =?utf-8?B?SEs2VGQyQ0ZrNVJMVzVQTjBuSmpySHNZc1l2RExFWExoYVM4TEZreldGRUg3?= =?utf-8?B?aEpnUTh5MGJIekUwVkJVZ052SUVYVzdKMnhpRGZUdkJzSHR3QmJWZm5xVGN1?= =?utf-8?B?UlRGNkJYQVo3ZW1ZcWpUVlhLTS9lZDJma0svV1kvMEo2cFJhVk91TmhZYVlT?= =?utf-8?B?UTNTNFBSNmdOdXVqd1daL2ZxSWlqOE9sZGtUM2IyZEFHMzNSeGU4aWxzUXFB?= =?utf-8?B?S1JvUnRYNzFoZGJ5emRPb1F1RUczNWRuRlNaU01OcUtQQUorTE12MUE0azg3?= =?utf-8?B?VUdoUXREUVNrN0l4Y2U1WG5qdzUwSXhtNnI1VjcxQ3RHR0pPUXIyMGxvZFJM?= =?utf-8?B?QlVjTEhvbnBxUG1JNDk4RExZUmdKalZtOHNadW5VYjNPdVMrd0hIOUN2RCt2?= =?utf-8?B?cVN6U01YZFYvRUs4WFhxT0w5NEdmcjVFSEpkajlrNDhwVHI4UWs0dy9kRVhV?= =?utf-8?B?L1Z2bWs2bzVhdS94Q3QzcDJpMVNBU01CeERITUxZRUQyQU9pNFZMbkxDWEQ4?= =?utf-8?B?WkEvOGs0ZkNuZGIzZGJjMkVzblVRT3FMVG1XaWhMTWF5N3FnR2s4VTh5QVlp?= =?utf-8?B?aUpjekFuRmVOM2Q3L1BFMm0rbHptdHFvZWhKbXZDM09NT2pGbUhvYkdTaFY2?= =?utf-8?B?VGl3K0hGV3RHYWRLdEFPWVZlNmppQTdtSS82ZnFqeWNzUm4xazQ0T1FzK0N6?= =?utf-8?Q?ESRylDy9hn5GDD1Z0BGu9bE11ANUTVQWjv89xEW?= X-MS-Exchange-CrossTenant-Network-Message-Id: a8bd0106-37ad-4ed1-46d9-08d93ae9a008 X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2021 10:35:33.8972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: njwkGFK1R7vfmCe0izfkV3kF6mfl39HDf6+LBmt+U087v6i/VYCmidSjx2kMJVWV3NPzasaP4VxL5zBmtHLfCdJtIQANF9pr+NSKmhFhkeQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR03MB3991 X-OriginatorOrg: citrix.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-GB On 29/06/2021 11:07, Jan Beulich wrote: > On 29.06.2021 11:20, Laszlo Ersek wrote: >> On 06/28/21 15:23, Anthony PERARD via groups.io wrote: >>> From: Anthony PERARD >>> >>> Unfortunately, Xen isn't ready to deal with mapping at the top of the >>> physical address space, so we relocate the mapping after the LAPIC >>> location. >>> >>> See this thread about the issue with the mapping: >>> - https://lore.kernel.org/xen-devel/f8c4151a-6dac-d87c-ef46-eb35ada07bd= 9@suse.com/ >>> >>> The PhysicalAddressIdentityMapping() call isn't going to do anything >>> anymore since everything under 4GB is already mapped, but there is no >>> need to remove the call. >>> >>> CC: Jan Beulich >>> CC: Andrew Cooper >>> Signed-off-by: Anthony PERARD >>> --- >>> OvmfPkg/XenPlatformPei/Xen.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/OvmfPkg/XenPlatformPei/Xen.c b/OvmfPkg/XenPlatformPei/Xen.= c >>> index a4e82b356936..9c6641895970 100644 >>> --- a/OvmfPkg/XenPlatformPei/Xen.c >>> +++ b/OvmfPkg/XenPlatformPei/Xen.c >>> @@ -569,7 +569,7 @@ CalibrateLapicTimer ( >>> EFI_STATUS Status; >>> =20 >>> =20 >>> - SharedInfo =3D (VOID*)((1ULL << mPhysMemAddressWidth) - EFI_PAGE_SIZ= E); >>> + SharedInfo =3D (VOID*)((UINTN)PcdGet32 (PcdCpuLocalApicBaseAddress) = + SIZE_1MB); >>> Status =3D PhysicalAddressIdentityMapping ((EFI_PHYSICAL_ADDRESS)Sha= redInfo); >>> if (EFI_ERROR (Status)) { >>> DEBUG ((DEBUG_ERROR, >>> >> Acked-by: Laszlo Ersek >> >> I guess I should merge this after Jan and/or Andrew ack it. > Well, I can informally ack that a move like this is needed, but I can't > really give an Acked-by on the change, as I know next to nothing about > ovmf, and hence I cannot, for example, tell whether the chosen new > location is okay to use there. That bit is easy, although it probably does warrant a code comment.=C2=A0 T= he choice of location doesn't matter specifically (so long as it's not too high for 32bit toolstacks to cope with), but wants to be something which isn't RAM, and ideally doesn't shatter a superpage. The various MMIO ranges (IO-APIC, TPM, LAPIC) are 2M aligned, so LAPIC + 1M is firmly in the middle of a range not used by anything else, and with APICV/AVIC, the LAPIC does have a 4k mapping to the sink page. ~Andrew