From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x236.google.com (mail-pf0-x236.google.com [IPv6:2607:f8b0:400e:c00::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0BD8B21E43B5B for ; Fri, 22 Sep 2017 06:41:04 -0700 (PDT) Received: by mail-pf0-x236.google.com with SMTP id m63so578155pfk.7 for ; Fri, 22 Sep 2017 06:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=XuzK0NWFebXVtgLuB9/lEkJDGA6RLbliKSRd/p6hK94=; b=kyRfUq7FZi3YaZySVLc9n7L9paKMgWQPZs96Jw0BGsLMuG9hw4NUD8dXi5F6rn9/dQ iHTYVNXwNDrOPCHp0bXIjhqBk884G6Ekl07wtUMqXI4mMORGWuOxp8N1n4zjniuG1Cay Zb7X7tXwZ8cvzr3ofJrEUjbMsJhQgeSaVfFZc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=XuzK0NWFebXVtgLuB9/lEkJDGA6RLbliKSRd/p6hK94=; b=s1rQGdd5hftLJ53TKQ+RlQVg5ZPjcAB3bM7lAQCbp4pV4WuJ2r8KnRSuslq8P+X2p1 W3Xk8gPBl5Cyezwpbk9mXryPqOlcG8bgge6x7i7w3l7Mltav4OOLAwdpNXCYlR1RfLPl fSIy869UiRRGbzbSsW+X5ZalK9JJ9LHstINGwKqncgi5lfW87sJSgvlZhfhICevLQcpe 5CgvbG0bwYXsbNI8S1tMchTDjy/C03WVuwPPaNwK4B4zLO6ftmIJM8WnM5oWl+bJwP9c KRDUfiaZUaqmhd4zL3R6EnjGOw7oI6qTC0RAN/zwN6n9/oA5cyXCnZBnBBYCf/vslx2k QKtA== X-Gm-Message-State: AHPjjUgord54VU34/cKgfSD34xbvm9dbsl2HKDXcD67n5PzQ+PqPnROt QzgVxXpNZnCMEFAipbCSC+UtfA== X-Google-Smtp-Source: AOwi7QAtIuuFylA6z2eqdVR6tjFrgx/6e95h6Vt2Jj3C52Y0UNRnPm0UhULPW68+sw6jk5/wJ/YHcg== X-Received: by 10.84.132.78 with SMTP id 72mr9135263ple.185.1506087851795; Fri, 22 Sep 2017 06:44:11 -0700 (PDT) Received: from ?IPv6:2601:645:8001:d090:11c4:a78:55f9:f2d6? ([2601:645:8001:d090:11c4:a78:55f9:f2d6]) by smtp.gmail.com with ESMTPSA id t25sm8148540pfe.96.2017.09.22.06.44.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Sep 2017 06:44:11 -0700 (PDT) Mime-Version: 1.0 (1.0) From: Ard Biesheuvel X-Mailer: iPhone Mail (14F89) In-Reply-To: <20170922133456.8910-1-lersek@redhat.com> Date: Fri, 22 Sep 2017 06:44:09 -0700 Cc: edk2-devel@lists.01.org, Jaben Carsey , Ruiyu Ni , Steven Shi Message-Id: <49664C7F-F0AA-46AF-84A2-05F322BDB053@linaro.org> References: <20170922133456.8910-1-lersek@redhat.com> To: Laszlo Ersek Subject: Re: [PATCH] ShellPkg/DmpStore: fix GCC/CLANG build failure X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Sep 2017 13:41:04 -0000 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable On 22 Sep 2017, at 06:34, Laszlo Ersek wrote: >> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c:525:66: error: >> passing argument 2 of 'gEfiShellProtocol->GetGuidName' from incompatible >> pointer type [-Werror=3Dincompatible-pointer-types] >>=20 >> Status =3D gEfiShellProtocol->GetGuidName(&FoundVarGuid, &GuidName);= >> ^ >> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c:525:66: note: >> expected 'const CHAR16 ** {aka const short unsigned int **}' but >> argument is of type 'CHAR16 ** {aka short unsigned int **}' >=20 > Pointer-to-(pointer-to-CHAR16) and pointer-to-(pointer-to-const-CHAR16) > are incompatible types; GCC and CLANG are right to complain. >=20 > Cc: Ard Biesheuvel > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Steven Shi > Reported-by: Jenkins Build Host > Reported-by: Steven Shi > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D716 > Fixes: 09e8678380aaaf0a5ef59179ff59e0a045d1b0bf > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > I'm going to push this as soon as I get an R-b from anyone. >=20 Reviewed-by: Ard Biesheuvel > Thanks > Laszlo >=20 > ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c b/Shel= lPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > index 062ab5dc3a9a..5791da9acc8c 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c > @@ -424,7 +424,7 @@ CascadeProcessVariables ( > CHAR16 *AttrString; > CHAR16 *HexString; > EFI_STATUS SetStatus; > - CHAR16 *GuidName; > + CONST CHAR16 *GuidName; >=20 > if (ShellGetExecutionBreakFlag()) { > return (SHELL_ABORTED); > --=20 > 2.14.1.3.gb7cf6e02401b >=20