From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mx.groups.io with SMTP id smtpd.web10.24181.1683606533122498117 for ; Mon, 08 May 2023 21:28:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=MoLvr4uA; spf=pass (domain: bsdio.com, ip: 64.147.123.19, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 1BBA132009E6; Tue, 9 May 2023 00:28:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 09 May 2023 00:28:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683606531; x=1683692931; bh=lDvVHavV665vYxLLo0SGDQVh5Px6oFlRpRM n3/ipBjg=; b=MoLvr4uATvudc3uSAycsc3do5K7RXrX3aKCC4uVFkFvVhIYuDfx v9c+PwHSk496tOiCCjp+8D65YnJ8Axa+3YDzP7T8oN48LFKAPogzT5k+6vnHnxli jiBSjkELC8NB43fESdZWVGeqPw6uva/kRkEPYge737F0003FxTrMJGh2YeVS5eNB IIX+pPApNajdD/Qg74fI/Mo2Er3BU3Bsqws8zZ/458YyLScBOHpGypIhsvwKQU3I IHQX4a2DetSozeU92yBhfzh5YWELX1iQb+yi7si/ZjP5g7zYv0RBxf6pMfs5dMST 88HCXFELMi6u8fSU8HUsTXdQdmSFyx7gxDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683606531; x=1683692931; bh=lDvVHavV665vYxLLo0SGDQVh5Px6oFlRpRM n3/ipBjg=; b=IQtQSD40k4kEmnMIspX1occBXp51ZVl25+KYz5ZG0ktDdiZu4sk s9TWBRsM78/7w2pIDWUa6u7X4mAEAdzGLAigztSQZLPtLY+n4cVmSK5R0eUYUw3P 8e8TiR+E4BinyhFygqxwlE7T+k8+tMfVhblFXQSow0sNrUBZSy9z6/VANYu8YsnU GVxvn/H3tIolW702gc7OxAchCw7ZWefYLM6BZrbuvE4uFjSTYytg1nbblgoG4dIC JqMYviAx1exyjnvfS7+aW+HrmneB5kfFXn1n/ySFu+9pZks7Az9zM6Pi035PwUJu 9OFgVm9ZQ3spVrwgUsGzpxF+UrxFtqqziIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeefledgkeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeetgeejgfefffelfedtleehfeeuhfeutdffueduhfejteduvdekveekteef vdelkeenucffohhmrghinhepghhrohhuphhsrdhiohenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 9 May 2023 00:28:50 -0400 (EDT) Message-ID: <498c298a-7ee6-1f9f-d56f-11db88d147ab@bsdio.com> Date: Mon, 8 May 2023 22:28:49 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSCAxLzFdIFJlbW92ZSBiYXNoaXNtcyBmcm9tIGVka3NldHVwLnNoIGFuZCBCYXNlVG9vbHMvQnVpbGRFbnY=?= To: gaoliming , devel@edk2.groups.io, pedro.falcato@gmail.com Cc: 'Bob Feng' , 'Yuwei Chen' , 'Andrew Fish' , 'Leif Lindholm' , 'Michael D Kinney' References: <20230506182311.14023-1-rebecca@bsdio.com> <175CA4E73380D66F.2502@groups.io> <3e01cc9e-ac5f-bf4d-0359-adfc1aa21c4b@bsdio.com> <7e3cccac-ade2-7a5c-29e0-50c080a31abe@bsdio.com> <025401d98210$bb90b1d0$32b21570$@byosoft.com.cn> From: "Rebecca Cran" In-Reply-To: <025401d98210$bb90b1d0$32b21570$@byosoft.com.cn> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit I'd like this to go in for the edk2-stable202305 tag. -- Rebecca Cran On 5/8/23 18:53, gaoliming wrote: > Reviewed-by: Liming Gao > >> -----邮件原件----- >> 发件人: devel@edk2.groups.io 代表 Pedro Falcato >> 发送时间: 2023年5月7日 11:51 >> 收件人: Rebecca Cran >> 抄送: devel@edk2.groups.io; Liming Gao ; Bob >> Feng ; Yuwei Chen ; Andrew >> Fish ; Leif Lindholm ; >> Michael D Kinney >> 主题: Re: [edk2-devel] [PATCH 1/1] Remove bashisms from edksetup.sh and >> BaseTools/BuildEnv >> >> On Sun, May 7, 2023 at 4:31 AM Rebecca Cran wrote: >>> On 5/6/23 15:48, Pedro Falcato wrote: >>>> My local installations of Net (latest stable) and FreeBSD (13.1 with a >>>> hacked-up kernel) do not have a python3 symlink. >>>> >>>> I'm slightly worried that this breaks something. I know requiring >>>> whereis isn't ideal, but I'm fairly sure it did handle this situation? >>> I uninstalled the python and python3 packages, leaving only python39. >>> >>> I got the following results on edk2 master: >>> >>> >>> [bcran@maxamd ~/src/uefi/edk2]$ whereis python3 >>> python3: >>> >>> [bcran@maxamd ~/src/uefi/edk2]$ ls /usr/local/bin | grep python >>> >>> python3.9 >>> >>> python3.9-config >>> >>> [bcran@maxamd ~/src/uefi/edk2]$ . edksetup.sh >>> Using EDK2 in-source Basetools >>> WORKSPACE: /home/bcran/src/uefi/edk2 >>> EDK_TOOLS_PATH: /home/bcran/src/uefi/edk2/BaseTools >>> >>> CONF_PATH: /home/bcran/src/uefi/edk2/Conf >>> >>> >>> [bcran@maxamd ~/src/uefi/edk2]$ echo $PYTHON_COMMAND >>> >>> [bcran@maxamd ~/src/uefi/edk2]$ gmake -C BaseTools/ -j16 >>> gmake: Entering directory '/usr/home/bcran/src/uefi/edk2/BaseTools' >>> gmake -C Source/C >>> gmake -C Source/Python >>> gmake[1]: Entering directory >>> '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/C' >>> gmake[1]: Entering directory >>> '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/Python' >>> gmake[1]: Nothing to be done for 'all'. >>> gmake[1]: Leaving directory >>> '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/Python' >>> Attempting to detect HOST_ARCH from 'uname -m': amd64 >>> Detected HOST_ARCH of X64 using uname. >>> mkdir -p . >>> mkdir ./libs >>> mkdir ./bin >>> gmake -C VfrCompile VfrLexer.h >>> gmake -C Common >>> gmake[2]: Entering directory >>> '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/C/VfrCompile' >>> gmake[2]: Entering directory >>> '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/C/Common' >>> >>> ..... >>> >>> Finished building BaseTools C Tools with HOST_ARCH=X64 >>> gmake[1]: Leaving directory >>> '/usr/home/bcran/src/uefi/edk2/BaseTools/Source/C' >>> gmake -C Tests >>> gmake[1]: Entering directory >> '/usr/home/bcran/src/uefi/edk2/BaseTools/Tests' >>> /bin/sh: python: not found >>> gmake[1]: *** [GNUmakefile:11: test] Error 127 >>> gmake[1]: Leaving directory >> '/usr/home/bcran/src/uefi/edk2/BaseTools/Tests' >>> gmake: *** [GNUmakefile:19: Tests] Error 2 >>> gmake: Leaving directory '/usr/home/bcran/src/uefi/edk2/BaseTools' >>> ... >>> >>> [bcran@maxamd ~/src/uefi/edk2]$ build -p OvmfPkg/OvmfPkgX64.dsc -a >> X64 >>> -t GCC -b RELEASE >>> /home/bcran/src/uefi/edk2/BaseTools/BinWrappers/PosixLike/build: line >>> 14: exec: python: not found >> Thank you for your testing. I asked around and came to the conclusion >> it's a FreeBSD "meta-package" that lots of people don't have >> installed. >> >> If this doesn't break anything, I'm ok with it. Although there should >> really be a better solution, the status quo sucks. >> >> That said, the rest of the POSIX sh conversion looks ok to me. >> >> Acked-by: Pedro Falcato >> >> Although there's a small fixup you may want to do at >> >echo "source $SCRIPTNAME" >> Since source is not POSIX, but '.' is. >> >> -- >> Pedro >> >> >> >> > >