From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.2526.1573123711099178022 for ; Thu, 07 Nov 2019 02:48:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CE5hdWPC; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573123710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eceLN2ah+A1Ved4ib3VCTEGJveRT59Hc+NtQBrYVnMo=; b=CE5hdWPC39uxyGReGuTU7L6QhlTvQDElKDWg4BZ7BGYBWjuiHxKJWGnl3Ceb9ZvPjufNow JY162aBbWjU+OlwKycmZcy/kP4RrRoKW1+SyKMCFCgHoB1ohjJWqsBJ2Y8m7OB9JnAX95W FdCFxtEbUfy4ypE3eFppociF3u38oxw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-321-4akwQSR8O_e1bGaEH_D6ig-1; Thu, 07 Nov 2019 05:48:26 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F859800C61; Thu, 7 Nov 2019 10:48:25 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4F22F600D1; Thu, 7 Nov 2019 10:48:24 +0000 (UTC) Subject: Re: [Patch v4 17/22] UefiCpuPkg: Add YAML file for CI builds From: "Laszlo Ersek" To: Michael D Kinney , devel@edk2.groups.io Cc: Eric Dong , Ray Ni References: <20191107011349.16524-1-michael.d.kinney@intel.com> <20191107011349.16524-18-michael.d.kinney@intel.com> <6925ef4e-98dd-8634-1cbc-d177f1faa772@redhat.com> Message-ID: <4994e6f9-9a56-8be2-1167-41e56f5ff457@redhat.com> Date: Thu, 7 Nov 2019 11:48:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <6925ef4e-98dd-8634-1cbc-d177f1faa772@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: 4akwQSR8O_e1bGaEH_D6ig-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 11/07/19 11:42, Laszlo Ersek wrote: > On 11/07/19 02:13, Michael D Kinney wrote: >> Add YAML file to the package directory with the >> configuration of the checks to perform during a >> CI build. >> >> Cc: Eric Dong >> Cc: Ray Ni >> Cc: Laszlo Ersek >> Signed-off-by: Michael D Kinney >> Acked-by: Laszlo Ersek >> --- >> UefiCpuPkg/UefiCpuPkg.ci.yaml | 51 +++++++++++++++++++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> create mode 100644 UefiCpuPkg/UefiCpuPkg.ci.yaml >> >> diff --git a/UefiCpuPkg/UefiCpuPkg.ci.yaml b/UefiCpuPkg/UefiCpuPkg.ci.ya= ml >> new file mode 100644 >> index 0000000000..81da29b878 >> --- /dev/null >> +++ b/UefiCpuPkg/UefiCpuPkg.ci.yaml >> @@ -0,0 +1,51 @@ >> +## >> +# CI configuration for UefiCpuPkg >> +# >> +# Copyright (c) Microsoft Corporation >> +# SPDX-License-Identifier: BSD-2-Clause-Patent >> +## >> +{ >> + "CompilerPlugin": { >> + "DscPath": "UefiCpuPkg.dsc" >> + }, >> + "CharEncodingCheck": { >> + "IgnoreFiles": [] >> + }, >> + "DependencyCheck": { >> + "AcceptableDependencies": [ >> + "MdePkg/MdePkg.dec", >> + "MdeModulePkg/MdeModulePkg.dec", >> + "UefiCpuPkg/UefiCpuPkg.dec" >> + ], >> + # For host based unit tests >> + "AcceptableDependencies-HOST_APPLICATION":[], >> + # For UEFI shell based apps >> + "AcceptableDependencies-UEFI_APPLICATION":[], >> + "IgnoreInf": [] >> + }, >> + "DscCompleteCheck": { >> + "DscPath": "UefiCpuPkg.dsc", >> + "IgnoreInf": [ >> + "UefiCpuPkg/ResetVector/FixupVtf/Vtf.inf", >> + "UefiCpuPkg/ResetVector/Vtf0/Vtf0.inf" >> + ] >> + }, >> + "GuidCheck": { >> + "IgnoreGuidName": ["SecCore", "ResetVector"], # Expected duplic= ation for gEfiFirmwareVolumeTopFileGuid >> + "IgnoreGuidValue": [], >> + "IgnoreFoldersAndFiles": [], >> + "IgnoreDuplicates": [] >> + }, >> + "LibraryClassCheck": { >> + "IgnoreHeaderFile": [] >> + }, >> + >> + ## options defined ci/Plugin/SpellCheck >> + "SpellCheck": { >> + "AuditOnly": True, # Fails test but run in AuditOnly = mode to collect log >> + "IgnoreFiles": [], # use gitignore syntax to ignore e= rrors in matching files >> + "ExtendWords": [], # words to extend to the dictionar= y for this package >> + "IgnoreStandardPaths": [], # Standard Plugin defined paths th= at should be ignore >> + "AdditionalIncludePaths": [] # Additional paths to spell check = (wildcards supported) >> + } >> +} >> >=20 > This is a very nice patch: good commit message (subjet and body both), > and good file comment. >=20 > One suggestion: I'd recommend adding "@file" to the comment block at the > top. >=20 > With that: >=20 > Acked-by: Laszlo Ersek >=20 > (Of course, should "@file" confuse the YAML parser, then I won't insist, > and my ACK still applies.) Ah, another remark: I believe the copyright notice should state a year. (Most likely "2019".) Thanks Laszlo