From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.88; helo=mga01.intel.com; envelope-from=michael.a.kubacki@intel.com; receiver=edk2-devel@lists.01.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CCFAC21195BEE for ; Tue, 18 Dec 2018 09:32:47 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2018 09:32:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,368,1539673200"; d="scan'208";a="260488750" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga004.jf.intel.com with ESMTP; 18 Dec 2018 09:32:46 -0800 Received: from orsmsx121.amr.corp.intel.com ([169.254.10.85]) by ORSMSX108.amr.corp.intel.com ([169.254.2.224]) with mapi id 14.03.0415.000; Tue, 18 Dec 2018 09:32:46 -0800 From: "Kubacki, Michael A" To: "Yao, Jiewen" , "Fu, Siyuan" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg Drivers. Thread-Index: AQHUk3atdpCbbu3AT0WTUyZW2tpJRqWEpxcAgABFawD//9tpIA== Date: Tue, 18 Dec 2018 17:32:45 +0000 Message-ID: <49AB4ACB9627B8468F29D589A27B74558446F923@ORSMSX121.amr.corp.intel.com> References: <20181214063132.16548-1-siyuan.fu@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F45B12E@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F45B12E@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjZhZjJmMjctOWRjNi00MzgzLThmYzQtY2UzZGZlYzdhZTUzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVFFpTG1GQVRuVWFUU281ZUt4dW02WjhGV3hkVlpwSHZPcEZndlVHRW9teDdiRDFNTHR2Nk5YTHUwbUFHQjZVMSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/TCP with NetworkPkg Drivers. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2018 17:32:48 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki -----Original Message----- From: Yao, Jiewen=20 Sent: Tuesday, December 18, 2018 3:42 AM To: Fu, Siyuan ; edk2-devel@lists.01.org Cc: Kubacki, Michael A Subject: RE: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg PXE/iSCSI/T= CP with NetworkPkg Drivers. Looks good. Reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: Fu, Siyuan > Sent: Tuesday, December 18, 2018 3:33 PM > To: Fu, Siyuan ; edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Kubacki, Michael A=20 > > Subject: RE: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg=20 > PXE/iSCSI/TCP with NetworkPkg Drivers. >=20 > Hi, Jiewen and Kubacki >=20 > Do you have any comments for this patch? >=20 > BestRegards > Fu Siyuan >=20 >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf=20 > > Of > Fu > > Siyuan > > Sent: Friday, December 14, 2018 2:32 PM > > To: edk2-devel@lists.01.org > > Cc: Yao, Jiewen ; Kubacki, Michael A=20 > > > > Subject: [edk2] [PATCH] Edk2Platforms: Replace MdeModulePkg > PXE/iSCSI/TCP with > > NetworkPkg Drivers. > > > > The PXE/iSCSI/TCP drivers in MdeModulePkg are going to be deprecated. > All > > platform DSC/FDF files should be updated to use the dual-stack=20 > > drivers in NetworkPkg. > > > > Cc: Michael A Kubacki > > Cc: Jiewen Yao > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Fu Siyuan > > --- > > > Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclude. > dsc | 7 > > ++----- > > > Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclude. > fdf | 7 > > ++----- > > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > | 3 > > +-- > > 3 files changed, 5 insertions(+), 12 deletions(-) > > > > diff --git > > > a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud > e.dsc > > > b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud > e.dsc > > index 4d70db6062..6764d46131 100644 > > --- > a/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud > e.dsc > > +++ > b/Platform/Intel/AdvancedFeaturePkg/Include/Dsc/CoreAdvancedDxeInclud > e.dsc > > @@ -1,7 +1,7 @@ > > ## @file > > # Platform description. > > # > > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights=20 > > +reserved.
> > # > > # This program and the accompanying materials are licensed and made > available > > under > > # the terms and conditions of the BSD License which accompanies=20 > > this distribution. > > @@ -26,10 +26,7 @@ > > MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > - MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > > MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > > - MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > > - #MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > > > > NetworkPkg/Ip6Dxe/Ip6Dxe.inf > > NetworkPkg/TcpDxe/TcpDxe.inf > > @@ -42,7 +39,7 @@ > > NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > > NetworkPkg/HttpBootDxe/HttpBootDxe.inf > > > > - #NetworkPkg/IScsiDxe/IScsiDxe.inf > > + NetworkPkg/IScsiDxe/IScsiDxe.inf > > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > !endif > > > > diff --git > > > a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud > e.fdf > > > b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud > e.fdf > > index 0be408d13b..64f1dd5872 100644 > > --- > > > a/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud > e.fdf > > +++ > > > b/Platform/Intel/AdvancedFeaturePkg/Include/Fdf/CoreAdvancedLateInclud > e.fdf > > @@ -1,7 +1,7 @@ > > ## @file > > # FDF file of Platform. > > # > > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights=20 > > +reserved.
> > # > > # This program and the accompanying materials are licensed and made > available > > under > > # the terms and conditions of the BSD License which accompanies=20 > > this distribution. > > @@ -27,9 +27,6 @@ INF > MdeModulePkg/Universal/Network/Dhcp4Dxe/Dhcp4Dxe.inf > > INF MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Dxe.inf > > INF MdeModulePkg/Universal/Network/Mtftp4Dxe/Mtftp4Dxe.inf > > INF MdeModulePkg/Universal/Network/Udp4Dxe/Udp4Dxe.inf > > -#INF MdeModulePkg/Universal/Network/Tcp4Dxe/Tcp4Dxe.inf > > -INF MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > > -#INF > MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > > > > INF NetworkPkg/Ip6Dxe/Ip6Dxe.inf > > INF NetworkPkg/TcpDxe/TcpDxe.inf > > @@ -42,7 +39,7 @@ INF NetworkPkg/HttpDxe/HttpDxe.inf INF =20 > > NetworkPkg/HttpUtilitiesDxe/HttpUtilitiesDxe.inf > > INF NetworkPkg/HttpBootDxe/HttpBootDxe.inf > > > > -#INF NetworkPkg/IScsiDxe/IScsiDxe.inf > > +INF NetworkPkg/IScsiDxe/IScsiDxe.inf > > INF NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > > !endif > > > > diff --git > a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > index 2174eaa609..dd0173a1af 100644 > > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > @@ -1,7 +1,7 @@ > > ## @file > > # Platform description. > > # > > -# Copyright (c) 2017, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2017 - 2018, Intel Corporation. All rights=20 > > +reserved.
> > # > > # This program and the accompanying materials are licensed and made > available > > under > > # the terms and conditions of the BSD License which accompanies=20 > > this distribution. > > @@ -83,7 +83,6 @@ > > UdpIoLib|MdeModulePkg/Library/DxeUdpIoLib/DxeUdpIoLib.inf > > TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > > DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > > - TcpIoLib|MdeModulePkg/Library/DxeTcpIoLib/DxeTcpIoLib.inf > > > > > OemHookStatusCodeLib|MdeModulePkg/Library/OemHookStatusCodeLibN > ull/OemHookStat > > usCodeLibNull.inf > > > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in > f > > > > -- > > 2.19.1.windows.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel