From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "Chiu, Chasel" <chasel.chiu@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Yao, Jiewen" <jiewen.yao@intel.com>
Subject: Re: [PATCH] MinPlatformPkg: Correct typo in INF
Date: Thu, 17 Jan 2019 05:17:52 +0000 [thread overview]
Message-ID: <49AB4ACB9627B8468F29D589A27B74558449EA75@ORSMSX121.amr.corp.intel.com> (raw)
In-Reply-To: <20190117001110.10048-1-chasel.chiu@intel.com>
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>
-----Original Message-----
From: Chiu, Chasel
Sent: Wednesday, January 16, 2019 4:11 PM
To: edk2-devel@lists.01.org
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
Subject: [PATCH] MinPlatformPkg: Correct typo in INF
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1468
SiliconPolicyInitLibNull.inf and SiliconPolicyUpdateLibNull.inf both had wrong BASE_NAME and LIBRARY_CLASS, so correct them to align with file naming and the purpose.
Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
Platform/Intel/MinPlatformPkg/PlatformInit/Library/SiliconPolicyInitLibNull/SiliconPolicyInitLibNull.inf | 6 +++---
Platform/Intel/MinPlatformPkg/PlatformInit/Library/SiliconPolicyUpdateLibNull/SiliconPolicyUpdateLibNull.inf | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/SiliconPolicyInitLibNull/SiliconPolicyInitLibNull.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/SiliconPolicyInitLibNull/SiliconPolicyInitLibNull.inf
index 593d1490f1..ae696ccc90 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/SiliconPolicyInitLibNull/SiliconPolicyInitLibNull.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/SiliconPolicyIn
+++ itLibNull/SiliconPolicyInitLibNull.inf
@@ -1,7 +1,7 @@
## @file
# Component information file for Silicon Init Library # -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights
+reserved.<BR>
#
# This program and the accompanying materials are licensed and made available under # the terms and conditions of the BSD License which accompanies this distribution.
@@ -15,11 +15,11 @@
[Defines]
INF_VERSION = 0x00010005
- BASE_NAME = SiliconInitLibNull
+ BASE_NAME = SiliconPolicyInitLibNull
FILE_GUID = 81B55810-E3DE-4E3E-8477-B8768232193A
MODULE_TYPE = BASE
VERSION_STRING = 1.0
- LIBRARY_CLASS = SiliconInitLib
+ LIBRARY_CLASS = SiliconPolicyInitLib
[LibraryClasses]
BaseLib
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/SiliconPolicyUpdateLibNull/SiliconPolicyUpdateLibNull.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/SiliconPolicyUpdateLibNull/SiliconPolicyUpdateLibNull.inf
index ab03602297..d2018881bb 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/SiliconPolicyUpdateLibNull/SiliconPolicyUpdateLibNull.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/SiliconPolicyUp
+++ dateLibNull/SiliconPolicyUpdateLibNull.inf
@@ -1,7 +1,7 @@
## @file
# Component information file for Silicon Update Library # -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights
+reserved.<BR>
#
# This program and the accompanying materials are licensed and made available under # the terms and conditions of the BSD License which accompanies this distribution.
@@ -15,11 +15,11 @@
[Defines]
INF_VERSION = 0x00010005
- BASE_NAME = SiliconUpdateLibNull
+ BASE_NAME = SiliconPolicyUpdateLibNull
FILE_GUID = 7D4AA651-D23B-42FC-ABE4-8A2FDF260B9F
MODULE_TYPE = BASE
VERSION_STRING = 1.0
- LIBRARY_CLASS = SiliconUpdateLib
+ LIBRARY_CLASS = SiliconPolicyUpdateLib
[LibraryClasses]
BaseLib
--
2.13.3.windows.1
prev parent reply other threads:[~2019-01-17 5:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 0:11 [PATCH] MinPlatformPkg: Correct typo in INF Chasel, Chiu
2019-01-17 5:17 ` Kubacki, Michael A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AB4ACB9627B8468F29D589A27B74558449EA75@ORSMSX121.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox