Re: [PATCH v1] ClevoOpenBoardPkg: Add initial implementation of ClevoOpenBoardPkg

["Kubacki, Michael A" <michael.a.kubacki@intel.com>]

Hi Mike,

1, 2, & 4) An updated patch series has been sent
3) In the short-term only Windows is supported. Eventually, these should be replaced by Python scripts that will support non-Windows environments. A similar infrastructure would be shared with the other OpenBoardPkgs in the Intel directory such as KabylakeOpenBoardPkg.

I also posted the changes to the following branch on my fork: https://github.com/makubacki/edk2-platforms/tree/add_initial_clevoopenboardpkg 

Regards,
Michael

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Tuesday, January 22, 2019 3:32 PM
> To: Kubacki, Michael A <michael.a.kubacki@intel.com>; edk2-
> devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Yao, Jiewen <jiewen.yao@intel.com>
> Subject: RE: [PATCH v1] ClevoOpenBoardPkg: Add initial implementation of
> ClevoOpenBoardPkg
> 
> Hi Michael,
> 
> 1) Is this content intended for a new branch or an
>    existing branch in the edk2-platforms repo?  The
>    subject line of the commit message can help clarify
>    this.  The required format is:
> 
> 	[PATCH][platforms/branch]: Package/Module: Subject
> 
> 2) The patch email size is large (2MB).  Can you break
>    it up into a patch series.  Perhaps one for the new
>    package with its DEC/Includes, one or more for the
>    package libraries, one or more for the package modules,
>    and one for the package DSC/FDF/platform build files?
>    Try to target < 500KB per patch.
> 
>    If a patch series is large, another recommendation
>    is to also post the patch series to a personal GitHub
>    account to support review/test by the community.
> 
> 3) I see .bat files.  Are there any plans to support
>    non windows build environments?
> 
> 4) If you run BaseTools/Scripts/PatchCheck.py, there
>    are 2 minor issues to resolve.
> 
> Best regards,
> 
> Mike