From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=michael.a.kubacki@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E1AE62194D387 for ; Tue, 22 Jan 2019 18:23:26 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2019 18:23:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,509,1539673200"; d="scan'208";a="108996410" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga007.jf.intel.com with ESMTP; 22 Jan 2019 18:23:25 -0800 Received: from orsmsx121.amr.corp.intel.com ([169.254.10.212]) by ORSMSX102.amr.corp.intel.com ([169.254.3.115]) with mapi id 14.03.0415.000; Tue, 22 Jan 2019 18:23:25 -0800 From: "Kubacki, Michael A" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Wu, Hao A" , "Gao, Liming" , "Yao, Jiewen" Thread-Topic: [PATCH v1] ClevoOpenBoardPkg: Add initial implementation of ClevoOpenBoardPkg Thread-Index: AQHUsoSMlPL53bzzD0Kof/HlaDT8zqW8dkwA//+kqlA= Date: Wed, 23 Jan 2019 02:23:24 +0000 Message-ID: <49AB4ACB9627B8468F29D589A27B7455844A728D@ORSMSX121.amr.corp.intel.com> References: <20190122185825.21664-1-michael.a.kubacki@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTJjZTE2NzYtZTRlNi00NTQ3LTliZjctODEwNzdiN2RiMzRkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoid1ZyaHR3Uk9Qdit5SEVIcWJJY2d4cXhybmlFWVZqOHJNNnc5VndZRGZBazFQWnVZWEFvKzcyU0FycVp0U1hhWSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH v1] ClevoOpenBoardPkg: Add initial implementation of ClevoOpenBoardPkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2019 02:23:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Mike, 1, 2, & 4) An updated patch series has been sent 3) In the short-term only Windows is supported. Eventually, these should be= replaced by Python scripts that will support non-Windows environments. A s= imilar infrastructure would be shared with the other OpenBoardPkgs in the I= ntel directory such as KabylakeOpenBoardPkg. I also posted the changes to the following branch on my fork: https://githu= b.com/makubacki/edk2-platforms/tree/add_initial_clevoopenboardpkg=20 Regards, Michael > -----Original Message----- > From: Kinney, Michael D > Sent: Tuesday, January 22, 2019 3:32 PM > To: Kubacki, Michael A ; edk2- > devel@lists.01.org; Kinney, Michael D > Cc: Wu, Hao A ; Gao, Liming ; > Yao, Jiewen > Subject: RE: [PATCH v1] ClevoOpenBoardPkg: Add initial implementation of > ClevoOpenBoardPkg >=20 > Hi Michael, >=20 > 1) Is this content intended for a new branch or an > existing branch in the edk2-platforms repo? The > subject line of the commit message can help clarify > this. The required format is: >=20 > [PATCH][platforms/branch]: Package/Module: Subject >=20 > 2) The patch email size is large (2MB). Can you break > it up into a patch series. Perhaps one for the new > package with its DEC/Includes, one or more for the > package libraries, one or more for the package modules, > and one for the package DSC/FDF/platform build files? > Try to target < 500KB per patch. >=20 > If a patch series is large, another recommendation > is to also post the patch series to a personal GitHub > account to support review/test by the community. >=20 > 3) I see .bat files. Are there any plans to support > non windows build environments? >=20 > 4) If you run BaseTools/Scripts/PatchCheck.py, there > are 2 minor issues to resolve. >=20 > Best regards, >=20 > Mike