[edk2-platforms/devel-MinPlatform][PATCH v1 0/6] Some cleanup for platforms under ClevoOpenBoardPkg & KabylakeOpenBoardPkg

[edk2-platforms/devel-MinPlatform][PATCH v1 0/6] Some cleanup for platforms under ClevoOpenBoardPkg & KabylakeOpenBoardPkg

[Wu, Hao A]

The series will do the below cleanups for platforms under
ClevoOpenBoardPkg and KabylakeOpenBoardPkg:

A) Remove unused PCD 'PcdUseHpetTimer';
B) Remove the unnecessary consumption of the 8259-related PCDs;
C) Remove the unused duplicated Legacy8259 protocol GUID.


Test done for the series:
Build pass for N1xxWU & KabyLakeRvp3 platforms.

Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

Hao Wu (6):
  ClevoOpenBoardPkg/N1xxWU: Remove unused PCD 'PcdUseHpetTimer'
  ClevoOpenBoardPkg/N1xxWU: Remove the consume of 8259-related PCD
  KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'
  KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD
  KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'
  KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID

 Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec                              | 4 +---
 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc          | 1 -
 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc             | 2 --
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc | 3 +--
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc    | 5 +----
 Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc                 | 3 +--
 6 files changed, 4 insertions(+), 14 deletions(-)

-- 
2.12.0.windows.1

[edk2-platforms/devel-MinPlatform][PATCH v1 1/6] ClevoOpenBoardPkg/N1xxWU: Remove unused PCD 'PcdUseHpetTimer'

[Wu, Hao A]

For N1xxWU, it is using the HPET timer unconditionally. The PCD
'PcdUseHpetTimer' is not being used.

This commit will remove the usage of the above PCD in package DSC files.

Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc
index b4b4763a36..2f7d386469 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc
@@ -107,7 +107,6 @@ [PcdsFeatureFlag]
   gSiPkgTokenSpaceGuid.PcdSmmVariableEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSoftwareGuardEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSsaFlagEnable|FALSE
-  gSiPkgTokenSpaceGuid.PcdUseHpetTimer|TRUE                       # TRUE - HPET / FALSE - 8254 timer is used.
   gSiPkgTokenSpaceGuid.PcdOcWdtEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSiCatalogDebugEnable|FALSE
 
-- 
2.12.0.windows.1

[edk2-platforms/devel-MinPlatform][PATCH v1 2/6] ClevoOpenBoardPkg/N1xxWU: Remove the consume of 8259-related PCD

[Wu, Hao A]

For N1xxWU, none of its consumed modules is using the PCD:
gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask

Thus, this commit will remove the PCD consumption in the DSC file.

Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Ankit Sinha <ankit.sinha@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc
index bcb5ed98b4..1372dd81fc 100644
--- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc
@@ -187,8 +187,6 @@ [PcdsFixedAtBuild.IA32]
   gIntelFsp2WrapperTokenSpaceGuid.PcdPeiMinMemSize|0x3800000
 
 [PcdsFixedAtBuild.X64]
-  gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask|0x0eB8
-
   # Default platform supported RFC 4646 languages: (American) English
   gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes|"en-US"
 
-- 
2.12.0.windows.1

[edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'

[Wu, Hao A]

For KabylakeRvp3, it is using the HPET timer unconditionally. The PCD
'PcdUseHpetTimer' is not being used.

This commit will remove the usage of the above PCD in package DSC files.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc
index bb06ff5a2a..f3d082ce41 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.dsc
@@ -1,7 +1,7 @@
 ## @file
 #  Platform configuration file.
 #
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
 #
 # This program and the accompanying materials are licensed and made available under
 # the terms and conditions of the BSD License which accompanies this distribution.
@@ -111,7 +111,6 @@ [PcdsFeatureFlag]
   gSiPkgTokenSpaceGuid.PcdSmmVariableEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSoftwareGuardEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSsaFlagEnable|FALSE
-  gSiPkgTokenSpaceGuid.PcdUseHpetTimer|TRUE                       # TRUE - HPET / FALSE - 8254 timer is used.
   gSiPkgTokenSpaceGuid.PcdOcWdtEnable|TRUE
   gSiPkgTokenSpaceGuid.PcdSiCatalogDebugEnable|FALSE
 
-- 
2.12.0.windows.1

[edk2-platforms/devel-MinPlatform][PATCH v1 4/6] KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD

[Wu, Hao A]

For KabylakeRvp3, none of its consumed modules is using the PCD:
gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask

Thus, this commit will remove the PCD consumption in the DSC file.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
index 35f383ecef..51d4e2ea46 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
@@ -1,7 +1,7 @@
 ## @file
 #  Platform description.
 #
-# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
 #
 # This program and the accompanying materials are licensed and made available under
 # the terms and conditions of the BSD License which accompanies this distribution.
@@ -194,9 +194,6 @@ [PcdsFixedAtBuild.IA32]
   gIntelFsp2WrapperTokenSpaceGuid.PcdPeiMinMemSize|0x3800000
 
 [PcdsFixedAtBuild.X64]
-  gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask|0x0eB8
-
-
   # Default platform supported RFC 4646 languages: (American) English
   gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes|"en-US"
 
-- 
2.12.0.windows.1

[edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'

[Wu, Hao A]

For platforms under KabylakeOpenBoardPkg & ClevoOpenBoardPkg, both of them
are using the HPET timer unconditionally. The PCD 'PcdUseHpetTimer' is not
being used.

This commit will remove the above PCD within KabylakeSiliconPkg.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec              | 3 +--
 Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
index 92b6d492ee..cca1a2e60d 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
+++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
@@ -1,7 +1,7 @@
 ## @file
 # Component description file for the Silicon Reference Code.
 #
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
 #
 # This program and the accompanying materials are licensed and made available under
 # the terms and conditions of the BSD License which accompanies this distribution.
@@ -592,7 +592,6 @@ [PcdsFeatureFlag]
 gSiPkgTokenSpaceGuid.PcdSerialGpioEnable             |FALSE|BOOLEAN|0xF0000003
 gSiPkgTokenSpaceGuid.PcdAtaEnable                    |FALSE|BOOLEAN|0xF0000004
 gSiPkgTokenSpaceGuid.PcdSiCsmEnable                  |FALSE|BOOLEAN|0xF0000005
-gSiPkgTokenSpaceGuid.PcdUseHpetTimer                 |FALSE|BOOLEAN|0xF0000006
 gSiPkgTokenSpaceGuid.PcdSgEnable                     |TRUE |BOOLEAN|0xF0000008
 gSiPkgTokenSpaceGuid.PcdAcpiEnable                   |TRUE |BOOLEAN|0xF0000009
 gSiPkgTokenSpaceGuid.PcdSourceDebugEnable            |FALSE|BOOLEAN|0xF000000B
diff --git a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
index 7189ce6396..cbb2a8bec4 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
+++ b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
@@ -1,7 +1,7 @@
 ## @file
 #  Component description file for the SkyLake SiPkg DSC file.
 #
-# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
 #
 # This program and the accompanying materials are licensed and made available under
 # the terms and conditions of the BSD License which accompanies this distribution.
@@ -19,7 +19,6 @@ [PcdsFeatureFlag]
 gSiPkgTokenSpaceGuid.PcdSerialGpioEnable             |FALSE
 gSiPkgTokenSpaceGuid.PcdAtaEnable                    |FALSE
 gSiPkgTokenSpaceGuid.PcdSiCsmEnable                  |FALSE
-gSiPkgTokenSpaceGuid.PcdUseHpetTimer                 |FALSE
 gSiPkgTokenSpaceGuid.PcdSgEnable                     |TRUE
 gSiPkgTokenSpaceGuid.PcdAcpiEnable                   |FALSE
 gSiPkgTokenSpaceGuid.PcdSourceDebugEnable            |FALSE
-- 
2.12.0.windows.1

[edk2-platforms/devel-MinPlatform][PATCH v1 6/6] KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID

[Wu, Hao A]

For modules consumed by platforms within KabylakeOpenBoardPkg &
ClevoOpenBoardPkg, none of them has the dependency on the Legacy8259
protocol. Thus, this commit will remove the duplicated Legacy8259 protocol
GUID within file SiPkg.dec.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
index cca1a2e60d..078d10c520 100644
--- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
+++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
@@ -268,7 +268,6 @@ [Protocols]
 ##
 gEfiLegacyBiosProtocolGuid  =  {0xdb9a1e3d, 0x45cb, 0x4abb, {0x85, 0x3b, 0xe5, 0x38, 0x7f, 0xdb, 0x2e, 0x2d}}
 gEfiLegacyInterruptProtocolGuid  =  {0x31ce593d, 0x108a, 0x485d, {0xad, 0xb2, 0x78, 0xf2, 0x1f, 0x29, 0x66, 0xbe}}
-gEfiLegacy8259ProtocolGuid  =  {0x38321dba, 0x4fe0, 0x4e17, {0x8a, 0xec, 0x41, 0x30, 0x55, 0xea, 0xed, 0xc1}}
 gEfiDataHubProtocolGuid  =  {0xae80d021, 0x618e, 0x11d4, {0xbc, 0xd7, 0x00, 0x80, 0xc7, 0x3c, 0x88, 0x81}}
 ##
 ## MdeModulePkg
-- 
2.12.0.windows.1

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 0/6] Some cleanup for platforms under ClevoOpenBoardPkg & KabylakeOpenBoardPkg

[Kubacki, Michael A]

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Wednesday, April 3, 2019 10:57 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Sinha, Ankit <ankit.sinha@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 0/6]
> Some cleanup for platforms under ClevoOpenBoardPkg &
> KabylakeOpenBoardPkg
> 
> The series will do the below cleanups for platforms under
> ClevoOpenBoardPkg and KabylakeOpenBoardPkg:
> 
> A) Remove unused PCD 'PcdUseHpetTimer';
> B) Remove the unnecessary consumption of the 8259-related PCDs;
> C) Remove the unused duplicated Legacy8259 protocol GUID.
> 
> 
> Test done for the series:
> Build pass for N1xxWU & KabyLakeRvp3 platforms.
> 
> Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Hao Wu (6):
>   ClevoOpenBoardPkg/N1xxWU: Remove unused PCD 'PcdUseHpetTimer'
>   ClevoOpenBoardPkg/N1xxWU: Remove the consume of 8259-related PCD
>   KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'
>   KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related
> PCD
>   KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'
>   KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID
> 
>  Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec                              | 4 +---
>  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc
> | 1 -
>  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc
> | 2 --
> 
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.
> dsc | 3 +--
> 
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds
> c    | 5 +----
>  Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc                 | 3 +--
>  6 files changed, 4 insertions(+), 14 deletions(-)
> 
> --
> 2.12.0.windows.1
> 
> 
> 

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'

[chasel.chiu]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]

Reviewed-by: Chasel Chiu < chasel.chiu@intel.com >

[-- Attachment #2: Type: text/html, Size: 218 bytes --]

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'

[chasel.chiu]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]

Reviewed-by: Chasel Chiu < chasel.chiu@intel.com >

[-- Attachment #2: Type: text/html, Size: 218 bytes --]

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 6/6] KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID

[chasel.chiu]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]

Reviewed-by: Chasel Chiu < chasel.chiu@intel.com >

[-- Attachment #2: Type: text/html, Size: 218 bytes --]

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 4/6] KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD

[chasel.chiu]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]

Reviewed-by: Chasel Chiu < chasel.chiu@intel.com >

[-- Attachment #2: Type: text/html, Size: 218 bytes --]

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 2/6] ClevoOpenBoardPkg/N1xxWU: Remove the consume of 8259-related PCD

[chasel.chiu]

[-- Attachment #1: Type: text/plain, Size: 52 bytes --]

Reviewed-by: Chasel Chiu < chasel.chiu@intel.com >

[-- Attachment #2: Type: text/html, Size: 218 bytes --]

Re: [edk2-platforms/devel-MinPlatform][PATCH v1 3/6] KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, April 4, 2019 1:57 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Kubacki, Michael A <michael.a.kubacki@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 3/6]
> KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'
> 
> For KabylakeRvp3, it is using the HPET timer unconditionally. The PCD
> 'PcdUseHpetTimer' is not being used.
> 
> This commit will remove the usage of the above PCD in package DSC files.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
> 
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig.d
> sc | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig
> .dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig
> .dsc
> index bb06ff5a2a..f3d082ce41 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig
> .dsc
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfi
> +++ g.dsc
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Platform configuration file.
>  #
> -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made available
> under  # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -111,7 +111,6 @@ [PcdsFeatureFlag]
>    gSiPkgTokenSpaceGuid.PcdSmmVariableEnable|TRUE
>    gSiPkgTokenSpaceGuid.PcdSoftwareGuardEnable|TRUE
>    gSiPkgTokenSpaceGuid.PcdSsaFlagEnable|FALSE
> -  gSiPkgTokenSpaceGuid.PcdUseHpetTimer|TRUE                       # TRUE -
> HPET / FALSE - 8254 timer is used.
>    gSiPkgTokenSpaceGuid.PcdOcWdtEnable|TRUE
>    gSiPkgTokenSpaceGuid.PcdSiCatalogDebugEnable|FALSE
> 
> --
> 2.12.0.windows.1

Re: [edk2-platforms/devel-MinPlatform][PATCH v1 4/6] KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, April 4, 2019 1:57 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Kubacki, Michael A <michael.a.kubacki@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 4/6]
> KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related PCD
> 
> For KabylakeRvp3, none of its consumed modules is using the PCD:
> gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask
> 
> Thus, this commit will remove the PCD consumption in the DSC file.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
> | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds
> c
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds
> c
> index 35f383ecef..51d4e2ea46 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds
> c
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d
> +++ sc
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Platform description.
>  #
> -# Copyright (c) 2017 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made available
> under  # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -194,9 +194,6 @@ [PcdsFixedAtBuild.IA32]
>    gIntelFsp2WrapperTokenSpaceGuid.PcdPeiMinMemSize|0x3800000
> 
>  [PcdsFixedAtBuild.X64]
> -  gPcAtChipsetPkgTokenSpaceGuid.Pcd8259LegacyModeMask|0x0eB8
> -
> -
>    # Default platform supported RFC 4646 languages: (American) English
> 
> gEfiMdePkgTokenSpaceGuid.PcdUefiVariableDefaultPlatformLangCodes|"en-U
> S"
> 
> --
> 2.12.0.windows.1

Re: [edk2-platforms/devel-MinPlatform][PATCH v1 6/6] KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, April 4, 2019 1:57 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Kubacki, Michael A <michael.a.kubacki@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 6/6]
> KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID
> 
> For modules consumed by platforms within KabylakeOpenBoardPkg &
> ClevoOpenBoardPkg, none of them has the dependency on the Legacy8259
> protocol. Thus, this commit will remove the duplicated Legacy8259 protocol
> GUID within file SiPkg.dec.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> index cca1a2e60d..078d10c520 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> @@ -268,7 +268,6 @@ [Protocols]
>  ##
>  gEfiLegacyBiosProtocolGuid  =  {0xdb9a1e3d, 0x45cb, 0x4abb, {0x85, 0x3b,
> 0xe5, 0x38, 0x7f, 0xdb, 0x2e, 0x2d}}  gEfiLegacyInterruptProtocolGuid  =
> {0x31ce593d, 0x108a, 0x485d, {0xad, 0xb2, 0x78, 0xf2, 0x1f, 0x29, 0x66, 0xbe}}
> -gEfiLegacy8259ProtocolGuid  =  {0x38321dba, 0x4fe0, 0x4e17, {0x8a, 0xec,
> 0x41, 0x30, 0x55, 0xea, 0xed, 0xc1}}  gEfiDataHubProtocolGuid  =  {0xae80d021,
> 0x618e, 0x11d4, {0xbc, 0xd7, 0x00, 0x80, 0xc7, 0x3c, 0x88, 0x81}}  ##  ##
> MdeModulePkg
> --
> 2.12.0.windows.1

Re: [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>


> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, April 4, 2019 1:57 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Kubacki, Michael A <michael.a.kubacki@intel.com>
> Subject: [edk2-platforms/devel-MinPlatform][PATCH v1 5/6] KabylakeSiliconPkg:
> Remove unused PCD 'PcdUseHpetTimer'
> 
> For platforms under KabylakeOpenBoardPkg & ClevoOpenBoardPkg, both of
> them are using the HPET timer unconditionally. The PCD 'PcdUseHpetTimer' is
> not being used.
> 
> This commit will remove the above PCD within KabylakeSiliconPkg.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec              | 3 +--
>  Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> index 92b6d492ee..cca1a2e60d 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> +++ b/Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec
> @@ -1,7 +1,7 @@
>  ## @file
>  # Component description file for the Silicon Reference Code.
>  #
> -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made available
> under  # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -592,7 +592,6 @@ [PcdsFeatureFlag]
>  gSiPkgTokenSpaceGuid.PcdSerialGpioEnable
> |FALSE|BOOLEAN|0xF0000003
>  gSiPkgTokenSpaceGuid.PcdAtaEnable
> |FALSE|BOOLEAN|0xF0000004
>  gSiPkgTokenSpaceGuid.PcdSiCsmEnable
> |FALSE|BOOLEAN|0xF0000005
> -gSiPkgTokenSpaceGuid.PcdUseHpetTimer
> |FALSE|BOOLEAN|0xF0000006
>  gSiPkgTokenSpaceGuid.PcdSgEnable                     |TRUE
> |BOOLEAN|0xF0000008
>  gSiPkgTokenSpaceGuid.PcdAcpiEnable                   |TRUE
> |BOOLEAN|0xF0000009
>  gSiPkgTokenSpaceGuid.PcdSourceDebugEnable
> |FALSE|BOOLEAN|0xF000000B
> diff --git a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
> b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
> index 7189ce6396..cbb2a8bec4 100644
> --- a/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
> +++ b/Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Component description file for the SkyLake SiPkg DSC file.
>  #
> -# Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2017 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # This program and the accompanying materials are licensed and made available
> under  # the terms and conditions of the BSD License which accompanies this
> distribution.
> @@ -19,7 +19,6 @@ [PcdsFeatureFlag]
>  gSiPkgTokenSpaceGuid.PcdSerialGpioEnable             |FALSE
>  gSiPkgTokenSpaceGuid.PcdAtaEnable                    |FALSE
>  gSiPkgTokenSpaceGuid.PcdSiCsmEnable                  |FALSE
> -gSiPkgTokenSpaceGuid.PcdUseHpetTimer                 |FALSE
>  gSiPkgTokenSpaceGuid.PcdSgEnable                     |TRUE
>  gSiPkgTokenSpaceGuid.PcdAcpiEnable                   |FALSE
>  gSiPkgTokenSpaceGuid.PcdSourceDebugEnable            |FALSE
> --
> 2.12.0.windows.1

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 0/6] Some cleanup for platforms under ClevoOpenBoardPkg & KabylakeOpenBoardPkg

[Wu, Hao A]

Michael and Chasel,

Thanks for the review.
The series has been pushed at:
a496938e7b..889da83ddf (devel-MinPlatform branch)

Best Regards,
Hao Wu


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Thursday, April 04, 2019 1:57 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Kubacki, Michael A; Chiu, Chasel; Sinha, Ankit; Desimone,
> Nathaniel L
> Subject: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH v1 0/6]
> Some cleanup for platforms under ClevoOpenBoardPkg &
> KabylakeOpenBoardPkg
> 
> The series will do the below cleanups for platforms under
> ClevoOpenBoardPkg and KabylakeOpenBoardPkg:
> 
> A) Remove unused PCD 'PcdUseHpetTimer';
> B) Remove the unnecessary consumption of the 8259-related PCDs;
> C) Remove the unused duplicated Legacy8259 protocol GUID.
> 
> 
> Test done for the series:
> Build pass for N1xxWU & KabyLakeRvp3 platforms.
> 
> Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> Hao Wu (6):
>   ClevoOpenBoardPkg/N1xxWU: Remove unused PCD 'PcdUseHpetTimer'
>   ClevoOpenBoardPkg/N1xxWU: Remove the consume of 8259-related PCD
>   KabylakeOpenBoardPkg/KBLRvp3: Remove unused PCD 'PcdUseHpetTimer'
>   KabylakeOpenBoardPkg/KBLRvp3: Remove the consume of 8259-related
> PCD
>   KabylakeSiliconPkg: Remove unused PCD 'PcdUseHpetTimer'
>   KabylakeSiliconPkg/SiPkg.dec: Remove Legacy8259 protocol GUID
> 
>  Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec                              | 4 +---
>  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc
> | 1 -
>  Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgPcd.dsc
> | 2 --
> 
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgConfig
> .dsc | 3 +--
> 
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds
> c    | 5 +----
>  Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc                 | 3 +--
>  6 files changed, 4 insertions(+), 14 deletions(-)
> 
> --
> 2.12.0.windows.1
> 
> 
>