public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Gao, Zhichao" <zhichao.gao@intel.com>
Cc: "Piwko, Maciej" <maciej.piwko@intel.com>,
	"Piwko, Maciej" <maciej.piwko@intel.com>,
	"Bu, Daocheng" <daocheng.bu@intel.com>,
	"Oram, Isaac W" <isaac.w.oram@intel.com>,
	"Chiu, Chasel" <chasel.chiu@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 0/5] Add a new API ResetSystem for ResetSystemLib instances
Date: Tue, 16 Apr 2019 02:00:41 +0000	[thread overview]
Message-ID: <49AB4ACB9627B8468F29D589A27B7455888C15C6@ORSMSX122.amr.corp.intel.com> (raw)
In-Reply-To: <20190415030739.14328-1-zhichao.gao@intel.com>

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,
> Zhichao
> Sent: Sunday, April 14, 2019 8:08 PM
> To: devel@edk2.groups.io
> Cc: Piwko; Piwko, Maciej <maciej.piwko@intel.com>; Bu; Bu, Daocheng
> <daocheng.bu@intel.com>; Oram; Oram, Isaac W <isaac.w.oram@intel.com>;
> Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [edk2-platforms/devel-MinPlatform][PATCH 0/5] Add a
> new API ResetSystem for ResetSystemLib instances
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
> 
> Add a new API ResetSystem to this ResetSystemLib instance.
> It only adds the basic functions from ResetSystemRuntimeDxe.
> Lacking of this interface may cause link error, if some drivers use this new API
> and link to this library instance.
> Make the ResetPlatformSpecific's parameters same with the interface in Edk2
> repo.
> Notes:
> This library API only provide a basic function of reset. If the consumers want full
> functions, they should use the instance in the MdeModulePkg and make sure
> the depex driver is dispatched.
> 
> Cc: Piwko, Maciej <maciej.piwko@intel.com>
> Cc: Bu, Daocheng <daocheng.bu@intel.com>
> Cc: Oram, Isaac W <isaac.w.oram@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael A Kubacki <michael.a.kubacki@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> 
> Zhichao Gao (5):
>   KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem
>   KabylakeSiliconPkg/DxeResetSystemLib: Add a new API ResetSystem
>   LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem
>   KabylakeSiliconPkg/PeiResetSystemLib: Add a new API ResetSystem
>   KabylakeSiliconPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem
> 
>  .../BaseResetSystemLib/BaseResetSystemLib.c   | 47 +++++++++++++++++--
>  .../DxeResetSystemLib/DxeResetSystemLib.c     | 47 +++++++++++++++++--
>  .../DxeRuntimeResetSystemLib.c                | 47 +++++++++++++++++--
>  .../Pch/Library/PeiPchResetLib/PchReset.c     |  7 ++-
>  .../PeiResetSystemLib/PeiResetSystemLib.c     | 47 +++++++++++++++++--
>  .../DxeRuntimeResetSystemLib/PchReset.c       | 47 +++++++++++++++++--
>  6 files changed, 223 insertions(+), 19 deletions(-)
> 
> --
> 2.21.0.windows.1
> 
> 
> 


      parent reply	other threads:[~2019-04-16  2:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15  3:07 [edk2-platforms/devel-MinPlatform][PATCH 0/5] Add a new API ResetSystem for ResetSystemLib instances Gao, Zhichao
2019-04-15  3:07 ` [edk2-platforms/devel-MinPlatform][PATCH 1/5] KabylakeSiliconPkg/BaseResetSystemLib: Add a new API ResetSystem Gao, Zhichao
2019-04-15  9:03   ` Chiu, Chasel
2019-04-15 22:44     ` Gao, Zhichao
2019-04-16  1:54   ` Chiu, Chasel
2019-04-15  3:07 ` [edk2-platforms PATCH] Platform/ResetSystemLib: " Gao, Zhichao
2019-04-15 10:16   ` Leif Lindholm
2019-04-15  3:07 ` [edk2-platforms/devel-MinPlatform][PATCH 2/5] KabylakeSiliconPkg/DxeResetSystemLib: " Gao, Zhichao
2019-04-16  1:55   ` Chiu, Chasel
2019-04-15  3:07 ` [edk2-platforms/devel-MinPlatform][PATCH 3/5] LewisburgPkg/DxeRuntimeResetSystemLib: " Gao, Zhichao
2019-04-15  7:55   ` Bu, Daocheng
2019-04-22  2:49     ` Gao, Zhichao
2019-04-24 13:45       ` Piwko, Maciej
2019-04-24 14:27         ` Kwolek, Adam
2019-04-15  3:07 ` [edk2-platforms/devel-MinPlatform][PATCH 4/5] KabylakeSiliconPkg/PeiResetSystemLib: " Gao, Zhichao
2019-04-16  1:55   ` Chiu, Chasel
2019-04-15  3:07 ` [edk2-platforms/devel-MinPlatform][PATCH 5/5] KabylakeSiliconPkg/DxeRuntimeResetSystemLib: " Gao, Zhichao
2019-04-16  2:00 ` Kubacki, Michael A [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AB4ACB9627B8468F29D589A27B7455888C15C6@ORSMSX122.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox