Re: [edk2-devel] [Patch V3 3/8] QuarkPlatformPkg: Set PcdSpeculationBarrierType to CPUID

["Kubacki, Michael A" <michael.a.kubacki@intel.com>]

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Tuesday, April 30, 2019 12:31 PM
> To: devel@edk2.groups.io
> Cc: Steele, Kelly <kelly.steele@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [edk2-devel] [Patch V3 3/8] QuarkPlatformPkg: Set
> PcdSpeculationBarrierType to CPUID
> 
> Set PcdSpeculationBarrierType to use CPUID instead of the default LFENCE in
> the BaseLib function SpeculationBarrier().
> LFENCE requires SSE2, and Quark platforms do not support SSE2.
> 
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  QuarkPlatformPkg/Quark.dsc    | 7 ++++++-
>  QuarkPlatformPkg/QuarkMin.dsc | 5 +++++
>  2 files changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/QuarkPlatformPkg/Quark.dsc b/QuarkPlatformPkg/Quark.dsc
> index 422fd9cf8d..96ddc1565a 100644
> --- a/QuarkPlatformPkg/Quark.dsc
> +++ b/QuarkPlatformPkg/Quark.dsc
> @@ -2,7 +2,7 @@
>  # Clanton Peak CRB platform with 32-bit DXE for 4MB/8MB flash devices.
>  #
>  # This package provides Clanton Peak CRB platform specific modules.
> -# Copyright (c) 2013 - 2018 Intel Corporation.
> +# Copyright (c) 2013 - 2019 Intel Corporation.
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -448,6 +448,11 @@
> [PcdsFixedAtBuild]
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName|L"QUARKREC.Ca
> p"
>  !endif
> 
> +  #
> +  # Quark does not support LFENCE.  Use CPUID as speculation barrier  #
> +  gEfiMdePkgTokenSpaceGuid.PcdSpeculationBarrierType|0x02
> +
>  [PcdsPatchableInModule]
>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x803000C7
>    gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0
> diff --git a/QuarkPlatformPkg/QuarkMin.dsc
> b/QuarkPlatformPkg/QuarkMin.dsc index 00e2febb54..8ca75bc474 100644
> --- a/QuarkPlatformPkg/QuarkMin.dsc
> +++ b/QuarkPlatformPkg/QuarkMin.dsc
> @@ -406,6 +406,11 @@ [PcdsFixedAtBuild]
> 
>    gEfiMdeModulePkgTokenSpaceGuid.PcdConInConnectOnDemand|FALSE
> 
> +  #
> +  # Quark does not support LFENCE.  Use CPUID as speculation barrier  #
> +  gEfiMdePkgTokenSpaceGuid.PcdSpeculationBarrierType|0x02
> +
>  [PcdsPatchableInModule]
>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x803000C7
>    gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0
> --
> 2.21.0.windows.1
> 
> 
>