From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: michael.a.kubacki@intel.com)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by groups.io with SMTP; Tue, 30 Apr 2019 14:25:37 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
  by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Apr 2019 14:25:37 -0700
X-ExtLoop1: 1
Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132])
  by orsmga002.jf.intel.com with ESMTP; 30 Apr 2019 14:25:36 -0700
Received: from orsmsx122.amr.corp.intel.com ([169.254.11.68]) by
 ORSMSX105.amr.corp.intel.com ([169.254.2.167]) with mapi id 14.03.0415.000;
 Tue, 30 Apr 2019 14:25:36 -0700
From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Kinney, Michael D"
	<michael.d.kinney@intel.com>
CC: "Steele, Kelly" <kelly.steele@intel.com>, "Gao, Liming"
	<liming.gao@intel.com>
Subject: Re: [edk2-devel] [Patch V3 3/8] QuarkPlatformPkg: Set PcdSpeculationBarrierType to CPUID
Thread-Topic: [edk2-devel] [Patch V3 3/8] QuarkPlatformPkg: Set
 PcdSpeculationBarrierType to CPUID
Thread-Index: AQHU/4tOHHQrHJ1130ikm+xVzdxoF6ZVNXCg
Date: Tue, 30 Apr 2019 21:25:35 +0000
Message-ID: <49AB4ACB9627B8468F29D589A27B7455888E0FE8@ORSMSX122.amr.corp.intel.com>
References: <20190430193108.8544-1-michael.d.kinney@intel.com>
 <20190430193108.8544-4-michael.d.kinney@intel.com>
In-Reply-To: <20190430193108.8544-4-michael.d.kinney@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiN2RhOGI5YmMtMmY1OC00NzRjLThmZmUtMDE3MDUwYjMxY2M2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVk5oK1hnUzkyZlplVUxTZms4djdcL2tcL0NFWjBoXC9DYXorVzJPU1dLMG5xaHErWCsyR1RaR0dqNHppRjZOM0JvNiJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.22.254.138]
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Tuesday, April 30, 2019 12:31 PM
> To: devel@edk2.groups.io
> Cc: Steele, Kelly <kelly.steele@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> Subject: [edk2-devel] [Patch V3 3/8] QuarkPlatformPkg: Set
> PcdSpeculationBarrierType to CPUID
>=20
> Set PcdSpeculationBarrierType to use CPUID instead of the default LFENCE=
 in
> the BaseLib function SpeculationBarrier().
> LFENCE requires SSE2, and Quark platforms do not support SSE2.
>=20
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  QuarkPlatformPkg/Quark.dsc    | 7 ++++++-
>  QuarkPlatformPkg/QuarkMin.dsc | 5 +++++
>  2 files changed, 11 insertions(+), 1 deletion(-)
>=20
> diff --git a/QuarkPlatformPkg/Quark.dsc b/QuarkPlatformPkg/Quark.dsc
> index 422fd9cf8d..96ddc1565a 100644
> --- a/QuarkPlatformPkg/Quark.dsc
> +++ b/QuarkPlatformPkg/Quark.dsc
> @@ -2,7 +2,7 @@
>  # Clanton Peak CRB platform with 32-bit DXE for 4MB/8MB flash devices.
>  #
>  # This package provides Clanton Peak CRB platform specific modules.
> -# Copyright (c) 2013 - 2018 Intel Corporation.
> +# Copyright (c) 2013 - 2019 Intel Corporation.
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -448,6 +448,11 @@
> [PcdsFixedAtBuild]
>=20
> gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName|L"QUARKREC.Ca
> p"
>  !endif
>=20
> +  #
> +  # Quark does not support LFENCE.  Use CPUID as speculation barrier  #
> +  gEfiMdePkgTokenSpaceGuid.PcdSpeculationBarrierType|0x02
> +
>  [PcdsPatchableInModule]
>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x803000C7
>    gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0
> diff --git a/QuarkPlatformPkg/QuarkMin.dsc
> b/QuarkPlatformPkg/QuarkMin.dsc index 00e2febb54..8ca75bc474 100644
> --- a/QuarkPlatformPkg/QuarkMin.dsc
> +++ b/QuarkPlatformPkg/QuarkMin.dsc
> @@ -406,6 +406,11 @@ [PcdsFixedAtBuild]
>=20
>    gEfiMdeModulePkgTokenSpaceGuid.PcdConInConnectOnDemand|FALSE
>=20
> +  #
> +  # Quark does not support LFENCE.  Use CPUID as speculation barrier  #
> +  gEfiMdePkgTokenSpaceGuid.PcdSpeculationBarrierType|0x02
> +
>  [PcdsPatchableInModule]
>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x803000C7
>    gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0
> --
> 2.21.0.windows.1
>=20
>=20
>=20