From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch
Date: Fri, 10 May 2019 02:47:01 +0000 [thread overview]
Message-ID: <49AB4ACB9627B8468F29D589A27B7455888F441E@ORSMSX122.amr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4455D4@SHSMSX104.ccr.corp.intel.com>
Liming, I have no concern with the plan. I've noticed authors change
In a few recent commits on master_minplatform, I'd prefer they stay
consistent if possible.
Thanks,
Michael
> -----Original Message-----
> From: Gao, Liming
> Sent: Wednesday, May 8, 2019 8:31 PM
> To: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: edk2-devel-groups-io <devel@edk2.groups.io>;
> ard.biesheuvel@linaro.org; Kinney, Michael D
> <michael.d.kinney@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>
> Subject: RE: [Patch][edk2-platform] Migrate devel-MinPlatform branch to
> master branch
>
> Hi, all
> I don't get the rejection on this change. Leif gives some comments. They
> don't block this migration. They can be resolved after this migration.
>
> Today, I update https://github.com/lgao4/edk2-
> platforms/tree/master_minplatform based on the latest edk2 platform
> master and devel-MinPlatform branch. Please help review and see what's
> missing. I plan to push this migration on May 13th. After this migration, I will
> send the announcement of the migration done. edk2-platform devel-
> MinPlatform branch will be kept as read only. The change will go into edk2-
> plaform master.
>
> Thanks
> Liming
> > -----Original Message-----
> > From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> > Sent: Thursday, May 2, 2019 10:35 PM
> > To: Gao, Liming <liming.gao@intel.com>
> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>;
> > ard.biesheuvel@linaro.org; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Kubacki, Michael A
> > <michael.a.kubacki@intel.com>
> > Subject: Re: [Patch][edk2-platform] Migrate devel-MinPlatform branch
> > to master branch
> >
> > On Thu, Apr 25, 2019 at 01:08:33PM +0000, Gao, Liming wrote:
> > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1748
> > >
> > > There is no objection on the RFC
> > > https://edk2.groups.io/g/devel/topic/31236064#39516
> > > to migrate devel-MinPlatform branch to master branch.
> >
> > Ah, I had completely missed that one due to not being on cc.
> > I do have a few comments, but I'll make those on the original email.
> >
> > > This patch moves all patches in devel-MinPlatform branch to master
> branch.
> > > Here is the migrated code
> > > https://github.com/lgao4/edk2-platforms/tree/master_minplatform
> > > based on today history. All histories in devel-MinPlatform and master
> branches are kept.
> > > After this migration, the developer will check all the codes in
> > > edk2-platform master when he does the incompatible change in edk2
> project. He doesn't need to check other branches.
> >
> > This is certainly an improvement.
> >
> > /
> > Leif
> >
> > > When this patch submit, I will rebase master with the latest change
> > > in master and devel-MinPlatform.
> > >
> > > Signed-off-by: Liming Gao
> > > <liming.gao@intel.com<mailto:liming.gao@intel.com>>
next prev parent reply other threads:[~2019-05-10 2:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 13:08 [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch Liming Gao
2019-05-02 14:35 ` Leif Lindholm
2019-05-09 3:31 ` Liming Gao
2019-05-10 2:47 ` Kubacki, Michael A [this message]
2019-05-10 3:23 ` Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AB4ACB9627B8468F29D589A27B7455888F441E@ORSMSX122.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox