* [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch @ 2019-04-25 13:08 Liming Gao 2019-05-02 14:35 ` Leif Lindholm 0 siblings, 1 reply; 5+ messages in thread From: Liming Gao @ 2019-04-25 13:08 UTC (permalink / raw) To: edk2-devel-groups-io Cc: ard.biesheuvel@linaro.org, leif.lindholm@linaro.org, Kinney, Michael D, Kubacki, Michael A [-- Attachment #1: Type: text/plain, Size: 830 bytes --] BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1748 There is no objection on the RFC https://edk2.groups.io/g/devel/topic/31236064#39516 to migrate devel-MinPlatform branch to master branch. This patch moves all patches in devel-MinPlatform branch to master branch. Here is the migrated code https://github.com/lgao4/edk2-platforms/tree/master_minplatform based on today history. All histories in devel-MinPlatform and master branches are kept. After this migration, the developer will check all the codes in edk2-platform master when he does the incompatible change in edk2 project. He doesn't need to check other branches. When this patch submit, I will rebase master with the latest change in master and devel-MinPlatform. Signed-off-by: Liming Gao <liming.gao@intel.com<mailto:liming.gao@intel.com>> [-- Attachment #2: Type: text/html, Size: 4274 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch 2019-04-25 13:08 [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch Liming Gao @ 2019-05-02 14:35 ` Leif Lindholm 2019-05-09 3:31 ` Liming Gao 0 siblings, 1 reply; 5+ messages in thread From: Leif Lindholm @ 2019-05-02 14:35 UTC (permalink / raw) To: Gao, Liming Cc: edk2-devel-groups-io, ard.biesheuvel@linaro.org, Kinney, Michael D, Kubacki, Michael A On Thu, Apr 25, 2019 at 01:08:33PM +0000, Gao, Liming wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1748 > > There is no objection on the RFC https://edk2.groups.io/g/devel/topic/31236064#39516 > to migrate devel-MinPlatform branch to master branch. Ah, I had completely missed that one due to not being on cc. I do have a few comments, but I'll make those on the original email. > This patch moves all patches in devel-MinPlatform branch to master branch. > Here is the migrated code https://github.com/lgao4/edk2-platforms/tree/master_minplatform > based on today history. All histories in devel-MinPlatform and master branches are kept. > After this migration, the developer will check all the codes in edk2-platform master when > he does the incompatible change in edk2 project. He doesn't need to check other branches. This is certainly an improvement. / Leif > When this patch submit, I will rebase master with the latest change > in master and devel-MinPlatform. > > Signed-off-by: Liming Gao <liming.gao@intel.com<mailto:liming.gao@intel.com>> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch 2019-05-02 14:35 ` Leif Lindholm @ 2019-05-09 3:31 ` Liming Gao 2019-05-10 2:47 ` Kubacki, Michael A 0 siblings, 1 reply; 5+ messages in thread From: Liming Gao @ 2019-05-09 3:31 UTC (permalink / raw) To: Leif Lindholm Cc: edk2-devel-groups-io, ard.biesheuvel@linaro.org, Kinney, Michael D, Kubacki, Michael A Hi, all I don't get the rejection on this change. Leif gives some comments. They don't block this migration. They can be resolved after this migration. Today, I update https://github.com/lgao4/edk2-platforms/tree/master_minplatform based on the latest edk2 platform master and devel-MinPlatform branch. Please help review and see what's missing. I plan to push this migration on May 13th. After this migration, I will send the announcement of the migration done. edk2-platform devel-MinPlatform branch will be kept as read only. The change will go into edk2-plaform master. Thanks Liming > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Thursday, May 2, 2019 10:35 PM > To: Gao, Liming <liming.gao@intel.com> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; ard.biesheuvel@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com>; Kubacki, > Michael A <michael.a.kubacki@intel.com> > Subject: Re: [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch > > On Thu, Apr 25, 2019 at 01:08:33PM +0000, Gao, Liming wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1748 > > > > There is no objection on the RFC https://edk2.groups.io/g/devel/topic/31236064#39516 > > to migrate devel-MinPlatform branch to master branch. > > Ah, I had completely missed that one due to not being on cc. > I do have a few comments, but I'll make those on the original email. > > > This patch moves all patches in devel-MinPlatform branch to master branch. > > Here is the migrated code https://github.com/lgao4/edk2-platforms/tree/master_minplatform > > based on today history. All histories in devel-MinPlatform and master branches are kept. > > After this migration, the developer will check all the codes in edk2-platform master when > > he does the incompatible change in edk2 project. He doesn't need to check other branches. > > This is certainly an improvement. > > / > Leif > > > When this patch submit, I will rebase master with the latest change > > in master and devel-MinPlatform. > > > > Signed-off-by: Liming Gao <liming.gao@intel.com<mailto:liming.gao@intel.com>> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch 2019-05-09 3:31 ` Liming Gao @ 2019-05-10 2:47 ` Kubacki, Michael A 2019-05-10 3:23 ` Liming Gao 0 siblings, 1 reply; 5+ messages in thread From: Kubacki, Michael A @ 2019-05-10 2:47 UTC (permalink / raw) To: Gao, Liming, Leif Lindholm Cc: edk2-devel-groups-io, ard.biesheuvel@linaro.org, Kinney, Michael D Liming, I have no concern with the plan. I've noticed authors change In a few recent commits on master_minplatform, I'd prefer they stay consistent if possible. Thanks, Michael > -----Original Message----- > From: Gao, Liming > Sent: Wednesday, May 8, 2019 8:31 PM > To: Leif Lindholm <leif.lindholm@linaro.org> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; > ard.biesheuvel@linaro.org; Kinney, Michael D > <michael.d.kinney@intel.com>; Kubacki, Michael A > <michael.a.kubacki@intel.com> > Subject: RE: [Patch][edk2-platform] Migrate devel-MinPlatform branch to > master branch > > Hi, all > I don't get the rejection on this change. Leif gives some comments. They > don't block this migration. They can be resolved after this migration. > > Today, I update https://github.com/lgao4/edk2- > platforms/tree/master_minplatform based on the latest edk2 platform > master and devel-MinPlatform branch. Please help review and see what's > missing. I plan to push this migration on May 13th. After this migration, I will > send the announcement of the migration done. edk2-platform devel- > MinPlatform branch will be kept as read only. The change will go into edk2- > plaform master. > > Thanks > Liming > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Thursday, May 2, 2019 10:35 PM > > To: Gao, Liming <liming.gao@intel.com> > > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; > > ard.biesheuvel@linaro.org; Kinney, Michael D > > <michael.d.kinney@intel.com>; Kubacki, Michael A > > <michael.a.kubacki@intel.com> > > Subject: Re: [Patch][edk2-platform] Migrate devel-MinPlatform branch > > to master branch > > > > On Thu, Apr 25, 2019 at 01:08:33PM +0000, Gao, Liming wrote: > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1748 > > > > > > There is no objection on the RFC > > > https://edk2.groups.io/g/devel/topic/31236064#39516 > > > to migrate devel-MinPlatform branch to master branch. > > > > Ah, I had completely missed that one due to not being on cc. > > I do have a few comments, but I'll make those on the original email. > > > > > This patch moves all patches in devel-MinPlatform branch to master > branch. > > > Here is the migrated code > > > https://github.com/lgao4/edk2-platforms/tree/master_minplatform > > > based on today history. All histories in devel-MinPlatform and master > branches are kept. > > > After this migration, the developer will check all the codes in > > > edk2-platform master when he does the incompatible change in edk2 > project. He doesn't need to check other branches. > > > > This is certainly an improvement. > > > > / > > Leif > > > > > When this patch submit, I will rebase master with the latest change > > > in master and devel-MinPlatform. > > > > > > Signed-off-by: Liming Gao > > > <liming.gao@intel.com<mailto:liming.gao@intel.com>> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch 2019-05-10 2:47 ` Kubacki, Michael A @ 2019-05-10 3:23 ` Liming Gao 0 siblings, 0 replies; 5+ messages in thread From: Liming Gao @ 2019-05-10 3:23 UTC (permalink / raw) To: Kubacki, Michael A, Leif Lindholm Cc: edk2-devel-groups-io, ard.biesheuvel@linaro.org, Kinney, Michael D Yes. Sorry for this mistake. I will keep original owner in the commit. Thanks Liming >-----Original Message----- >From: Kubacki, Michael A >Sent: Friday, May 10, 2019 10:47 AM >To: Gao, Liming <liming.gao@intel.com>; Leif Lindholm ><leif.lindholm@linaro.org> >Cc: edk2-devel-groups-io <devel@edk2.groups.io>; >ard.biesheuvel@linaro.org; Kinney, Michael D <michael.d.kinney@intel.com> >Subject: RE: [Patch][edk2-platform] Migrate devel-MinPlatform branch to >master branch > >Liming, I have no concern with the plan. I've noticed authors change >In a few recent commits on master_minplatform, I'd prefer they stay >consistent if possible. > >Thanks, >Michael > >> -----Original Message----- >> From: Gao, Liming >> Sent: Wednesday, May 8, 2019 8:31 PM >> To: Leif Lindholm <leif.lindholm@linaro.org> >> Cc: edk2-devel-groups-io <devel@edk2.groups.io>; >> ard.biesheuvel@linaro.org; Kinney, Michael D >> <michael.d.kinney@intel.com>; Kubacki, Michael A >> <michael.a.kubacki@intel.com> >> Subject: RE: [Patch][edk2-platform] Migrate devel-MinPlatform branch to >> master branch >> >> Hi, all >> I don't get the rejection on this change. Leif gives some comments. They >> don't block this migration. They can be resolved after this migration. >> >> Today, I update https://github.com/lgao4/edk2- >> platforms/tree/master_minplatform based on the latest edk2 platform >> master and devel-MinPlatform branch. Please help review and see what's >> missing. I plan to push this migration on May 13th. After this migration, I will >> send the announcement of the migration done. edk2-platform devel- >> MinPlatform branch will be kept as read only. The change will go into edk2- >> plaform master. >> >> Thanks >> Liming >> > -----Original Message----- >> > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] >> > Sent: Thursday, May 2, 2019 10:35 PM >> > To: Gao, Liming <liming.gao@intel.com> >> > Cc: edk2-devel-groups-io <devel@edk2.groups.io>; >> > ard.biesheuvel@linaro.org; Kinney, Michael D >> > <michael.d.kinney@intel.com>; Kubacki, Michael A >> > <michael.a.kubacki@intel.com> >> > Subject: Re: [Patch][edk2-platform] Migrate devel-MinPlatform branch >> > to master branch >> > >> > On Thu, Apr 25, 2019 at 01:08:33PM +0000, Gao, Liming wrote: >> > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1748 >> > > >> > > There is no objection on the RFC >> > > https://edk2.groups.io/g/devel/topic/31236064#39516 >> > > to migrate devel-MinPlatform branch to master branch. >> > >> > Ah, I had completely missed that one due to not being on cc. >> > I do have a few comments, but I'll make those on the original email. >> > >> > > This patch moves all patches in devel-MinPlatform branch to master >> branch. >> > > Here is the migrated code >> > > https://github.com/lgao4/edk2-platforms/tree/master_minplatform >> > > based on today history. All histories in devel-MinPlatform and master >> branches are kept. >> > > After this migration, the developer will check all the codes in >> > > edk2-platform master when he does the incompatible change in edk2 >> project. He doesn't need to check other branches. >> > >> > This is certainly an improvement. >> > >> > / >> > Leif >> > >> > > When this patch submit, I will rebase master with the latest change >> > > in master and devel-MinPlatform. >> > > >> > > Signed-off-by: Liming Gao >> > > <liming.gao@intel.com<mailto:liming.gao@intel.com>> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-10 3:23 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-04-25 13:08 [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch Liming Gao 2019-05-02 14:35 ` Leif Lindholm 2019-05-09 3:31 ` Liming Gao 2019-05-10 2:47 ` Kubacki, Michael A 2019-05-10 3:23 ` Liming Gao
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox