From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: michael.a.kubacki@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Fri, 17 May 2019 18:02:19 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2019 18:02:19 -0700 X-ExtLoop1: 1 Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga005.fm.intel.com with ESMTP; 17 May 2019 18:02:18 -0700 Received: from orsmsx156.amr.corp.intel.com (10.22.240.22) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 17 May 2019 18:02:18 -0700 Received: from orsmsx121.amr.corp.intel.com ([169.254.10.47]) by ORSMSX156.amr.corp.intel.com ([169.254.8.144]) with mapi id 14.03.0415.000; Fri, 17 May 2019 18:02:18 -0700 From: "Kubacki, Michael A" To: "devel@edk2.groups.io" , "Agyeman, Prince" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH 4/5] ClevoOpenBoardPkg: Added GCC5 build support Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH 4/5] ClevoOpenBoardPkg: Added GCC5 build support Thread-Index: AQHVC0SrG62MMrRoskqNS1cvudo24aZwFBAQ Date: Sat, 18 May 2019 01:02:17 +0000 Message-ID: <49AB4ACB9627B8468F29D589A27B7455889470D0@ORSMSX121.amr.corp.intel.com> References: <6b46202ad1a48ae7aa0b9ceff50bda309b8b9f6d.1557779977.git.prince.agyeman@intel.com> In-Reply-To: <6b46202ad1a48ae7aa0b9ceff50bda309b8b9f6d.1557779977.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjk5MDRlYzYtYmJiZS00MDViLWE5NDYtMGNjODMzMGMxODMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUlhrQmcrUzBhUTFmeDBGWVA0RU12TXRES1YxVkJiSGZhNUdCTmJZbmZ2YWdLMjhmbFcxM0lVaGs0SUNwM2d2dSJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.a.kubacki@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Agyeman, Prince > Sent: Wednesday, May 15, 2019 10:36 AM > To: devel@edk2.groups.io > Cc: Agyeman, Prince > Subject: [edk2-devel] [edk2-platforms] [PATCH 4/5] ClevoOpenBoardPkg: > Added GCC5 build support >=20 > From: Prince Agyeman >=20 > Fixes: > * include file paths > * gcc build options >=20 > Gcc build was tested on Ubuntu 16.04.5 LTS with gcc version 5.4.0, nasm > version 2.11.08 >=20 > Signed-off-by: Prince Agyeman > --- >=20 > Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgBuildOption.ds > c | 2 ++ > Platform/Intel/ClevoOpenBoardPkg/OpenBoardPkg.dec | 4= ++-- > 2 files changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgBuildOption. > dsc > b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgBuildOption. > dsc > index 92c7571..8d91d90 100644 > --- > a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgBuildOption. > dsc > +++ > b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgBuildOption. > ds > +++ c > @@ -108,6 +108,7 @@ DEFINE DSC_PLTPKG_FEATURE_BUILD_OPTIONS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) $( # For IA32 Specific Build Flag > # > GCC: *_*_IA32_PP_FLAGS =3D $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > +GCC: *_*_IA32_CC_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) -D > PI_SPECIFICATION_VERSION=3D0x00010015 -Wno-unused -Wl,--allow- > multiple-definition > MSFT: *_*_IA32_ASM_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > MSFT: *_*_IA32_CC_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) $(OPTIMIZE_DISABLE_OPTIONS) > -D PI_SPECIFICATION_VERSION=3D0x00010015 -DASF_PEI > MSFT: *_*_IA32_VFRPP_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) $(OPTIMIZE_DISABLE_OPTIONS) > @@ -130,6 +131,7 @@ MSFT: *_*_IA32_ASLCC_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) $(OPTIMIZE_D > # For X64 Specific Build Flag > # > GCC: *_*_X64_PP_FLAGS =3D $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > +GCC: *_*_X64_CC_FLAGS =3D $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > -D PI_SPECIFICATION_VERSION=3D0x00010015 -Wno-unused -Wl,--allow- > multiple-definition > MSFT: *_*_X64_ASM_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > MSFT: *_*_X64_CC_FLAGS =3D $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) > $(OPTIMIZE_DISABLE_OPTIONS) -D > PI_SPECIFICATION_VERSION=3D0x00010015 > MSFT: *_*_X64_VFRPP_FLAGS =3D > $(DSC_PLTPKG_FEATURE_BUILD_OPTIONS) $(OPTIMIZE_DISABLE_OPTIONS) > diff --git a/Platform/Intel/ClevoOpenBoardPkg/OpenBoardPkg.dec > b/Platform/Intel/ClevoOpenBoardPkg/OpenBoardPkg.dec > index aa457e6..f1d29f7 100644 > --- a/Platform/Intel/ClevoOpenBoardPkg/OpenBoardPkg.dec > +++ b/Platform/Intel/ClevoOpenBoardPkg/OpenBoardPkg.dec > @@ -24,8 +24,8 @@ PACKAGE_GUID =3D D04CCA80-5F71-478D-9A26- > 72BC751D0106 >=20 > [Includes] > Include > -N1xxWU\Include > -Features\Tbt\Include > +N1xxWU/Include > +Features/Tbt/Include >=20 > [Guids] > gBoardModuleTokenSpaceGuid =3D {0x72d1fff7, 0xa42a, 0x4219, > {0xb9, 0x95, 0x5a, 0x67, 0x53, 0x6e, 0xa4, 0x2a}} > -- > 2.7.4 >=20 >=20 >=20