public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Cc: Andrew Fish <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
	"Leif Lindholm" <leif.lindholm@linaro.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Sinha, Ankit" <ankit.sinha@intel.com>,
	"Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch
Date: Fri, 9 Aug 2019 00:36:00 +0000	[thread overview]
Message-ID: <49AB4ACB9627B8468F29D589A27B745588A3BD14@ORSMSX122.amr.corp.intel.com> (raw)
In-Reply-To: <20190808213048.35628-1-nathaniel.l.desimone@intel.com>

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Nate DeSimone
> Sent: Thursday, August 8, 2019 2:31 PM
> To: devel@edk2.groups.io
> Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>;
> Leif Lindholm <leif.lindholm@linaro.org>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Sinha, Ankit <ankit.sinha@intel.com>; Chiu,
> Chasel <chasel.chiu@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel: Update
> Readme.md to point to edk2-non-osi master branch
> 
> Updated Platform/Intel/Readme.md to point to master branch on edk2-non-
> osi instead of devel-MinPlatform
> 
> Updated edk2-platforms/Readme.md to point to Platform/Intel/Readme.md
> for build instructions on Intel based Minimum Platforms
> 
> Added a link to the EDK II Minimum Platform Draft Specification to
> Platform/Intel/Readme.md
> 
> Cc: Andrew Fish <afish@apple.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  Platform/Intel/Readme.md | 6 ++++--
>  Readme.md                | 8 +++++++-
>  2 files changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md index
> 0a0e8a8c80..00f42985a2 100644
> --- a/Platform/Intel/Readme.md
> +++ b/Platform/Intel/Readme.md
> @@ -1,7 +1,9 @@
>  # **EDK II Minimum Platform Firmware for Intel(R) Platforms**
> 
>  The Minimum Platform is a software architecture that guides uniform
> delivery of Intel platforms enabling firmware -solutions for basic boot
> functionality with extensibility built-in.
> +solutions for basic boot functionality with extensibility built-in.
> +Please see the [EDK II Minimum Platform Draft
> +Specification](https://edk2-docs.gitbooks.io/edk-ii-minimum-platform-sp
> +ecification/)
> +for more details.
> 
>  Package maintainers for the Minimum Platform projects are listed in
> Maintainers.txt.
> 
> @@ -98,7 +100,7 @@ return back to the minimum platform caller.
>    * ``git clone https://github.com/tianocore/edk2-platforms.git``
> 
>  * edk2-non-osi repository
> -  * ``git clone https://github.com/tianocore/edk2-non-osi.git -b devel-
> MinPlatform``
> +  * ``git clone https://github.com/tianocore/edk2-non-osi.git``
> 
>  * FSP repository
>    * ``git clone https://github.com/IntelFsp/FSP.git``
> diff --git a/Readme.md b/Readme.md
> index 63e59f60b4..28badd6b4b 100644
> --- a/Readme.md
> +++ b/Readme.md
> @@ -34,6 +34,9 @@ edk2-devel mailing list with a subject prefix of
> `[platforms]`. See  on how to do this successfully.
> 
>  # How to build (Linux Environment)
> +Note: Build instructions for Intel based Minimum Platforms differ from
> +these instructions and are available at
> +[`edk2-
> platforms/Platform/Intel/README.md`](https://github.com/tianocor
> +e/edk2-platforms/blob/master/Platform/Intel/Readme.md)
> 
>  ## Prerequisites
>  The build tools themselves depend on Python (2) and libuuid. Most Linux
> systems @@ -195,8 +198,11 @@ $ ./uefi-tools/edk2-build.sh -b DEBUG -b
> RELEASE  ```
> 
>  # How To Build (Windows Environment)
> +Note: Build instructions for Intel based Minimum Platforms differ from
> +these instructions and are available at
> +[`edk2-
> platforms/Platform/Intel/README.md`](https://github.com/tianocor
> +e/edk2-platforms/blob/master/Platform/Intel/Readme.md)
> 
> -(I genuinely have no idea. Please help!)
> +(For other platforms, I genuinely have no idea. Please help!)
> 
> 
>  # Supported Platforms
> --
> 2.17.1.windows.2
> 
> 
> 


  reply	other threads:[~2019-08-09  0:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08 21:30 [edk2-platforms] [PATCH] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch Nate DeSimone
2019-08-09  0:36 ` Kubacki, Michael A [this message]
2019-08-09 10:32 ` Leif Lindholm
2019-08-11 23:52   ` Nate DeSimone
2019-08-12 16:09     ` Kubacki, Michael A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AB4ACB9627B8468F29D589A27B745588A3BD14@ORSMSX122.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox