public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.
Date: Fri, 9 Aug 2019 18:12:53 +0000	[thread overview]
Message-ID: <49AB4ACB9627B8468F29D589A27B745588A3D155@ORSMSX122.amr.corp.intel.com> (raw)
In-Reply-To: <20190809004653.39088-1-nathaniel.l.desimone@intel.com>

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Nate DeSimone
> Sent: Thursday, August 8, 2019 5:47 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>
> Subject: [edk2-devel] [edk2-platforms] [PATCH]
> Platform/Intel/KabylakeOpenBoardPkg: Fix build.
> 
> The build for KabylakeOpenBoardPkg is presently broken due to
> WORKSPACE_PLATFORM_BIN being defined to a marco of the same name in
> KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> 
> Setting this macro to an empty string resolves the issue.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg    | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> index bf89ea399c..ab1a9a61c2 100644
> --- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
> @@ -7,7 +7,7 @@
> 
> 
>  [CONFIG]
> -WORKSPACE_PLATFORM_BIN = WORKSPACE_PLATFORM_BIN
> +WORKSPACE_PLATFORM_BIN =
>  EDK_SETUP_OPTION =
>  openssl_path =
>  PLATFORM_BOARD_PACKAGE = KabylakeOpenBoardPkg
> --
> 2.17.1.windows.2
> 
> 
> 


  reply	other threads:[~2019-08-09 18:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09  0:46 [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build Nate DeSimone
2019-08-09 18:12 ` Kubacki, Michael A [this message]
2019-08-11 23:54   ` [edk2-devel] " Nate DeSimone
2019-08-12  2:07 ` Chiu, Chasel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AB4ACB9627B8468F29D589A27B745588A3D155@ORSMSX122.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox