public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Zhang, Shenglei" <shenglei.zhang@intel.com>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
	"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: Add build option
Date: Fri, 23 Aug 2019 17:24:01 +0000	[thread overview]
Message-ID: <49AB4ACB9627B8468F29D589A27B745588A82F49@ORSMSX121.amr.corp.intel.com> (raw)
In-Reply-To: <20190822070808.6600-4-shenglei.zhang@intel.com>

Please extend the file copyright date. With that change:

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 22, 2019 12:08 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Zhang, Shenglei <shenglei.zhang@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH 3/4]
> Platform/MinPlatformPkg.dsc: Add build option
> 
> Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in DSC file
> to make sure that the deprecated APIs will not be used in our code.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2111
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> index 8a3638b7..9bbb7963 100644
> --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
> @@ -187,3 +187,6 @@
>    MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf
>    MinPlatformPkg/Tcg/Tcg2PlatformDxe/Tcg2PlatformDxe.inf
>  !endif
> +
> +[BuildOptions]
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> \ No newline at end of file
> --
> 2.18.0.windows.1
> 
> 
> 


  parent reply	other threads:[~2019-08-23 17:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22  7:08 [edk2-platforms PATCH 0/4] Add build option in DSC files Zhang, Shenglei
2019-08-22  7:08 ` [edk2-platforms PATCH 1/4] Platform/AdvancedFeaturePkg.dsc: Add build option Zhang, Shenglei
2019-08-23 17:21   ` [edk2-devel] " Kubacki, Michael A
2019-08-23 17:57   ` Chaganty, Rangasai V
2019-08-22  7:08 ` [edk2-platforms PATCH 2/4] Platform/DebugFeaturePkg.dsc: " Zhang, Shenglei
2019-08-23 17:22   ` [edk2-devel] " Kubacki, Michael A
2019-08-22  7:08 ` [edk2-platforms PATCH 3/4] Platform/MinPlatformPkg.dsc: " Zhang, Shenglei
2019-08-22 18:03   ` [edk2-devel] " Chiu, Chasel
2019-08-23 17:24   ` Kubacki, Michael A [this message]
2019-08-23 23:39   ` Nate DeSimone
2019-08-22  7:08 ` [edk2-platforms PATCH 4/4] Platform/UserInterfaceFeaturePkg.dsc: " Zhang, Shenglei
2019-08-23 17:24   ` [edk2-devel] " Kubacki, Michael A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AB4ACB9627B8468F29D589A27B745588A82F49@ORSMSX121.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox