public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF
Date: Fri, 23 Aug 2019 17:32:46 +0000	[thread overview]
Message-ID: <49AB4ACB9627B8468F29D589A27B745588A82FAA@ORSMSX121.amr.corp.intel.com> (raw)
In-Reply-To: <20190821080108.1736-2-shenglei.zhang@intel.com>

Please extend the copyright date in SmbiosDxe.inf to 2019. With that change:

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, August 21, 2019 1:01 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing
> header file in INF
> 
> The header file is used but missing in INF,which causes warning message when
> building them.
> https://bugzilla.tianocore.org/show_bug.cgi?id=2037
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf  | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git
> a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx
> e.inf
> b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx
> e.inf
> index 69e930dd..bbac1d5c 100644
> ---
> a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx
> e.inf
> +++ b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi
> +++ cDxe.inf
> @@ -23,6 +23,7 @@
> 
>  [Sources]
>    SmbiosBasicEntryPoint.c
> +  SmbiosBasic.h
>    Type0BiosVendorFunction.c
>    Type1SystemManufacturerFunction.c
>    Type2BaseBoardManufacturerFunction.c
> --
> 2.18.0.windows.1


  reply	other threads:[~2019-08-23 17:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-21  8:01 [edk2-platform PATCH 0/2] Fix warning message issues Zhang, Shenglei
2019-08-21  8:01 ` [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF Zhang, Shenglei
2019-08-23 17:32   ` Kubacki, Michael A [this message]
2019-08-23 18:11   ` Chaganty, Rangasai V
2019-08-27  1:31     ` Zhang, Shenglei
2019-08-21  8:01 ` [edk2-platform PATCH 2/2] Platform/MinPlatformPkg: Add missing header files in INF files Zhang, Shenglei
2019-08-21  8:09   ` Chiu, Chasel
2019-08-23 17:33   ` Kubacki, Michael A
2019-08-23 21:55   ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AB4ACB9627B8468F29D589A27B745588A82FAA@ORSMSX121.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox