From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: michael.a.kubacki@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Fri, 23 Aug 2019 10:32:48 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Aug 2019 10:32:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,422,1559545200"; d="scan'208";a="170183471" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga007.jf.intel.com with ESMTP; 23 Aug 2019 10:32:47 -0700 Received: from orsmsx126.amr.corp.intel.com (10.22.240.126) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 23 Aug 2019 10:32:47 -0700 Received: from orsmsx121.amr.corp.intel.com ([169.254.10.57]) by ORSMSX126.amr.corp.intel.com ([169.254.4.36]) with mapi id 14.03.0439.000; Fri, 23 Aug 2019 10:32:47 -0700 From: "Kubacki, Michael A" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF Thread-Topic: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing header file in INF Thread-Index: AQHVV/adIuNlQpBpV0m1YrLb/wS89KcJAIBg Date: Fri, 23 Aug 2019 17:32:46 +0000 Message-ID: <49AB4ACB9627B8468F29D589A27B745588A82FAA@ORSMSX121.amr.corp.intel.com> References: <20190821080108.1736-1-shenglei.zhang@intel.com> <20190821080108.1736-2-shenglei.zhang@intel.com> In-Reply-To: <20190821080108.1736-2-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjAzM2E3ZTctMjVmNi00N2YwLWE0MzEtNzhlMzUxMTYzODAyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOHVnM0NXQnZBUzBVWkk0MlV1Z0FWNnp1UTl2ejR2NHYyTHFzaEpJYVBaZ3BjRGdvRmQ3SFwvVmpJT1dCeU9VT1IifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.a.kubacki@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please extend the copyright date in SmbiosDxe.inf to 2019. With that change= : Reviewed-by: Michael Kubacki > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, August 21, 2019 1:01 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai = V > ; Gao, Liming > Subject: [edk2-platform PATCH 1/2] Platform/SmbiosBasicDxe: Add a missing > header file in INF >=20 > The header file is used but missing in INF,which causes warning message w= hen > building them. > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2037 >=20 > Cc: Michael Kubacki > Cc: Sai Chaganty > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDxe.inf | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git > a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx > e.inf > b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx > e.inf > index 69e930dd..bbac1d5c 100644 > --- > a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasicDx > e.inf > +++ b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi > +++ cDxe.inf > @@ -23,6 +23,7 @@ >=20 > [Sources] > SmbiosBasicEntryPoint.c > + SmbiosBasic.h > Type0BiosVendorFunction.c > Type1SystemManufacturerFunction.c > Type2BaseBoardManufacturerFunction.c > -- > 2.18.0.windows.1