From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: michael.a.kubacki@intel.com)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by groups.io with SMTP; Thu, 29 Aug 2019 16:15:54 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2019 16:15:53 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,445,1559545200"; 
   d="scan'208";a="210717343"
Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5])
  by fmsmga002.fm.intel.com with ESMTP; 29 Aug 2019 16:15:53 -0700
Received: from orsmsx153.amr.corp.intel.com (10.22.226.247) by
 ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 29 Aug 2019 16:15:53 -0700
Received: from orsmsx121.amr.corp.intel.com ([169.254.10.57]) by
 ORSMSX153.amr.corp.intel.com ([169.254.12.225]) with mapi id 14.03.0439.000;
 Thu, 29 Aug 2019 16:15:53 -0700
From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>, "Desimone, Nathaniel L"
	<nathaniel.l.desimone@intel.com>
CC: "Chiu, Chasel" <chasel.chiu@intel.com>, "Chaganty, Rangasai V"
	<rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-devel] [PATCH] CoffeelakeSiliconPkg: Add a needed ZeroMem ()
Thread-Topic: [edk2-devel] [PATCH] CoffeelakeSiliconPkg: Add a needed
 ZeroMem ()
Thread-Index: AQHVXr2KJrX4/ymh2EebjDXskWOJXqcSvlpw
Date: Thu, 29 Aug 2019 23:15:52 +0000
Message-ID: <49AB4ACB9627B8468F29D589A27B745588A93349@ORSMSX121.amr.corp.intel.com>
References: <20190829230012.30756-1-nathaniel.l.desimone@intel.com>
In-Reply-To: <20190829230012.30756-1-nathaniel.l.desimone@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGZlOTYyYjMtYTFkYy00MjRmLTgxOGMtMTNmZTQxNDllZjYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRUFVeHFRNWNSZFNCV2REZityZVVsZ3c2YVR2WnorSFdtdFdGaVM1R0swRmVNb2JtNyt5Y1N0a21xbGJ0akJNRiJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.22.254.139]
MIME-Version: 1.0
Return-Path: michael.a.kubacki@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

In the future, the subject should include [edk2-platforms] for patches in t=
he repo.

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate
> DeSimone
> Sent: Thursday, August 29, 2019 4:00 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [edk2-devel] [PATCH] CoffeelakeSiliconPkg: Add a needed
> ZeroMem ()
>=20
> AddComponentConfigBlocks () should ZeroMem () the Config Block Header
> before using it.
>=20
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  .../Library/BaseSiConfigBlockLib/BaseSiConfigBlockLib.c          | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git
> a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseSiConfigBlockLib/BaseSi=
Con
> figBlockLib.c
> b/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseSiConfigBlockLib/BaseSi=
Con
> figBlockLib.c
> index 16a14b3245..3c02a4563c 100644
> ---
> a/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseSiConfigBlockLib/BaseSi=
Con
> figBlockLib.c
> +++
> b/Silicon/Intel/CoffeelakeSiliconPkg/Library/BaseSiConfigBlockLib/BaseSi=
Con
> figBlockLib.c
> @@ -75,6 +75,7 @@ AddComponentConfigBlocks (
>    // Loop to identify each config block from ComponentBlocks[] Table an=
d
> add each of them
>    //
>    for (BlockCount =3D 0 ; BlockCount < TotalBlockCount; BlockCount++) {
> +    ZeroMem (&ConfigBlockBuf, sizeof (CONFIG_BLOCK));
>      CopyMem (&(ConfigBlockBuf.Header.GuidHob.Name),
> ComponentBlocks[BlockCount].Guid, sizeof (EFI_GUID));
>      ConfigBlockBuf.Header.GuidHob.Header.HobLength =3D
> ComponentBlocks[BlockCount].Size;
>      ConfigBlockBuf.Header.Revision        =3D
> ComponentBlocks[BlockCount].Revision;
> --
> 2.17.1.windows.2
>=20
>=20
>=20