Re: [edk2-devel] [edk2-platforms PATCH v4 6/7] Platform/Intel: Add build option for SIMICS QSP Platform

["Kubacki, Michael A" <michael.a.kubacki@intel.com>]

This patch adds the following in Platform/Intel/build.cfg:
  BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg

But the file SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg is not added until patch 7/7. This patch seems more appropriate as the final patch of the series.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of David Wei
> Sent: Friday, August 30, 2019 2:19 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Sinha, Ankit <ankit.sinha@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2-devel] [edk2-platforms PATCH v4 6/7] Platform/Intel: Add build
> option for SIMICS QSP Platform
> 
> Add build option in build script for SIMICS QSP Platform
> 
> Add Maintainers of Simics QSP related packages
> 
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Kubacki Michael A <michael.a.kubacki@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Signed-off-by: David Wei <david.y.wei@intel.com>
> ---
>  Maintainers.txt              | 12 ++++++++++++
>  Platform/Intel/build.cfg     |  2 ++
>  Platform/Intel/build_bios.py |  3 +++
>  3 files changed, 17 insertions(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt index b16432bf87..90eb3c3dd0
> 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -103,6 +103,10 @@ M: Chasel Chiu <chasel.chiu@intel.com>
>  M: Michael Kubacki <michael.a.kubacki@intel.com>
>  M: Nate DeSimone <nathaniel.l.desimone@intel.com>
> 
> +Platform/Intel/SimicsOpenBoardPkg
> +M: Wei David Y <david.y.wei@intel.com>
> +M: Agyeman Prince <prince.agyeman@intel.com>
> +
>  Platform/Intel/Tools
>  M: Bob Feng <bob.c.feng@intel.com>
>  M: Liming Gao <liming.gao@intel.com>
> @@ -155,6 +159,14 @@ M: Gillispie, Thad <thad.gillispie@intel.com>
>  M: Bu, Daocheng <daocheng.bu@intel.com>
>  M: Oram, Isaac W <isaac.w.oram@intel.com>
> 
> +Silicon/Intel/SimicsX58SktPkg
> +M: Wei David Y <david.y.wei@intel.com>
> +M: Agyeman Prince <prince.agyeman@intel.com>
> +
> +Silicon/Intel/SimicsIch10Pkg
> +M: Wei David Y <david.y.wei@intel.com>
> +M: Agyeman Prince <prince.agyeman@intel.com>
> +
>  Silicon/Intel/Tools
>  M: Bob Feng <bob.c.feng@intel.com>
>  M: Liming Gao <liming.gao@intel.com>
> diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index
> b6d32ada49..75cb446aa5 100644
> --- a/Platform/Intel/build.cfg
> +++ b/Platform/Intel/build.cfg
> @@ -11,6 +11,7 @@ WORKSPACE =
>  WORKSPACE_FSP_BIN = FSP
>  EDK_TOOLS_BIN = edk2-BaseTools-win32
>  EDK_BASETOOLS = BaseTools
> +WORKSPACE_DRIVERS = edk2-platforms/Drivers
>  WORKSPACE_PLATFORM = edk2-platforms/Platform/Intel
> WORKSPACE_SILICON = edk2-platforms/Silicon/Intel
> WORKSPACE_PLATFORM_BIN = @@ -52,6 +53,7 @@
> NUMBER_OF_PROCESSORS = 0  [PLATFORMS]  # board_name =
> path_to_board_build_config.cfg  BoardMtOlympus =
> PurleyOpenBoardPkg/BoardMtOlympus/build_config.cfg
> +BoardX58Ich10 = SimicsOpenBoardPkg/BoardX58Ich10/build_config.cfg
>  KabylakeRvp3 = KabylakeOpenBoardPkg/KabylakeRvp3/build_config.cfg
>  N1xxWU = ClevoOpenBoardPkg/N1xxWU/build_config.cfg
>  WhiskeylakeURvp =
> WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
> diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index
> 9152670dcb..46285df19a 100644
> --- a/Platform/Intel/build_bios.py
> +++ b/Platform/Intel/build_bios.py
> @@ -104,6 +104,8 @@ def pre_build(build_config, build_type="DEBUG",
> silent=False, toolchain=None):
>                                                  config["WORKSPACE_PLATFORM"])
>      config["WORKSPACE_SILICON"] = os.path.join(config["WORKSPACE"],
>                                                 config["WORKSPACE_SILICON"])
> +    config["WORKSPACE_DRIVERS"] = os.path.join(config["WORKSPACE"],
> +
> + config["WORKSPACE_DRIVERS"])
>      config["WORKSPACE_PLATFORM_BIN"] = \
>          os.path.join(config["WORKSPACE"],
> config["WORKSPACE_PLATFORM_BIN"])
>      config["WORKSPACE_SILICON_BIN"] = \ @@ -115,6 +117,7 @@ def
> pre_build(build_config, build_type="DEBUG", silent=False, toolchain=None):
>      config["PACKAGES_PATH"] = config["WORKSPACE_PLATFORM"]
>      config["PACKAGES_PATH"] += os.pathsep + config["WORKSPACE_SILICON"]
>      config["PACKAGES_PATH"] += os.pathsep +
> config["WORKSPACE_SILICON_BIN"]
> +    config["PACKAGES_PATH"] += os.pathsep + config["WORKSPACE_DRIVERS"]
>      config["PACKAGES_PATH"] += os.pathsep + \
>          os.path.join(config["WORKSPACE"], "FSP")
>      config["PACKAGES_PATH"] += os.pathsep + \
> --
> 2.16.2.windows.1
> 
> 
>