Re: [edk2-platforms][PATCH V4] AdvancedFeaturePkg/S3Advanced Add S3 Advanced PEIM driver

["Kubacki, Michael A" <michael.a.kubacki@intel.com>]

* Please keep the directory as just S3 so the path is AdvancedFeaturePkg/S3/S3AdvancedPei.inf.
   * The module could optionally be renamed to just S3Pei.inf to simplify the name
* Please add new PEIM into edk2-platforms\Platform\Intel\AdvancedFeaturePkg\AdvancedFeaturePkg.dsc for build test.
* Can you make MdePkg/MdePkg.dec the first DEC file in the INF?

Thanks,
Michael

> -----Original Message-----
> From: Chen, Marc W
> Sent: Friday, September 6, 2019 12:53 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Chen, Marc W <marc.w.chen@intel.com>
> Subject: [edk2-platforms][PATCH V4] AdvancedFeaturePkg/S3Advanced Add
> S3 Advanced PEIM driver
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2154
> 
> Implement a S3 Advanced PEIM driver for supporting S3 feature.
> So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case.
> 
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Marc Chen <marc.w.chen@intel.com>
> ---
>  .../S3Advanced/S3AdvancedPei/S3AdvancedPei.c       | 36
> ++++++++++++++++++++++
>  .../S3Advanced/S3AdvancedPei/S3AdvancedPei.inf     | 31
> +++++++++++++++++++
>  2 files changed, 67 insertions(+)
>  create mode 100644
> Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Advanc
> edPei.c
>  create mode 100644
> Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Advanc
> edPei.inf
> 
> diff --git
> a/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva
> ncedPei.c
> b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva
> ncedPei.c
> new file mode 100644
> index 00000000..9ce4cc6a
> --- /dev/null
> +++
> b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva
> n
> +++ cedPei.c
> @@ -0,0 +1,36 @@
> +/** @file
> +  Source code file for S3 Advanced PEI module
> +
> +Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +SPDX-License-Identifier: BSD-2-Clause-Patent
> +
> +**/
> +
> +#include <Library/PeiServicesLib.h>
> +#include <Library/SmmAccessLib.h>
> +
> +/**
> +  S3 Advanced PEI module entry point
> +
> +  @param[in]  FileHandle           Not used.
> +  @param[in]  PeiServices          General purpose services available to every
> PEIM.
> +
> +  @retval     EFI_SUCCESS          The function completes successfully
> +  @retval     EFI_OUT_OF_RESOURCES Insufficient resources to create
> database
> +**/
> +EFI_STATUS
> +EFIAPI
> +S3AdvancedEntryPoint (
> +  IN       EFI_PEI_FILE_HANDLE  FileHandle,
> +  IN CONST EFI_PEI_SERVICES     **PeiServices
> +  )
> +{
> +  EFI_STATUS Status;
> +
> +  //
> +  // Install EFI_PEI_MM_ACCESS_PPI for S3 resume case  //  Status =
> + PeiInstallSmmAccessPpi ();
> +
> +  return Status;
> +}
> diff --git
> a/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva
> ncedPei.inf
> b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva
> ncedPei.inf
> new file mode 100644
> index 00000000..d51a8ee8
> --- /dev/null
> +++
> b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva
> n
> +++ cedPei.inf
> @@ -0,0 +1,31 @@
> +### @file
> +# Component information file for the S3 Advanced PEI module.
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> # #
> +SPDX-License-Identifier: BSD-2-Clause-Patent # ###
> +
> +[Defines]
> +  INF_VERSION                    = 0x00010017
> +  BASE_NAME                      = S3AdvancedPei
> +  FILE_GUID                      = 8683EFB2-FDE1-4AFF-B2DB-E96449FDD4E9
> +  VERSION_STRING                 = 1.0
> +  MODULE_TYPE                    = PEIM
> +  ENTRY_POINT                    = S3AdvancedEntryPoint
> +
> +[LibraryClasses]
> +  PeimEntryPoint
> +  PeiServicesLib
> +  SmmAccessLib
> +
> +[Packages]
> +  IntelSiliconPkg/IntelSiliconPkg.dec
> +  MdePkg/MdePkg.dec
> +
> +[Sources]
> +  S3AdvancedPei.c
> +
> +[Depex]
> +  gEfiPeiMemoryDiscoveredPpiGuid
> --
> 2.16.2.windows.1