From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: michael.a.kubacki@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Tue, 10 Sep 2019 13:34:16 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2019 13:34:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,490,1559545200"; d="scan'208";a="175431524" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga007.jf.intel.com with ESMTP; 10 Sep 2019 13:34:15 -0700 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Sep 2019 13:34:15 -0700 Received: from orsmsx121.amr.corp.intel.com ([169.254.10.57]) by ORSMSX157.amr.corp.intel.com ([169.254.9.22]) with mapi id 14.03.0439.000; Tue, 10 Sep 2019 13:34:14 -0700 From: "Kubacki, Michael A" To: "Chen, Marc W" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-platforms][PATCH V4] AdvancedFeaturePkg/S3Advanced Add S3 Advanced PEIM driver Thread-Topic: [edk2-platforms][PATCH V4] AdvancedFeaturePkg/S3Advanced Add S3 Advanced PEIM driver Thread-Index: AQHVZIgSTIQ2maKa+kC+jl933pQf/KclH1kA Date: Tue, 10 Sep 2019 20:34:14 +0000 Message-ID: <49AB4ACB9627B8468F29D589A27B745588ABCD11@ORSMSX121.amr.corp.intel.com> References: <20190906075237.12424-1-marc.w.chen@intel.com> In-Reply-To: <20190906075237.12424-1-marc.w.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTlhZDczZDMtMzU5Zi00MmViLWExNDAtODUxMDlkZDhjOTMwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU0pZWDZtcXZ6Smw1R3E1d2ZLeUJ6enVCQitWT25cLzEza0twOWVkSEp0SDU3ZVRTV3V5V0liWWpQWjVMNEZXdFQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.a.kubacki@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable * Please keep the directory as just S3 so the path is AdvancedFeaturePkg/S3= /S3AdvancedPei.inf. * The module could optionally be renamed to just S3Pei.inf to simplify t= he name * Please add new PEIM into edk2-platforms\Platform\Intel\AdvancedFeaturePkg= \AdvancedFeaturePkg.dsc for build test. * Can you make MdePkg/MdePkg.dec the first DEC file in the INF? Thanks, Michael > -----Original Message----- > From: Chen, Marc W > Sent: Friday, September 6, 2019 12:53 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai = V > ; Gao, Liming ; > Chen, Marc W > Subject: [edk2-platforms][PATCH V4] AdvancedFeaturePkg/S3Advanced Add > S3 Advanced PEIM driver >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2154 >=20 > Implement a S3 Advanced PEIM driver for supporting S3 feature. > So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case. >=20 > Cc: Michael Kubacki > Cc: Sai Chaganty > Cc: Liming Gao > Signed-off-by: Marc Chen > --- > .../S3Advanced/S3AdvancedPei/S3AdvancedPei.c | 36 > ++++++++++++++++++++++ > .../S3Advanced/S3AdvancedPei/S3AdvancedPei.inf | 31 > +++++++++++++++++++ > 2 files changed, 67 insertions(+) > create mode 100644 > Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Advanc > edPei.c > create mode 100644 > Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Advanc > edPei.inf >=20 > diff --git > a/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva > ncedPei.c > b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva > ncedPei.c > new file mode 100644 > index 00000000..9ce4cc6a > --- /dev/null > +++ > b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva > n > +++ cedPei.c > @@ -0,0 +1,36 @@ > +/** @file > + Source code file for S3 Advanced PEI module > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > + > +/** > + S3 Advanced PEI module entry point > + > + @param[in] FileHandle Not used. > + @param[in] PeiServices General purpose services available to= every > PEIM. > + > + @retval EFI_SUCCESS The function completes successfully > + @retval EFI_OUT_OF_RESOURCES Insufficient resources to create > database > +**/ > +EFI_STATUS > +EFIAPI > +S3AdvancedEntryPoint ( > + IN EFI_PEI_FILE_HANDLE FileHandle, > + IN CONST EFI_PEI_SERVICES **PeiServices > + ) > +{ > + EFI_STATUS Status; > + > + // > + // Install EFI_PEI_MM_ACCESS_PPI for S3 resume case // Status =3D > + PeiInstallSmmAccessPpi (); > + > + return Status; > +} > diff --git > a/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva > ncedPei.inf > b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva > ncedPei.inf > new file mode 100644 > index 00000000..d51a8ee8 > --- /dev/null > +++ > b/Platform/Intel/AdvancedFeaturePkg/S3Advanced/S3AdvancedPei/S3Adva > n > +++ cedPei.inf > @@ -0,0 +1,31 @@ > +### @file > +# Component information file for the S3 Advanced PEI module. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# # > +SPDX-License-Identifier: BSD-2-Clause-Patent # ### > + > +[Defines] > + INF_VERSION =3D 0x00010017 > + BASE_NAME =3D S3AdvancedPei > + FILE_GUID =3D 8683EFB2-FDE1-4AFF-B2DB-E96449FDD4E= 9 > + VERSION_STRING =3D 1.0 > + MODULE_TYPE =3D PEIM > + ENTRY_POINT =3D S3AdvancedEntryPoint > + > +[LibraryClasses] > + PeimEntryPoint > + PeiServicesLib > + SmmAccessLib > + > +[Packages] > + IntelSiliconPkg/IntelSiliconPkg.dec > + MdePkg/MdePkg.dec > + > +[Sources] > + S3AdvancedPei.c > + > +[Depex] > + gEfiPeiMemoryDiscoveredPpiGuid > -- > 2.16.2.windows.1