From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: michael.a.kubacki@intel.com)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by groups.io with SMTP; Tue, 10 Sep 2019 18:39:13 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
  by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2019 18:39:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,491,1559545200"; 
   d="scan'208";a="178870581"
Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133])
  by orsmga008.jf.intel.com with ESMTP; 10 Sep 2019 18:39:12 -0700
Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by
 ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 10 Sep 2019 18:39:12 -0700
Received: from orsmsx121.amr.corp.intel.com ([169.254.10.57]) by
 ORSMSX157.amr.corp.intel.com ([169.254.9.22]) with mapi id 14.03.0439.000;
 Tue, 10 Sep 2019 18:39:12 -0700
From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "Chiu, Chasel" <chasel.chiu@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>, "Gao, Liming"
	<liming.gao@intel.com>
Subject: Re: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode.
Thread-Topic: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB
 Temporary RAM in Dispatch mode.
Thread-Index: AQHVZIDw4arpuOSR6EeQ2+XTQ4agI6clubIg
Date: Wed, 11 Sep 2019 01:39:11 +0000
Message-ID: <49AB4ACB9627B8468F29D589A27B745588ABD2F8@ORSMSX121.amr.corp.intel.com>
References: <20190906070110.18204-1-chasel.chiu@intel.com>
In-Reply-To: <20190906070110.18204-1-chasel.chiu@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNzkxNjk0OTktMzcxMi00YWY2LTgzOTUtZGM0OWUzNTI0ODhiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRlZcLzQ4Q2h5WFhNenlWTkVuMWtjNUhnMTl0bXdYWFdEODh2MEZVMlk3RjVXTUdIdHd5bzNUUXpQV0NZZnA5SCsifQ==
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.22.254.139]
MIME-Version: 1.0
Return-Path: michael.a.kubacki@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>

> -----Original Message-----
> From: Chiu, Chasel
> Sent: Friday, September 6, 2019 12:01 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Desimone, Nathaniel
> L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB
> Temporary RAM in Dispatch mode.
>=20
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2159
>=20
> FSP Dispatch mode will share same stack and heap with bootloader so we
> should not reserve separate temporary ram for FSP.
> Set PcdFspTemporaryRamSize to 0 in Dispatch mode.
>=20
> Test: internal platform can boot with FSP Dispatch mode
>       with 64KB temporary RAM back.
>=20
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>=20
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds
> c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.
> dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.
> dsc
> index 55ae9f47ac..2009bb225a 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.
> dsc
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.
> d
> +++ sc
> @@ -69,10 +69,10 @@
>    gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000
>  !else
>    #
> -  # FSP Dispatch mode will share the same stack with boot loader,
> -  # here temporary ram size is used by FSP heap and can be smaller
> +  # FSP Dispatch mode will share the same stack and heap with boot
> + loader,  # no separate temporary ram required by FSP.
>    #
> -  gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize        | 0x00010000
> +  gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize        | 0
>=20
>    #
>    # In FSP Dispatch mode boot loader stack size must be big enough for
> executing
> --
> 2.13.3.windows.1