From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: michael.a.kubacki@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Tue, 10 Sep 2019 19:53:39 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2019 19:53:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,491,1559545200"; d="scan'208";a="187048419" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga003.jf.intel.com with ESMTP; 10 Sep 2019 19:53:39 -0700 Received: from orsmsx122.amr.corp.intel.com (10.22.225.227) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Sep 2019 19:53:38 -0700 Received: from orsmsx121.amr.corp.intel.com ([169.254.10.57]) by ORSMSX122.amr.corp.intel.com ([169.254.11.203]) with mapi id 14.03.0439.000; Tue, 10 Sep 2019 19:53:38 -0700 From: "Kubacki, Michael A" To: "devel@edk2.groups.io" , "Chen, Marc W" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add S3 PEIM driver Thread-Topic: [edk2-devel] [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: Add S3 PEIM driver Thread-Index: AQHVaEhv1NQqaO7VlU6NxMd02sb+gKclx2cg Date: Wed, 11 Sep 2019 02:53:37 +0000 Message-ID: <49AB4ACB9627B8468F29D589A27B745588ABD3F4@ORSMSX121.amr.corp.intel.com> References: <20190911022651.14196-1-marc.w.chen@intel.com> In-Reply-To: <20190911022651.14196-1-marc.w.chen@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjY0MDIwZTctZjY4ZC00ODU3LWJiNmMtNDE2OGMzNTBiZWI5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiOExEMG44WVpiYUZEaHpXd3lrdUZFXC9NSTY4amxaOSt6S3hRNFJZYXMwSkVBT2ZRamdDTFRMS3NJR2N0XC9yRytUIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Return-Path: michael.a.kubacki@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Marc W > Chen > Sent: Tuesday, September 10, 2019 7:27 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chaganty, Rangasai= V > ; Gao, Liming ; Che= n, > Marc W > Subject: [edk2-devel] [edk2-platforms][PATCH V5] AdvancedFeaturePkg/S3: = Add > S3 PEIM driver >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2154 >=20 > Implement a S3 PEIM driver for supporting S3 feature. > So far this driver only install EFI_PEI_MM_ACCESS_PPI for S3 resume case= . >=20 > Cc: Michael Kubacki > Cc: Sai Chaganty > Cc: Liming Gao > Signed-off-by: Marc Chen > --- > .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 2 ++ > Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c | 36 > ++++++++++++++++++++++ > Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf | 31 +++++++++++++++= ++++ > 3 files changed, 69 insertions(+) > create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c > create mode 100644 Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf >=20 > diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > index a50952dd..2ab706c2 100644 > --- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > +++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > @@ -149,5 +149,7 @@ > AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.inf > AdvancedFeaturePkg/Ipmi/BmcAcpi/BmcAcpi.inf >=20 > + AdvancedFeaturePkg/S3/S3Pei.inf > + > [BuildOptions] > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES \ No newline > at end of file diff --git a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c > b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c > new file mode 100644 > index 00000000..b0aaa049 > --- /dev/null > +++ b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.c > @@ -0,0 +1,36 @@ > +/** @file > + Source code file for S3 PEI module > + > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#include > +#include > + > +/** > + S3 PEI module entry point > + > + @param[in] FileHandle Not used. > + @param[in] PeiServices General purpose services available t= o every > PEIM. > + > + @retval EFI_SUCCESS The function completes successfully > + @retval EFI_OUT_OF_RESOURCES Insufficient resources to create dat= abase > +**/ > +EFI_STATUS > +EFIAPI > +S3PeiEntryPoint ( > + IN EFI_PEI_FILE_HANDLE FileHandle, > + IN CONST EFI_PEI_SERVICES **PeiServices > + ) > +{ > + EFI_STATUS Status; > + > + // > + // Install EFI_PEI_MM_ACCESS_PPI for S3 resume case // Status =3D > + PeiInstallSmmAccessPpi (); > + > + return Status; > +} > diff --git a/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf > b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf > new file mode 100644 > index 00000000..847edd20 > --- /dev/null > +++ b/Platform/Intel/AdvancedFeaturePkg/S3/S3Pei.inf > @@ -0,0 +1,31 @@ > +### @file > +# Component information file for the S3 PEI module. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
# # > +SPDX-License-Identifier: BSD-2-Clause-Patent # ### > + > +[Defines] > + INF_VERSION =3D 0x00010017 > + BASE_NAME =3D S3Pei > + FILE_GUID =3D 8683EFB2-FDE1-4AFF-B2DB-E96449FDD4= E9 > + VERSION_STRING =3D 1.0 > + MODULE_TYPE =3D PEIM > + ENTRY_POINT =3D S3PeiEntryPoint > + > +[LibraryClasses] > + PeimEntryPoint > + PeiServicesLib > + SmmAccessLib > + > +[Packages] > + MdePkg/MdePkg.dec > + IntelSiliconPkg/IntelSiliconPkg.dec > + > +[Sources] > + S3Pei.c > + > +[Depex] > + gEfiPeiMemoryDiscoveredPpiGuid > -- > 2.16.2.windows.1 >=20 >=20 >=20