From: "Kubacki, Michael A" <michael.a.kubacki@intel.com>
To: "Agyeman, Prince" <prince.agyeman@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "philmd@redhat.com" <philmd@redhat.com>,
"Wei, David Y" <david.y.wei@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Sinha, Ankit" <ankit.sinha@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 1/3] AdvancedFeaturePkg: Fix GCC build
Date: Wed, 11 Sep 2019 23:54:28 +0000 [thread overview]
Message-ID: <49AB4ACB9627B8468F29D589A27B745588ABEC8C@ORSMSX121.amr.corp.intel.com> (raw)
In-Reply-To: <9c6eaf2883cc440905026a435b6bfb1ed6b89733.1568219401.git.prince.agyeman@intel.com>
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>
> -----Original Message-----
> From: Agyeman, Prince
> Sent: Wednesday, September 11, 2019 9:40 AM
> To: devel@edk2.groups.io
> Cc: philmd@redhat.com; Agyeman, Prince <prince.agyeman@intel.com>;
> Wei, David Y <david.y.wei@intel.com>; Gao, Liming <liming.gao@intel.com>;
> Sinha, Ankit <ankit.sinha@intel.com>; Kubacki, Michael A
> <michael.a.kubacki@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [PATCH v2 1/3] AdvancedFeaturePkg: Fix GCC build
>
> From: "Agyeman, Prince" <prince.agyeman@intel.com>
>
> Changed include file name Smbios.h to
> SmBios.h to fix gcc file not found
> build issue, due to case sensitive
> file names in Linux
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2162
>
> Cc: David Wei <david.y.wei@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Ankit Sinha <ankit.sinha@intel.com>
> Cc: Agyeman Prince <prince.agyeman@intel.com>
> Cc: Kubacki Michael A <michael.a.kubacki@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
> ---
> .../AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasic.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi
> c.h
> b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi
> c.h
> index e278a4ed18..944946b5b8 100644
> ---
> a/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi
> c.h
> +++
> b/Platform/Intel/AdvancedFeaturePkg/Smbios/SmbiosBasicDxe/SmbiosBasi
> c.h
> @@ -11,7 +11,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>
> #include <PiDxe.h>
> #include <Protocol/Smbios.h>
> -#include <IndustryStandard/Smbios.h>
> +#include <IndustryStandard/SmBios.h>
> #include <Library/UefiBootServicesTableLib.h>
> #include <Library/DebugLib.h>
> #include <Library/BaseLib.h>
> --
> 2.19.1.windows.1
next prev parent reply other threads:[~2019-09-11 23:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 16:40 [edk2-devel] [PATCH v2 0/3] Fix SimicsOpenBoardPkg GCC Build Agyeman, Prince
2019-09-11 16:40 ` [edk2-devel] [PATCH v2 1/3] AdvancedFeaturePkg: Fix GCC build Agyeman, Prince
2019-09-11 23:54 ` Kubacki, Michael A [this message]
2019-09-11 16:40 ` [edk2-devel] [PATCH v2 2/3] SimicsOpenBoardPkg: Fix GCC build issues Agyeman, Prince
2019-09-11 23:54 ` Kubacki, Michael A
2019-09-11 16:40 ` [edk2-devel] [PATCH v2 3/3] SimicsIch10Pkg: " Agyeman, Prince
2019-09-11 23:54 ` Kubacki, Michael A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AB4ACB9627B8468F29D589A27B745588ABEC8C@ORSMSX121.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox