From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: michael.a.kubacki@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Wed, 11 Sep 2019 16:54:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2019 16:54:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="197053303" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by orsmga002.jf.intel.com with ESMTP; 11 Sep 2019 16:54:49 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Sep 2019 16:54:49 -0700 Received: from orsmsx121.amr.corp.intel.com ([169.254.10.57]) by ORSMSX116.amr.corp.intel.com ([169.254.7.63]) with mapi id 14.03.0439.000; Wed, 11 Sep 2019 16:54:49 -0700 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "philmd@redhat.com" , "Wei, David Y" , "Gao, Liming" , "Sinha, Ankit" , "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [PATCH v2 2/3] SimicsOpenBoardPkg: Fix GCC build issues Thread-Topic: [edk2-devel] [PATCH v2 2/3] SimicsOpenBoardPkg: Fix GCC build issues Thread-Index: AQHVaL+bwe8WcOQDckaVdxwjAlyajKcnJgPg Date: Wed, 11 Sep 2019 23:54:48 +0000 Message-ID: <49AB4ACB9627B8468F29D589A27B745588ABECA8@ORSMSX121.amr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzY1Zjc2NzktZThhOC00YzNjLTk1ZmItODZjNmFiNzgzMGM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidFJnZ3BjbmVuZGZkTTlDVVlsZmZLUGpqZHQxaGN4SXBHMm5MOCtiYkxJbktqN2pQdVRrUmxMZkI1STluazVIUiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.a.kubacki@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Wednesday, September 11, 2019 9:40 AM > To: devel@edk2.groups.io > Cc: philmd@redhat.com; Agyeman, Prince ; > Wei, David Y ; Gao, Liming ; > Sinha, Ankit ; Kubacki, Michael A > ; Desimone, Nathaniel L > > Subject: [edk2-devel] [PATCH v2 2/3] SimicsOpenBoardPkg: Fix GCC build > issues >=20 > From: "Agyeman, Prince" >=20 > Removed unused functions in secMain.c >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2162 >=20 > Cc: David Wei > Cc: Liming Gao > Cc: Ankit Sinha > Cc: Agyeman Prince > Cc: Kubacki Michael A > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../PlatformBootManagerLib/BdsPlatform.c | 38 ------------------- > .../SimicsOpenBoardPkg/SecCore/SecMain.c | 23 ----------- > 2 files changed, 61 deletions(-) >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bds > Platform.c > b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bd > sPlatform.c > index 117c72b35f..953a4a6c15 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bds > Platform.c > +++ > b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/Bd > sPlatform.c > @@ -316,12 +316,6 @@ ConnectRootBridge ( > IN VOID *Context > ); >=20 > -STATIC > -VOID > -SaveS3BootScript ( > - VOID > - ); > - > // > // BDS Platform Functions > // > @@ -1296,38 +1290,6 @@ PlatformBdsConnectSequence ( > PciAcpiInitialization (); > } >=20 > -/** > - Save the S3 boot script. > - > - Note that DxeSmmReadyToLock must be signaled after this function > returns; > - otherwise the script wouldn't be saved actually. > -**/ > -STATIC > -VOID > -SaveS3BootScript ( > - VOID > - ) > -{ > - EFI_STATUS Status; > - EFI_S3_SAVE_STATE_PROTOCOL *BootScript; > - STATIC CONST UINT8 Info[] =3D { 0xDE, 0xAD, 0xBE, 0xEF }; > - > - Status =3D gBS->LocateProtocol (&gEfiS3SaveStateProtocolGuid, NULL, > - (VOID **) &BootScript); > - ASSERT_EFI_ERROR (Status); > - > - // > - // Despite the opcode documentation in the PI spec, the protocol > - // implementation embeds a deep copy of the info in the boot script, > rather > - // than storing just a pointer to runtime or NVS storage. > - // > - Status =3D BootScript->Write(BootScript, > EFI_BOOT_SCRIPT_INFORMATION_OPCODE, > - (UINT32) sizeof Info, > - (EFI_PHYSICAL_ADDRESS)(UINTN) &Info); > - ASSERT_EFI_ERROR (Status); > -} > - > - > /** > Do the platform specific action after the console is ready >=20 > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > index 5cbb47687b..4514641b46 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > @@ -495,29 +495,6 @@ FindPeiCoreImageBaseInFv ( > return EFI_SUCCESS; > } >=20 > - > -/** > - Reads 8-bits of CMOS data. > - > - Reads the 8-bits of CMOS data at the location specified by Index. > - The 8-bit read value is returned. > - > - @param Index The CMOS location to read. > - > - @return The value read. > - > -**/ > -STATIC > -UINT8 > -CmosRead8 ( > - IN UINTN Index > - ) > -{ > - IoWrite8 (0x70, (UINT8) Index); > - return IoRead8 (0x71); > -} > - > - > STATIC > BOOLEAN > IsS3Resume ( > -- > 2.19.1.windows.1