From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: michael.a.kubacki@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 11 Sep 2019 16:54:57 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Sep 2019 16:54:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="187335187" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga003.jf.intel.com with ESMTP; 11 Sep 2019 16:54:56 -0700 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 11 Sep 2019 16:54:55 -0700 Received: from orsmsx121.amr.corp.intel.com ([169.254.10.57]) by ORSMSX158.amr.corp.intel.com ([169.254.10.46]) with mapi id 14.03.0439.000; Wed, 11 Sep 2019 16:54:55 -0700 From: "Kubacki, Michael A" To: "Agyeman, Prince" , "devel@edk2.groups.io" CC: "philmd@redhat.com" , "Wei, David Y" , "Gao, Liming" , "Sinha, Ankit" , "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [PATCH v2 3/3] SimicsIch10Pkg: Fix GCC build issues Thread-Topic: [edk2-devel] [PATCH v2 3/3] SimicsIch10Pkg: Fix GCC build issues Thread-Index: AQHVaL+ebWpS5kgAvkCUvOExpDFEKqcnJgfg Date: Wed, 11 Sep 2019 23:54:54 +0000 Message-ID: <49AB4ACB9627B8468F29D589A27B745588ABECB2@ORSMSX121.amr.corp.intel.com> References: <3d85dd4ce503ef01b66ab4be55bfcf921c7e7012.1568219401.git.prince.agyeman@intel.com> In-Reply-To: <3d85dd4ce503ef01b66ab4be55bfcf921c7e7012.1568219401.git.prince.agyeman@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzgyOTRkNGEtZmYwZS00ZTg0LTg4ZmEtNjhkNzM1YzNjZjk4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMDRkdm40bURFcGhaSGFZbkpQdWlMZEpOZ3V0aWNoN2hLVVVRaXdPd2FhOUFNWmpFa0ttbGlqKzhERFlxRkg5cyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Return-Path: michael.a.kubacki@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Michael Kubacki > -----Original Message----- > From: Agyeman, Prince > Sent: Wednesday, September 11, 2019 9:40 AM > To: devel@edk2.groups.io > Cc: philmd@redhat.com; Agyeman, Prince ; > Wei, David Y ; Gao, Liming ; > Sinha, Ankit ; Kubacki, Michael A > ; Desimone, Nathaniel L > > Subject: [edk2-devel] [PATCH v2 3/3] SimicsIch10Pkg: Fix GCC build issues >=20 > From: "Agyeman, Prince" >=20 > Removed Status variable as the SmmClear > function always returns EFI_SUCCESS. > Refer to the Smmclear function for > details >=20 > Removed SpiBaseAddress variable as this > address was never used in the SendSpiCmd function. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2162 >=20 > Cc: David Wei > Cc: Liming Gao > Cc: Ankit Sinha > Cc: Agyeman Prince > Cc: Kubacki Michael A > Cc: Nate DeSimone >=20 > Signed-off-by: Prince Agyeman > --- > .../LibraryPrivate/BasePchSpiCommonLib/SpiCommon.c | 3 --- > .../SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2Dxe.c | 7 ++----- > 2 files changed, 2 insertions(+), 8 deletions(-) >=20 > diff --git > a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCo > mmon.c > b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCo > mmon.c > index bd08b2453b..3e7dffedfb 100644 > --- > a/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCo > mmon.c > +++ b/Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/Sp > +++ iCommon.c > @@ -637,7 +637,6 @@ SendSpiCmd ( > EFI_STATUS Status; > UINT32 Index; > SPI_INSTANCE *SpiInstance; > - UINTN SpiBaseAddress; > UINTN PchSpiBar0; > UINT32 HardwareSpiAddr; > UINT32 FlashRegionSize; > @@ -648,9 +647,7 @@ SendSpiCmd ( >=20 > Status =3D EFI_SUCCESS; > SpiInstance =3D SPI_INSTANCE_FROM_SPIPROTOCOL (This); > - SpiBaseAddress =3D SpiInstance->PchSpiBase; > PchSpiBar0 =3D AcquireSpiBar0 (SpiInstance); > - SpiBaseAddress =3D SpiInstance->PchSpiBase; > ABase =3D SpiInstance->PchAcpiBase; >=20 > // > diff --git > a/Silicon/Intel/SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2Dxe.c > b/Silicon/Intel/SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2Dxe.c > index 268b04d25a..cc2d00b785 100644 > --- > a/Silicon/Intel/SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2Dxe.c > +++ > b/Silicon/Intel/SimicsIch10Pkg/SmmControl/RuntimeDxe/SmmControl2Dxe. > +++ c > @@ -131,7 +131,6 @@ SmmControl2DxeTrigger ( > IN UINTN ActivationInterval OPTIONAL > ) > { > - EFI_STATUS Status; > // > // No support for queued or periodic activation. > // > @@ -141,7 +140,7 @@ SmmControl2DxeTrigger ( > /// > /// Clear any pending the APM SMI > /// > - Status =3D SmmClear(); > + SmmClear(); > // > // The so-called "Advanced Power Management Status Port Register" is i= n > fact > // a generic data passing register, between the caller and the SMI @@ = - > 181,8 +180,6 @@ SmmControl2DxeClear ( > IN BOOLEAN Periodic OPTIONAL > ) > { > - EFI_STATUS Status; > - > if (Periodic) { > return EFI_INVALID_PARAMETER; > } > @@ -201,7 +198,7 @@ SmmControl2DxeClear ( > // > // So, nothing to do here. > // > - Status =3D SmmClear(); > + SmmClear(); >=20 > return EFI_SUCCESS; > } > -- > 2.19.1.windows.1